Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 17 Aug 2022 19:50:06 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     John Hubbard <jhubbard@nvidia.com>
Cc:     Alistair Popple <apopple@nvidia.com>, linux-mm@kvack.org,
        akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
        "Sierra Guiza, Alejandro (Alex)" <alex.sierra@amd.com>,
        Chaitanya Kulkarni <kch@nvidia.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Felix Kuehling <Felix.Kuehling@amd.com>,
        Logan Gunthorpe <logang@deltatee.com>,
        Miaohe Lin <linmiaohe@huawei.com>,
        Muchun Song <songmuchun@bytedance.com>,
        Ralph Campbell <rcampbell@nvidia.com>,
        David Hildenbrand <david@redhat.com>,
        Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH v4 2/2] mm/gup.c: Refactor
 check_and_migrate_movable_pages()
Message-ID: <Yv1wntznpzSXuTYh@nvidia.com>
References: <487960bf67c7273ff5606c76f73bb51271bc7b90.1660269441.git-series.apopple@nvidia.com>
 <6b61e9bf7c65f78524db32ba3e65a7eb6b8a76a0.1660269441.git-series.apopple@nvidia.com>
 <YvpxOyrDBUHagpC6@nvidia.com>
 <87edxgvixy.fsf@nvdebian.thelocal>
 <Yvt/hZYfSvlCbU02@nvidia.com>
 <87wnb7tycb.fsf@nvdebian.thelocal>
 <YvzaXeRox/9fqfdW@nvidia.com>
 <de9a3db9-6130-fe07-88ec-7e728ff5701c@nvidia.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <de9a3db9-6130-fe07-88ec-7e728ff5701c@nvidia.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?E9S1Rky5MLTgQiBaXC23FKNjPxTsPLEcNsqqqmBNSonP36NFsIBG79rXX8d1?=
 =?us-ascii?Q?uPeb0ljy4VF294wsXZh9vLOeCUD1Yw+HnJbv+mZ7B7Ny6F+vvGySXFKXZ4lo?=
 =?us-ascii?Q?DKukLLNxdOeqDmQNdGPcLBDXBO3NhB71BhjCppBnMs9yQ4GvEov4WQROmmj9?=
 =?us-ascii?Q?2q91cA3wW3p9trOEaAWCEdjlkJsNHhxaCE3Md1fUx4V8lDlukSTe6OcslUcv?=
 =?us-ascii?Q?BJJP+sohU7mp+y2FYJaCJ5SMyMjLeoAQv5sPXdhqgOLZoUxI8DttIxVseGVY?=
 =?us-ascii?Q?lTikUwa7bD1f2jlrkanegKZZ1kFsb/LbjoIDOub338B4H17/m8gmnoGqtE5s?=
 =?us-ascii?Q?jSojck2ouujNBMjAw5BISZd5rWP2Pb1xITrZ9zwEwBBmBEvwKTyOzM+pZ6C1?=
 =?us-ascii?Q?f8R3jqDPxT7rIanzFX21Rmg49fmctpgqtmZNO+y5sbZ4QNrq4zJGjppmAf0m?=
 =?us-ascii?Q?m6xB3XOHEs9PLo95WVWp4p2q6OuqfASIbhNnxgan31n3dQgbMcErl91Zd9SU?=
 =?us-ascii?Q?+Lt7L729Cx+E54oXPNdkdXXrKOSPVg9AlkozKk3gIMtFHSqLPVQ/Vk+B3Hdy?=
 =?us-ascii?Q?3cXWk3tcGpSZMtoU6ZKFuwHfZayAHfC6nal/9jiMLPwMyugd0UW5mFMXAyd/?=
 =?us-ascii?Q?XziL7HnB4smnsPV9oxAZ6fku48DpY2iJnJK7xaqTC9GieXer0x0LtKIA15Ww?=
 =?us-ascii?Q?shHolI22LeiFOcilLfGKuLFr7efF8lXXvenugwAMNthObYK1UscWSyRxOZSS?=
 =?us-ascii?Q?wSp1UF3xCHdLy0Rbq2JN46zhWVDVWreT1zIpZEXExh8HTWfdyZaNe/B2rfvQ?=
 =?us-ascii?Q?9AUIAhx31N+LbbqrdzB/+R30RUGKwFLOKZ1PiDD39ASwaeVwcOdprMhEWedf?=
 =?us-ascii?Q?Qg4k+1Zg2XVF6SQCwkOm/jIpoxrtx5R6iMktw2wlrWxG7USQivQUU+MJvnPe?=
 =?us-ascii?Q?UYRDl22vS87/Pma5DqfUnaafjrzBkqyUQokFWfQ7VeiahyThI8kcZLCI++I+?=
 =?us-ascii?Q?1gh4bE8m6cQSr3WfCfF1pzCNFoUYiypnvxKkUe1ZBoPYs4/yLxEsFylYBK/4?=
 =?us-ascii?Q?+zzgyqY0Q3zIC0GZfwmyzkoxZbapJcCRG7BEOwjDMbjmQ1RZFHEY1aeP0JnR?=
 =?us-ascii?Q?1FRlOOan3YXBtwegtlSKZdwZSwWdpCeXW24GPpn2Dk7w2CTrkDSve2eseJvk?=
 =?us-ascii?Q?tavxmPLkHwBrrSTwKAq3whoZXHokyOqzlnwW1fbzae7GIc552V5fJs9JYMxR?=
 =?us-ascii?Q?lZ1MOa4O1mr5iHK6uUNAtedIOBVx9A3xtfYZy8oppnQ/ujTYM6r8gYY/dD/w?=
 =?us-ascii?Q?IFZzVzb7scXJGNut6fcaEbPQAP7Ka2XSG021dU+djj55KSrzEvrDD/auiyyv?=
 =?us-ascii?Q?7yW2z0cxkTHP1ZsNx00ElAtbKVfZwq9jZsssVyI5K/iQd69q0d8ICxH91irH?=
 =?us-ascii?Q?1XYWhf9jdvXec62INJOyW6uxsqSQBZCInQbvpD61pUdZcAaEBSr3YmRSeJqo?=
 =?us-ascii?Q?CHULB0oqmsHl03dhSZXOmh1JH0IA57PCY0g0SSKEOELtZo/WUVXxSJ8Tb/zT?=
 =?us-ascii?Q?PhI0PFR7RsB0ZzyBBsutTohidpeUY9LYtuWQqeC/?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 11b9fca3-a9d6-45a7-1951-08da80a2d4c0
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Aug 2022 22:50:07.0337
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mvxzPLGjxVk5GEVNFy8SspjuSfxtL2Kq5h6rdc0mPRC8tdZq50PZqQ4Pxo7RxQrL
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB3041
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Aug 17, 2022 at 01:35:12PM -0700, John Hubbard wrote:
> How's this look to you:
> 
> 	collected = collect_longterm_unpinnable_pages(&movable_page_list,
> 						      nr_pages, pages);
> 	if (collected == 0)
> 		return 0;
> 
> 	ret = migrate_longterm_unpinnable_pages(&movable_page_list, nr_pages,
> 						pages);
> 
> 	/* If we got here, we have some unpinnable pages... */
> 
> 	if (ret == 0) {
> 		/*
> 		 * ...and we successfully migrated those pages. Which means that
> 		 * the caller should retry the operation now.
> 		 */
> 		ret = -EAGAIN;

return -EAGAIN

> 	}
> 
> 	return ret;

But why return 0 from the helper function in the first place?

Jason