Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Wang, Haiyue" <haiyue.wang@intel.com>
To:     Mike Kravetz <mike.kravetz@oracle.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Michael Ellerman <mpe@ellerman.id.au>
CC:     "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "david@redhat.com" <david@redhat.com>,
        "apopple@nvidia.com" <apopple@nvidia.com>,
        "linmiaohe@huawei.com" <linmiaohe@huawei.com>,
        "Huang, Ying" <ying.huang@intel.com>,
        "songmuchun@bytedance.com" <songmuchun@bytedance.com>,
        "naoya.horiguchi@linux.dev" <naoya.horiguchi@linux.dev>,
        "alex.sierra@amd.com" <alex.sierra@amd.com>,
        Heiko Carstens <hca@linux.ibm.com>,
        Vasily Gorbik <gor@linux.ibm.com>,
        Alexander Gordeev <agordeev@linux.ibm.com>,
        Christian Borntraeger <borntraeger@linux.ibm.com>,
        Sven Schnelle <svens@linux.ibm.com>
Subject: RE: [PATCH v6 1/2] mm: migration: fix the FOLL_GET failure on
 following huge page
Thread-Topic: [PATCH v6 1/2] mm: migration: fix the FOLL_GET failure on
 following huge page
Thread-Index: AQHYsRbS1IjgnpM1/EaZo6nPqIEeuq2yRsoAgAAoZ1CAACcnAIAAxGeAgABL+wCAACmt4A==
Date:   Thu, 18 Aug 2022 00:32:52 +0000
Message-ID: <BYAPR11MB34955C296ED10CF23D372607F76D9@BYAPR11MB3495.namprd11.prod.outlook.com>
References: <20220812084921.409142-1-haiyue.wang@intel.com>
 <20220816022102.582865-1-haiyue.wang@intel.com>
 <20220816022102.582865-2-haiyue.wang@intel.com>
 <20220816175838.211a1b1e85bc68c439101995@linux-foundation.org>
 <BYAPR11MB3495F747CBF95E079E8FC8A5F76A9@BYAPR11MB3495.namprd11.prod.outlook.com>
 <20220816224322.33e0dfbcbf522fcdc2026f0e@linux-foundation.org>
 <Yv0ku1mn4LBzg/zG@monkey> <Yv1kePLTUJbJkpUW@monkey>
In-Reply-To: <Yv1kePLTUJbJkpUW@monkey>
Accept-Language: zh-CN, en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.6.500.17
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?HbBtZn8IQZDBASaSa9W+KZ1CGVTktJfGo5oDsTWcqaKjXjAH9ACP22m37zPs?=
 =?us-ascii?Q?77otZQDJkh+15qJp2xvrNc9rHUPovtmUl7iI0B0JfYsgGJTU7oP+nrAQo1rD?=
 =?us-ascii?Q?vJIQcb/8XzNqRMalAQCTS0LxQShrJr9+yelarMMR7aIXod77goQXLiPulOI2?=
 =?us-ascii?Q?GeVrdykY2Zp1QeIyFzENVCxcHYsfUgrsp4DWLE91ArUB8KKAb/jzL+b0+zYJ?=
 =?us-ascii?Q?BAFOiO+cBQjGFzYhPd7fU97OihbvWt2BmTJvwaEHBbLKsaj2goTnxXI7gsXs?=
 =?us-ascii?Q?zAR9yAwQOI0L+J3LW59Xv5TE2nvl1+4JAwtn+ILjFeOosP6/zBgMkhSL3Jgs?=
 =?us-ascii?Q?6E+Oby7GJUdz1vFZ0ih3+vdRu/3FDNU8r7fBMOlE+i4Wo/A0mLGL8RHoYjAX?=
 =?us-ascii?Q?BHeN+sqT2W7DOQ4W5Z7jvcaI2wvYPBAqxD6O54Ttd2wzzp7RbaNUP12joeN2?=
 =?us-ascii?Q?qkWXP8q6iu3rtyuNVvMn1PE0d6crzqU9nXgZOYM3gzZramLY9Dttx7RwPVYu?=
 =?us-ascii?Q?Gj2e1nWGBGLMhE+V0ym64el9kqv2pQ9dvj4VBKS2t8tINfcnkfPF/EhC1fQL?=
 =?us-ascii?Q?G3ukH30VCRtKpEJIJzsOFKbbCHb0uBcnkFbv+maTG9f/j/+iRr4aNhYQhtSA?=
 =?us-ascii?Q?cR5CdZlFvXQ/BWNRhGNImOYCjl/IcFj5mOZg7YONBAprdxRPZn3bY0PKiKQX?=
 =?us-ascii?Q?gOIi743efLqUVOXBQB/ccZzqYLPOJRZ6DH9xfCKKfcM7YYK7rAPfUWie2nRw?=
 =?us-ascii?Q?KN/lTESpc3M8hIDvTFcH9p9W0tuhXvWfUAtF3V72CfJybV8GJDaqAQ4g7aas?=
 =?us-ascii?Q?+v02gYezIv5NoavwqLgazINYdNKDwzlQlo2x6NqeGzI6MTNmTx/WzwPc9USI?=
 =?us-ascii?Q?MkPZFUf3jibJGPxEnuePpDxnMgC9IDyB19bW8R3U+0DJG3Uqr+1Jm4R/Amq2?=
 =?us-ascii?Q?ltVyiKmRoYTjCC1k+SDc3BOLZwjkMHuK/+W7SBOzazfS9AwAqFPtZVpAI8Yx?=
 =?us-ascii?Q?fK+q4MFTrmqE/18w5nGLEaAL6t6DFP2opdtbqz2laoi59l4o6sLfnpPiCkw5?=
 =?us-ascii?Q?O4H+GHlcmcJnij+dCStcA79tltqo6RSpgI1yHQFx4KZoNsLC82/I3dprogCP?=
 =?us-ascii?Q?oFWmcSDdAahXapAmm6hXMjpil6C8VIHIJO9eHiq5hMUVmAcE51c3Tia0Mwa3?=
 =?us-ascii?Q?ygZLzNxCfBq3kTaJP3bDFQEOcQDnEJ3p9UA6z2P+qOlBG906jFRg2Tr3LrYX?=
 =?us-ascii?Q?XpJ+lINNEGv7zBbOD1XiG4h7A5tGsc+FSSC3nqPWqJV2VlllR0+JtEbjnITh?=
 =?us-ascii?Q?/gAK1PTqyZhCvzV+YV03xtsTBIFSVjx7dWpzlF1foknbZhW+x2jpZSMHbt1F?=
 =?us-ascii?Q?KRoAr0BDShGm7k3nzaaAEnmBDvi0YeVkM+lFjUXPXqBy9JB1afRppQpYcfFF?=
 =?us-ascii?Q?oJVlQhlaeFBRqgTUOA6VvoygtYk0U/EgZVNUrotOrCHV7bcXDt+FcdpiTSSD?=
 =?us-ascii?Q?6v4a2wjsE6lO3tH1Vc7VJ9G7Ohflas3H0bLCMdQW4CIj7OUlaVTjAm6dbNT0?=
 =?us-ascii?Q?3jK3x9IxaPAkfzllLSH1ao5/w7zFR+fKC/kdBbB5?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3495.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5c4b7d43-3876-46ff-4768-08da80b12fa1
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Aug 2022 00:32:52.2387
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: TH4x5o4+VQo6Hu99LFJiWuolQLbg2x5XQpLI9YIVlCwQVis3Rb3+ZGHLPzc8MfB/JWq8pecMq+xos2mI8Tw/ZA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5133
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HK_RANDOM_ENVFROM,
        HK_RANDOM_FROM,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Mike Kravetz <mike.kravetz@oracle.com>
> Sent: Thursday, August 18, 2022 05:58
> To: Andrew Morton <akpm@linux-foundation.org>; Michael Ellerman <mpe@elle=
rman.id.au>
> Cc: Wang, Haiyue <haiyue.wang@intel.com>; linux-mm@kvack.org; linux-kerne=
l@vger.kernel.org;
> david@redhat.com; apopple@nvidia.com; linmiaohe@huawei.com; Huang, Ying <=
ying.huang@intel.com>;
> songmuchun@bytedance.com; naoya.horiguchi@linux.dev; alex.sierra@amd.com;=
 Heiko Carstens
> <hca@linux.ibm.com>; Vasily Gorbik <gor@linux.ibm.com>; Alexander Gordeev=
 <agordeev@linux.ibm.com>;
> Christian Borntraeger <borntraeger@linux.ibm.com>; Sven Schnelle <svens@l=
inux.ibm.com>
> Subject: Re: [PATCH v6 1/2] mm: migration: fix the FOLL_GET failure on fo=
llowing huge page
>=20
> On 08/17/22 10:26, Mike Kravetz wrote:
> > On 08/16/22 22:43, Andrew Morton wrote:
> > > On Wed, 17 Aug 2022 03:31:37 +0000 "Wang, Haiyue" <haiyue.wang@intel.=
com> wrote:
> > >
> > > > > >  		}
> > > > >
> > > > > I would be better to fix this for real at those three client code=
 sites?
> > > >
> > > > Then 5.19 will break for a while to wait for the final BIG patch ?
> > >
> > > If that's the proposal then your [1/2] should have had a cc:stable an=
d
> > > changelog words describing the plan for 6.0.
> > >
> > > But before we do that I'd like to see at least a prototype of the fin=
al
> > > fixes to s390 and hugetlb, so we can assess those as preferable for
> > > backporting.  I don't think they'll be terribly intrusive or risky?
> >
> > I will start on adding follow_huge_pgd() support.  Although, I may need
> > some help with verification from the powerpc folks, as that is the only
> > architecture which supports hugetlb pages at that level.
> >
> > mpe any suggestions?
>=20
> From 4925a98a6857dbb5a23bd97063ded2648863e65e Mon Sep 17 00:00:00 2001
> From: Mike Kravetz <mike.kravetz@oracle.com>
> Date: Wed, 17 Aug 2022 14:32:10 -0700
> Subject: [PATCH] hugetlb: make follow_huge_pgd support FOLL_GET
>=20
> The existing version of follow_huge_pgd was very primitive and only
> provided limited functionality.  Specifically, it did not support
> FOLL_GET.  Update follow_huge_pgd with modifications similar to those
> made for follow_huge_pud in commit 3a194f3f8ad0 ("mm/hugetlb: make
> pud_huge() and follow_huge_pud() aware of non-present pud entry").
>=20
> Note, common code should be factored out of follow_huge_p*d routines.
> This will be done in future modifications.
>=20

I found "Anshuman Khandual <khandual@linux.vnet.ibm.com>" submit the simila=
r
patch on "Apr 2016 11:07:37 +0530"

[PATCH 03/10] mm/hugetlb: Protect follow_huge_(pud|pgd) functions from race
https://lore.kernel.org/all/1460007464-26726-4-git-send-email-khandual@linu=
x.vnet.ibm.com/

> Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com>
> ---
>  mm/hugetlb.c | 32 ++++++++++++++++++++++++++++++--
>  1 file changed, 30 insertions(+), 2 deletions(-)
>=20
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index ea1c7bfa1cc3..6f32d2bd1ca9 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -7055,10 +7055,38 @@ follow_huge_pud(struct mm_struct *mm, unsigned lo=
ng address,
>  struct page * __weak
>  follow_huge_pgd(struct mm_struct *mm, unsigned long address, pgd_t *pgd,=
 int flags)
>  {
> -	if (flags & (FOLL_GET | FOLL_PIN))
> +	struct page *page =3D NULL;
> +	spinlock_t *ptl;
> +	pte_t pte;
> +
> +	if (WARN_ON_ONCE(flags & FOLL_PIN))
>  		return NULL;
>=20
> -	return pte_page(*(pte_t *)pgd) + ((address & ~PGDIR_MASK) >> PAGE_SHIFT=
);
> +retry:
> +	ptl =3D huge_pte_lock(hstate_sizelog(PGDIR_SHIFT), mm, (pte_t *)pgd);
> +	if (!pgd_huge(*pgd))
> +		goto out;
> +	pte =3D huge_ptep_get((pte_t *)pgd);
> +	if (pte_present(pte)) {
> +		page =3D pgd_page(*pgd) + ((address & ~PGDIR_MASK) >> PAGE_SHIFT);
> +		if (WARN_ON_ONCE(!try_grab_page(page, flags))) {
> +			page =3D NULL;
> +			goto out;
> +		}
> +	} else {
> +		if (is_hugetlb_entry_migration(pte)) {
> +			spin_unlock(ptl);
> +			__migration_entry_wait(mm, (pte_t *)pgd, ptl);
> +			goto retry;
> +		}
> +		/*
> +		 * hwpoisoned entry is treated as no_page_table in
> +		 * follow_page_mask().
> +		 */
> +	}
> +out:
> +	spin_unlock(ptl);
> +	return page;
>  }
>=20
>  int isolate_hugetlb(struct page *page, struct list_head *list)
> --
> 2.37.1