Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp5432685rwb; Wed, 17 Aug 2022 18:05:08 -0700 (PDT) X-Google-Smtp-Source: AA6agR6mZ/uFdDNuZ2tOI3VfOZLy+hX31QZwqT13b1IXa2xBXghu+X93pkTCv9/Yu4Wdx/sALcRt X-Received: by 2002:a05:6402:3552:b0:43d:a634:3997 with SMTP id f18-20020a056402355200b0043da6343997mr437323edd.389.1660784707853; Wed, 17 Aug 2022 18:05:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660784707; cv=none; d=google.com; s=arc-20160816; b=EFQ+wzOLsjcEsT/sH/rWt7G6mbAk1Vb1XpZNypO+BIrlW1pzZZ9j0TmqnH5sWf2Zk5 5E5Go1mYrt1lDeHjmJGh+Q9Seum5Hm3JyJtXoR/LdQqeK6sTrNRm/VlzHKr5AWu5jGqf LpDstyrbiRvFZF2kwQei989rGNfe3oOEmzLjEYGA2eoTIgBE4d63m+J210mjjp8Hh8RU u0Z2QwKdhSa3WpYskUB1CWZCqo9bol8R8t5jokrUJ9pMAUcY0gUxvP5/TqFSews2VlZc J2kRF0vvZuDPLRcqC2xWY8GXsG9K5/xo9Vrh0jKdyhYre9QZEI/L4Bu5Ndt63dfUnljQ cbvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dkim-signature; bh=/n1PTtzt1ZAJeMiPqpf/RaGSSkqStAAdg3uVTHyQXmk=; b=hIGu1zR30h64p4wKVU7JgfWUNShfjqPXDzLXhCwryZR8XAD3xxML/71Rpun3NK7802 1vLQW7CdGE52YMPmZ2m3O8FD1ZsEDdMcKXST8Tf9ca1IeTXj4AZ5Pke1LNpVR2lHWp3D x1EgU+ofc3fVGXfI92eDGP0zC6H1T7KhinSyI0BUHjPCreudJljnpVYeD7vOm7lA6syD oEiOsvrA8Q/W/JZ1x8Ag40LbXzT1Wk6DrUVBACeLR2l714OclEQue1dCo9CITWrVKG0x ru/ELYKWfb3jR03QDo/LmqEV1cwZgF4cvA8p4bRxfeDPb0m4WwzgCzGMtZ9TQTNsYkEr ubCQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=F6EhzANP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ka14-20020a170907920e00b00730851fb298si38838ejb.501.2022.08.17.18.04.41; Wed, 17 Aug 2022 18:05:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=F6EhzANP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241705AbiHRAwM (ORCPT + 99 others); Wed, 17 Aug 2022 20:52:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233588AbiHRAwK (ORCPT ); Wed, 17 Aug 2022 20:52:10 -0400 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B477972EC3 for ; Wed, 17 Aug 2022 17:52:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1660783929; x=1692319929; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version; bh=58ON10/L8BlQ/a/6dmh5aWnxs++pUDrqF1IpJhK5uis=; b=F6EhzANPbbXku2kV/+bTJEN5agiuruB7WWKa08RJdLXjm0iNk1O38Vso iPr+bybRKhf1rZl7keZbhZEv/lhm2PZWIHxGFkwNZ8Qe/Wf4nY4LWY2ij HLg+yyfrR8uSTr29mZHSalL0jBve9hc7gZX6f/N/Rd+LoS+L7HqnWPYEk 1ePCmXQlsiy7tBEkU3bCtAOzTA2HeC5DZSMq6/q3FrmQ02EmxPBYVIWW7 RZnu29e3vAW+es6uWfox+S6qVLnxJEMsturNAScx5sy5D6VRlsQRJxvr8 stj07L7ZnbOLQ/4bnByIK6122lELtlj+kT/S9/bs/Lu14v0pVoFaU2JH7 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10442"; a="272402439" X-IronPort-AV: E=Sophos;i="5.93,244,1654585200"; d="scan'208";a="272402439" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Aug 2022 17:52:09 -0700 X-IronPort-AV: E=Sophos;i="5.93,244,1654585200"; d="scan'208";a="935589924" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Aug 2022 17:52:07 -0700 From: "Huang, Ying" To: Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Baolin Wang , Zi Yan , Yang Shi , Oscar Salvador Subject: Re: [PATCH -V3 0/8] migrate_pages(): fix several bugs in error path References: <20220817081408.513338-1-ying.huang@intel.com> <20220817084833.b348d11eab362b2ac5a02259@linux-foundation.org> Date: Thu, 18 Aug 2022 08:51:56 +0800 In-Reply-To: <20220817084833.b348d11eab362b2ac5a02259@linux-foundation.org> (Andrew Morton's message of "Wed, 17 Aug 2022 08:48:33 -0700") Message-ID: <87pmgybcgj.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andrew Morton writes: > On Wed, 17 Aug 2022 16:14:00 +0800 Huang Ying wrote: > >> error-inject.patch, test-migrate.c, and test-migrate.sh are as below. >> It turns out that error injection is an important tool to fix bugs in >> error path. > > Indeed, and thanks for doing this. > > Did you consider lib/*inject*.c? If so, was it unsuitable? I haven't take a deep look at that. Will do that. Best Regards, Huang, Ying