Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 17 Aug 2022 19:48:39 -0600
From:   Rob Herring <robh@kernel.org>
To:     Eliav Farber <farbere@amazon.com>
Cc:     brgl@bgdev.pl, mark.rutland@arm.com, arnd@arndb.de,
        gregkh@linuxfoundation.org, linux-i2c@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        talel@amazon.com, hhhawa@amazon.com, jonnyc@amazon.com,
        hanochu@amazon.com, ronenk@amazon.com, itamark@amazon.com,
        shellykz@amazon.com, shorer@amazon.com, amitlavi@amazon.com,
        almogbs@amazon.com, dwmw@amazon.co.uk
Subject: Re: [PATCH 1/2] dt-bindings: at24: new optional property -
 enable-gpios
Message-ID: <20220818014839.GD921960-robh@kernel.org>
References: <20220816130002.41450-1-farbere@amazon.com>
 <20220816130002.41450-2-farbere@amazon.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220816130002.41450-2-farbere@amazon.com>
Precedence: bulk

On Tue, Aug 16, 2022 at 01:00:01PM +0000, Eliav Farber wrote:
> Boards using the AT24 EEPROMs might have a GPIO that must be set to
> enable the chip (e.g. pin that controls the power supply).
> 

If this is a power supply control, use a gpio regulator.

> Add a new optional property to the device tree binding document, which
> allows to specify the GPIO line to which the enable pin is connected.
> 
> On Linux this means that we need to hog the line at the beginning of
> probe function.
> 
> Signed-off-by: Eliav Farber <farbere@amazon.com>
> ---
>  Documentation/devicetree/bindings/eeprom/at24.txt | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/eeprom/at24.txt b/Documentation/devicetree/bindings/eeprom/at24.txt
> index f9a7c984274c..553b53ed3e4c 100644
> --- a/Documentation/devicetree/bindings/eeprom/at24.txt
> +++ b/Documentation/devicetree/bindings/eeprom/at24.txt
> @@ -73,6 +73,9 @@ Optional properties:
>  
>    - wp-gpios: GPIO to which the write-protect pin of the chip is connected.
>  
> +  - enable-gpios: GPIO to enables the chip (e.g. pin that controls the eeprom
> +                  power supply).
> +
>    - address-width: number of address bits (one of 8, 16).
>  
>  Example:
> -- 
> 2.37.1
>