Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9c791de0-b702-1bbe-38a4-30e87d9d1b95@intel.com>
Date:   Thu, 18 Aug 2022 10:00:47 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.12.0
Subject: Re: [PATCH 4/6] mm: hugetlb_vmemmap: add missing smp_wmb() before
 set_pte_at()
Content-Language: en-US
To:     Miaohe Lin <linmiaohe@huawei.com>,
        "Yin, Fengwei" <fengwei.yin@intel.com>,
        Muchun Song <muchun.song@linux.dev>
CC:     Andrew Morton <akpm@linux-foundation.org>,
        Mike Kravetz <mike.kravetz@oracle.com>,
        Muchun Song <songmuchun@bytedance.com>,
        Linux MM <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>
References: <20220816130553.31406-1-linmiaohe@huawei.com>
 <20220816130553.31406-5-linmiaohe@huawei.com>
 <D8C00BDA-160D-40CE-AFBD-9488F85E76CE@linux.dev>
 <ea67ab10-667e-f361-b80f-dafb13da4808@huawei.com>
 <0EAF1279-6A1C-41FA-9A32-414C36B3792A@linux.dev>
 <019c1272-9d01-9d51-91a0-2d656b25c318@intel.com>
 <18adbf89-473e-7ba6-9a2b-522e1592bdc6@huawei.com>
From:   "Yin, Fengwei" <fengwei.yin@intel.com>
In-Reply-To: <18adbf89-473e-7ba6-9a2b-522e1592bdc6@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SDdWbnFscHNNaStoYU9JRi9VbERSazdFbzgvL0FDTnNBUUxCb0ovWVdiT2M3?=
 =?utf-8?B?Ky9kTDNhcFFZZkN0THc5akJCRHBsRENVU1B6QUpPRGdLUEtSaTNDSGdFTk9G?=
 =?utf-8?B?T3ZxSHRKdVJYMGYxWHo1c1ptWFBvcFlmU3pNVHNrSHRTdDNPeHRQMmRDTHQ1?=
 =?utf-8?B?cnBhRHJxU29WQWk4NFdmZk52ZDdkc0pkMFdHRWc2ZjIzZVZ1TVF3dGFRQUpa?=
 =?utf-8?B?YWV6eGVVZkJhS0lPLzJGOFJucmorc2MzV0pLa0laeUpZZW9LbzRKQ1l0MHZT?=
 =?utf-8?B?ckRleWUvZWVrTnBXVDUyeVZ6YkxzNUQvVVNmZGdmZ1dhdUFOd0hjUlJ1V0Jn?=
 =?utf-8?B?NnZ5TGcwRkxaTHQrd20vSUpiM0duM1kxeDY3VzNKek1BNHYwbHV4dTYwOCtL?=
 =?utf-8?B?M0MxZ0ZjM080Ui9zWXZZN1R2ZUIrU3JoUk82eGlkNFlSVFc5SlMxWWpaN0pP?=
 =?utf-8?B?aWc1eEpuOU9VOURONTBNY3pnNDlsanpNekZRSzVlQmV5UnltbU5OSm5DRjU4?=
 =?utf-8?B?Rk84ZTVXcHpQVm1rT0dwSG50YUtITlZoK3hncWtoYi9ScStwWHFNR0poVFFz?=
 =?utf-8?B?VjlWMTdvM21EaTA2OVlHcXVTY0VjbGNrRkV6K3hiU2hReXBXMFc5bUl2WGZQ?=
 =?utf-8?B?WEpRZGpKbmEyOGN0dUJOdkZOVlhCdVFVcW5XVlRmNThpMVBSYUl5ZEpEUFR3?=
 =?utf-8?B?N1puaTlybmJ4dGpkUFVISTFjTnFLaGNueHgrVTJBSkdLWG13L3BONk16MHpk?=
 =?utf-8?B?MGlJUHlnWWRndktpWUxvOFUram5OWDlGakNhT2F6Mi9pMXVSeFZPWUJzRHRD?=
 =?utf-8?B?cWdMVTl6MkhkV04vVmR4Tm9hOFZGUiticzQ2ckFpZ0tTM01PNUtESm1PMlUr?=
 =?utf-8?B?Q01Cem53c3RjTjJpcmJhNFdNUSthalhhbjVpdkRGOVBFV01TTGY5azRXM0pV?=
 =?utf-8?B?V3N6dWVkbEtQRVhOZ0tMYkUreGlzZ0V5dVR3azdKUnhQOHUyOXdhTThDMWNZ?=
 =?utf-8?B?TDNKb0kzMkdkU3pGdGY4dmZUQllLZ2podXV6WWZJYThzZ25xOHd5Tm5PSEtN?=
 =?utf-8?B?SzhGMy83eVNmNStNNmtpTzhmNzZjdFMyM2ZVc2Q3NWlrZFlWS3dEbmV6eGFF?=
 =?utf-8?B?bG1raUJ0cVYwNnpjbVJpMkI3cUgzRzdMdksrZGVTSUpxckhoQWpzRTdtU1ht?=
 =?utf-8?B?Z0c2L24rcG1wbTBYTVZWMVQ0M1pENjRSRmk5bTJaUVIxenV4WnBmNjZpbUFx?=
 =?utf-8?B?blJXN0hMdnNVb080MTA4L2hPRDBsWllVRUtEeER6L0h5YmdxMkdPR0hNNXlJ?=
 =?utf-8?B?RVZZWERzbzdwMVF2VE56V05aRExpWEtNZDRwRGU5OWZEa0gvSEVXemozeWhS?=
 =?utf-8?B?Sjc3S0ZqVjNEem1BcU5sZVVtay90SE5rQnBiMGNnUm5XdUJvaU1XWnZWNlgy?=
 =?utf-8?B?UW1DcEVydTdyM0tpZHpvbnhSVksyaUNnVlc1U0tETnJJcWZQZWpNN2RybU4y?=
 =?utf-8?B?UHVjYWR2SElFUk1aTXh5ODE2L1c2emNJVjhZdnREakEvblJPdFdsQzFMeHdQ?=
 =?utf-8?B?NXZFSjR5aXQ5TTdtSEtqYlNERHZFOVJZZVdHTk4wTGgxNXZMaUNmc1hvTjdt?=
 =?utf-8?B?OW9zazNxa1pEZWlsYVVhdWdxM1hSNmgrd0RZYmx6bU9YaUo4NFkyVkRuMGt4?=
 =?utf-8?B?TmVmZ2E0ejNEMFJRTXF2czJuNWVqQ05wNlhqQTNOeFpCMVFuZ1JzVXNJZ2hs?=
 =?utf-8?B?aGp1bWdqZ2kwSlZaNjAvNzdEL3BRSGlPRHM1S2Fsb3ZSVkNvRzJnYVVyNEor?=
 =?utf-8?B?ZUxNcU9KeDhHVUVoQzJpQ25KK2hlVStBZWQ4djJCQXVzRkJPcXd6R2xmSHVL?=
 =?utf-8?B?dXdLRFg3aFZ1Z0dUenF1dW5pRmVXc3pZMzkrZU5vb21HR1drc01rUzNBOFJl?=
 =?utf-8?B?MDNaeStheVZjcE1GTnRxQ2pTQlNGUzFnNTdwdy9qNzNPMXpIRGczL1graXhk?=
 =?utf-8?B?aCtua0FsVlJ6enN2UURnYmVNSVJYVkdxUWd5R2VFWGIrN2FocFU4dzlBUndF?=
 =?utf-8?B?UEZtbVI1ckdyd3FtdUs1RWcyNHhHUnRtL1NxTkZIdlBiRFF1M0lhZmhHR05H?=
 =?utf-8?Q?ESA/MpiOCkjAGsWDJvTyAc9JX?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 048c13e2-86a1-44f4-9404-08da80bd7c64
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Aug 2022 02:00:55.3156
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DiPHxSVuPC9oeS+fD+fQPKcqyawA7CH0vO67Viz9o3ZtC40NlGJYKs3y1r2BS4f33QxjIEPlMoAzleqg0K7PRQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR11MB5761
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 8/18/2022 9:55 AM, Miaohe Lin wrote:
>>>> 	/*
>>>> 	 * The memory barrier inside __SetPageUptodate makes sure that
>>>> 	 * preceding stores to the page contents become visible before
>>>> 	 * the set_pte_at() write.
>>>> 	 */
>>>> 	__SetPageUptodate(page);
>>> IIUC, the case here we should make sure others (CPUs) can see new page’s
>>> contents after they have saw PG_uptodate is set. I think commit 0ed361dec369
>>> can tell us more details.
>>>
>>> I also looked at commit 52f37629fd3c to see why we need a barrier before
>>> set_pte_at(), but I didn’t find any info to explain why. I guess we want
>>> to make sure the order between the page’s contents and subsequent memory
>>> accesses using the corresponding virtual address, do you agree with this?
>> This is my understanding also. Thanks.
> That's also my understanding. Thanks both.
I have an unclear thing (not related with this patch directly): Who is response
for the read barrier in the read side in this case?

For SetPageUptodate, there are paring write/read memory barrier.


Regards
Yin, Fengwei