Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp5497941rwb; Wed, 17 Aug 2022 19:45:09 -0700 (PDT) X-Google-Smtp-Source: AA6agR7UchX46qu3g4WV3NyGu7n8KSj1gWTda8HvWDAyaRm4Q4HRpwp/Qc71Yl3CPd6Uq94xIWTM X-Received: by 2002:a05:6402:84e:b0:440:4bac:be5a with SMTP id b14-20020a056402084e00b004404bacbe5amr646377edz.103.1660790709763; Wed, 17 Aug 2022 19:45:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660790709; cv=none; d=google.com; s=arc-20160816; b=gayGNI+4+Zxk4LhUFNFdMHyup70xywe9ZemGRTEolcYDpHaZtL5ldEcIaIJDxmGSk+ QZup3QwIqA8TWucEEJq3As13QttZSOOjbdSpkCNq3iSFSCHw8vn/8MYMRNsNmENZBl3I lQDzRaZRjvSWS4c6IvE8gyR2XlbPuzcghNuriByqapEJul2sKZVAmWOtV0Dk83Pq8amA T43d2PBUpwrm0nSPFnd6a00l+P1KZ8gXU5YA9Wok01vQP6K6AjSILQ6qsoCFyV3a/oKa TdeHPUlKQfnLqm4NYOrUxf5tqdhm9GczAeqyj+af13TR7XDa0yLBIRbQASD37nID66M5 8Z1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=k0/cuCGh7x6ittS6P09M06X2Z07BAEGisSGdQayXR6Q=; b=WgbjrZw7Up1yvjF1bATxrhSaG38J5sd1RvqLoIWhx5qEh+DCoeiRIvBF17KoYUWw2N 8aaAYoo8+kvEQ0iE78FGhXpCiPZPCO8ACQFXFJRZsrUAk6M9xz/9Y8cL7iCYh6O8Dhp7 fprhZN1ihGdlkKrHVG6U5oN6Zt6NGXF/JTz9OSDV4VS+yq8lHlbHHrs+snF95vDkyHxb 0yokUEFHfEf3FLTEp4mDWQApRN4Sk8xcKL5KpAp2yxJtDIAdCb2HDsMH20pcOk+pZ+Wy LqdTjZlK3XgLr1ng0bHtxp4mCnfrfLMtO7YCsyo0JGoThml+/25JaoxxIz2VrNbCdNIc Ku4w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=PIxCpluW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e17-20020a056402191100b0043a72c8b750si365662edz.114.2022.08.17.19.44.21; Wed, 17 Aug 2022 19:45:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=PIxCpluW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242721AbiHRCTW (ORCPT + 99 others); Wed, 17 Aug 2022 22:19:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47724 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240595AbiHRCTT (ORCPT ); Wed, 17 Aug 2022 22:19:19 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA97C6E8B6; Wed, 17 Aug 2022 19:19:18 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 30FEF61448; Thu, 18 Aug 2022 02:19:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 47B61C433D7; Thu, 18 Aug 2022 02:19:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660789157; bh=lDCYO3+leCT8O9ybDEmYfB2gO6BNT27vpk8WTvXTE68=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=PIxCpluW56J3ci43B5Idxcpnog4TH/Wh+qfzV8KSTfxi9NfY8ZHuCCXzv50aEfwZK WmzrO9yJu9dHH95s44SV7gEAYJkYrAd2I7OPJ2VXUNTJUSo1f+bm24JTgiVb8fukmt /Nyik1tynZP5hFdi6EEyVXlJ+Wh1Wv8FBSoUCsQI7WyhWSICA/4Hzz3GBwN9V1dz+d iFCaCfl9G8+tV6k6fDkTzJ9hyq+tgZ+PULuMKU6SVjt+8901k0846yat2MabYwwtbT IbOGUrp2+/nMkIvVM8gEbvHAwSq4F4r767ewWs9l/JY7y6mkSdMjqK52XIP1/TzvgA uQkSwuENpWBWA== Date: Wed, 17 Aug 2022 19:19:16 -0700 From: Jakub Kicinski To: Andrew Lunn Cc: "Russell King (Oracle)" , Beniamin Sandu , hkallweit1@gmail.com, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org Subject: Re: [PATCH] net: sfp: use simplified HWMON_CHANNEL_INFO macro Message-ID: <20220817191916.6043f04d@kernel.org> In-Reply-To: References: <20220813204658.848372-1-beniaminsandu@gmail.com> <20220817085429.4f7e4aac@kernel.org> <20220817101916.10dec387@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 18 Aug 2022 03:21:53 +0200 Andrew Lunn wrote: > > > I had a quick look and couldn't see anything obviously wrong, but then > > > I'm no expert with the hwmon code. > > > > That makes two of us, good enough! :) Thanks for taking a look. > > It would of been nice to Cc: the HWMON maintainer. His input would of > been just as valuable as a PHY Maintainer. Fair point, I lazy'd out and only checked that everyone get_maintainers asks for was CCed. Perhaps it'd be worth extending the hwmon's keyword match to trigger on the structs or the constants if it matters. Adding hwmon@ to CC just in case.