Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp5498734rwb; Wed, 17 Aug 2022 19:46:35 -0700 (PDT) X-Google-Smtp-Source: AA6agR5SkUqxSQgFUCn5IQu+VcrGsgFx8qgOQruiwtAesSO5GYbDNLX5g1jQZvUmFMc72GW8X8ms X-Received: by 2002:a05:6402:50cb:b0:440:87d4:3ad2 with SMTP id h11-20020a05640250cb00b0044087d43ad2mr629738edb.219.1660790795354; Wed, 17 Aug 2022 19:46:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660790795; cv=none; d=google.com; s=arc-20160816; b=rzF/vGykF8ahCvuX/Dj5Y4zDdS99zzN5pAQ/CoISBU/sWtPnnlkxHWpxMV3QLjsMgU CoPytTOxjWhfib8Wrb+wy8MbZ9GphNhZSzEIlu4tjeHwX3C/kPoZnDH6zKK3hX5CZKuf cPAkOJEhzkktoWtRvjJrX26fW9Hkb/Knvhn4wUUEQl19zuOmyzz0e+oZa6Dl7QwnBhex l2Oas8B2V/RKvCxl8bEVUo4HlUZupQPrE3n+7KJwcX3nzqS03S8bh4fapQ5osTf30oxj 1GyVbb1Djj5sG2CtMc18e3t1TOkDjdyz88hNI5u1ztydsqczFoxqZ01qWkRvCuHTR1r1 n/qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:references:cc:to:from:date:subject :message-id; bh=V13w2NCY80dUU6qIIgS6NnEd3OEqW7nSjnL5OU0UI1A=; b=cWjs5v5nRdNQ8x8ik219Mkk1J58rZUiMQ43V0L13qoLEPl/1qGk0DW52Vupij1lbuT njZoTRS8RYEXCVWnlkzwUIjSaOxqP8lE4nfcYtIjm3BGIemgzrQixiABWXubVEixJE76 nnxaVqNtv3713aLBRwMYGzBvg8mSB/4Xn+dYTDoV1mgRHCsWDTWJCLGif6XEfiwBBfHM QIQkrB3ftnj3wW/MuL+1se6jfZ7CQ+c1g5Qz5mcZMwoFtAq2WkwrVXV7kskld2odGMJP IxRletXBFzMgh41GSKzeIehBnskoHTWcll5+UCbIYN5VroP3oEViZHDOWFHIorkfz56Q snvA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id nb37-20020a1709071ca500b007330a081f1fsi190141ejc.679.2022.08.17.19.46.10; Wed, 17 Aug 2022 19:46:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242606AbiHRB5q (ORCPT + 99 others); Wed, 17 Aug 2022 21:57:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36956 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241809AbiHRB5o (ORCPT ); Wed, 17 Aug 2022 21:57:44 -0400 Received: from out199-7.us.a.mail.aliyun.com (out199-7.us.a.mail.aliyun.com [47.90.199.7]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C4F82A4B3C; Wed, 17 Aug 2022 18:57:42 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R141e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046056;MF=xuanzhuo@linux.alibaba.com;NM=1;PH=DS;RN=19;SR=0;TI=SMTPD_---0VMYQwYj_1660787855; Received: from localhost(mailfrom:xuanzhuo@linux.alibaba.com fp:SMTPD_---0VMYQwYj_1660787855) by smtp.aliyun-inc.com; Thu, 18 Aug 2022 09:57:36 +0800 Message-ID: <1660787737.7869372-1-xuanzhuo@linux.alibaba.com> Subject: Re: upstream kernel crashes Date: Thu, 18 Aug 2022 09:55:37 +0800 From: Xuan Zhuo To: Linus Torvalds Cc: Dmitry Vyukov , James.Bottomley@hansenpartnership.com, andres@anarazel.de, axboe@kernel.dk, c@redhat.com, davem@davemloft.net, edumazet@google.com, gregkh@linuxfoundation.org, jasowang@redhat.com, kuba@kernel.org, linux-kernel@vger.kernel.org, linux@roeck-us.net, martin.petersen@oracle.com, netdev@vger.kernel.org, pabeni@redhat.com, virtualization@lists.linux-foundation.org, kasan-dev@googlegroups.com, mst@redhat.com References: <20220815113729-mutt-send-email-mst@kernel.org> <20220815164503.jsoezxcm6q4u2b6j@awork3.anarazel.de> <20220815124748-mutt-send-email-mst@kernel.org> <20220815174617.z4chnftzcbv6frqr@awork3.anarazel.de> <20220815161423-mutt-send-email-mst@kernel.org> <20220815205330.m54g7vcs77r6owd6@awork3.anarazel.de> <20220815170444-mutt-send-email-mst@kernel.org> <20220817061359.200970-1-dvyukov@google.com> <1660718191.3631961-1-xuanzhuo@linux.alibaba.com> In-Reply-To: X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 17 Aug 2022 08:58:20 -0700, Linus Torvalds wrote: > On Tue, Aug 16, 2022 at 11:47 PM Xuan Zhuo wrote: > > > > + BUG_ON(num != virtqueue_get_vring_size(vq)); > > + > > Please, no more BUG_ON. > > Add a WARN_ON_ONCE() and return an error. OK, I will post v2 with WARN_ON_ONCE(). Thanks. > > Linus