Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp5546613rwb; Wed, 17 Aug 2022 21:03:01 -0700 (PDT) X-Google-Smtp-Source: AA6agR57QabdpN+Kttlng9oDklfyLQbo5yKMEcYhFo0ZMmWfwIXrcOAFqo2YYxkOyvIFUKCzVCJA X-Received: by 2002:a17:902:ce82:b0:16f:9697:1d94 with SMTP id f2-20020a170902ce8200b0016f96971d94mr1032555plg.12.1660795381457; Wed, 17 Aug 2022 21:03:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660795381; cv=none; d=google.com; s=arc-20160816; b=NZOCaUBWMtNTi6qrCH/nMIG+S1s6K5FcwF6i/ynk8btb60nrBduBCAvvSXbUV0ttD8 ILGJXxUGF/fB/Ed2uE9OK7QK/qSuC9sMPGxsgBZKEFjYNvqe88AG1uQgvty2mRMy+51+ t9gBE+IQnEadjV78vGOKu/jDVzLyqiUxoeXJADR5fXA7L7kdjlucwUHFGUFPQUd/8gDs QZ4zjuX4SuhnUBLWjoUvgR2Qbz9DwyfiXQD4m6Pha0i5/mVM4Ho7aCt7jZpJIieTJw1r t2jLVSICiAYZwp6iL4SWu6fWDdAB3Kpw+Mxpidum1VXKq09PFhYYMg5V/BI0OIY4dBy6 61SA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=z/kt4xsiqT5uh1tSKfd39tJzduEkjiNNtsPz4ODYScQ=; b=M8KCoppe7xXUBe+qt6h+MVfF81msOSWc2Ovo5rAPshkYyjGClcSPRcNmvhcQYCr+MB BfQAU0LTgLWfUXPUPBtah80pI8XvSxUf9zR65f4jTCnt886eiN/RgSM6UknkL/9lTwVl NtTM8A1vGdIJbElESWpKzI5w8mbaAZbImTRd1gDQRnTPZ1hSuPPVro2icUa1HgTyKF9I NkmHBpP5XlqXVWJF8vZp/wxtaN47/K8Tj6Y3PHCx3GD4+84GBbeiA+e4KVK65FjDmgyj +1SDoOMCUEA1ajR1nrNChz0Zasr1rjgwPxM3lidOfpuj16v9H9BXuni8dQ0bOIeIIHyM Im5Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kali.org header.s=google header.b=hUsX8rTl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kali.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bf2-20020a170902b90200b001726ea1b6fesi324511plb.433.2022.08.17.21.02.49; Wed, 17 Aug 2022 21:03:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kali.org header.s=google header.b=hUsX8rTl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kali.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242691AbiHRDvP (ORCPT + 99 others); Wed, 17 Aug 2022 23:51:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240247AbiHRDvN (ORCPT ); Wed, 17 Aug 2022 23:51:13 -0400 Received: from mail-oi1-x236.google.com (mail-oi1-x236.google.com [IPv6:2607:f8b0:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1936D60FF for ; Wed, 17 Aug 2022 20:51:12 -0700 (PDT) Received: by mail-oi1-x236.google.com with SMTP id p128so368990oif.9 for ; Wed, 17 Aug 2022 20:51:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kali.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc; bh=z/kt4xsiqT5uh1tSKfd39tJzduEkjiNNtsPz4ODYScQ=; b=hUsX8rTlrvTeQvHroIs2XSAw7rftVr3j4T1DMDpJAOhE75zyhypDjS8nZn2dJ1PAtV PyyiE9zWnK4AdZgnzKyYo5SaIU4lzFOnMQhymG4K/BunYWpJmPqfh2ayCKiRVtyMXUSa qWJ/8Kn31W0eviW63LQ0bNlJd7r6XSayEsgXrpJrTkzbtn676A0CSZlXget+ct41QgUJ 6pnc/4akLOnoonrqqS59n0HN3I+svs8h75IiIISyBFN+rKSSBroei3IQKCB+ACuprsL1 ysf9YPNasyRTNxgNyKrZrBFrU7rRsKPFfAWfn2JKWrr+VV6hdcFI5VeL8KpweMamYNQs J9Bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc; bh=z/kt4xsiqT5uh1tSKfd39tJzduEkjiNNtsPz4ODYScQ=; b=Ihnlp6tXHfR0DimR60OumVpiaDVoBefXLur0U5vkJFzbSxEq4mY3blsh9j92FNkg32 8z/Stu1yGvagFEzWq3QZkEKOzRbxBiswEf+jNRzrX58wp2aayU2Hi7qZIUVLrtR6N82D qz1AaXLZJBM3r+Jv7FzNfG74ANvP8v1qQdZ3xW3csuiEjha9DSAippCSoHXeRb7WyXnD InkuJ2RvlmdGI9Z24p6bwt8ziS/HxwyDMYANUuJ6rHWVT8sRCemu0i4BHBQovuOgKBEH zgHsXmt+8eSwNtLyVHMTvf1A6h0+2gQEFLP3YBtYu1wQ+syDuESP1eGRrLFwYFaDrRGP Wmdw== X-Gm-Message-State: ACgBeo0VqU1zl+C3FM+iFpFZ0DJUxTxzhTj+g14ItQulZUVP8AyPpWGa 3z8JGhUG7dnmHk6LbEuJX3af0A== X-Received: by 2002:a05:6808:200f:b0:343:470a:cd22 with SMTP id q15-20020a056808200f00b00343470acd22mr2776801oiw.52.1660794671410; Wed, 17 Aug 2022 20:51:11 -0700 (PDT) Received: from localhost (cpe-173-173-107-246.satx.res.rr.com. [173.173.107.246]) by smtp.gmail.com with ESMTPSA id b6-20020a9d5d06000000b0063695ad0cbesm142984oti.66.2022.08.17.20.51.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 20:51:10 -0700 (PDT) From: Steev Klimaszewski To: Steev Klimaszewski Cc: Amit Pundir , Andy Gross , Bjorn Andersson , Konrad Dybcio , Vinod Koul , Bard Liao , Pierre-Louis Bossart , Sanyog Kale , Philipp Zabel , Srinivasa Rao Mandadapu , linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: [PATCH] soundwire: qcom: remove unneeded check Date: Wed, 17 Aug 2022 22:51:05 -0500 Message-Id: <20220818035105.5510-1-steev@kali.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org commit 1fd0d85affe4d6 ("soundwire: qcom: Add flag for software clock gating check") added a flag for software clock gating check, however in commit 33ba01788889666 ("soundwire: qcom: Add support for controlling audio CGCR from HLOS") the same check was added without the flag, so we would still end up failing the software clock gating check. Originally reported by Amit Pundir on DB845c, I also saw it on the Lenovo Yoga C630, right before the splat, we would see qcom-soundwire wcd934x-soundwire.6.auto: Failed to get audio_cgcr reset required for soundwire-v1.6.0 however, SDM845 has a soundwire-v1.3.0 Since the flag was added in 1fd0d85affe, lets just remove this one. Fixes: 33ba01788889 ("soundwire: qcom: Add support for controlling audio CGCR from HLOS") Signed-off-by: Steev Klimaszewski Reported-by: Amit Pundir --- drivers/soundwire/qcom.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c index 709a7c1e0704..b621f7fb866f 100644 --- a/drivers/soundwire/qcom.c +++ b/drivers/soundwire/qcom.c @@ -1355,10 +1355,6 @@ static int qcom_swrm_probe(struct platform_device *pdev) ctrl->bus.compute_params = &qcom_swrm_compute_params; ctrl->bus.clk_stop_timeout = 300; - ctrl->audio_cgcr = devm_reset_control_get_exclusive(dev, "swr_audio_cgcr"); - if (IS_ERR(ctrl->audio_cgcr)) - dev_err(dev, "Failed to get audio_cgcr reset required for soundwire-v1.6.0\n"); - ret = qcom_swrm_get_port_config(ctrl); if (ret) goto err_clk; -- 2.35.1