Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp12082rwb; Wed, 17 Aug 2022 21:32:53 -0700 (PDT) X-Google-Smtp-Source: AA6agR7Cf3iwmQM1IyskLWAKGpaJy2+d8DA1DHNN2LZ0Xm3ByzpXDquKUXYMYLsKoZa1i/DmnCY0 X-Received: by 2002:a65:5789:0:b0:41a:4a7c:635d with SMTP id b9-20020a655789000000b0041a4a7c635dmr1137011pgr.60.1660797173681; Wed, 17 Aug 2022 21:32:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660797173; cv=none; d=google.com; s=arc-20160816; b=OuBThB+J42864GCwdNjptSM2Kvr2p5JAV1cTXKZuRB+1zD5svXqrqRLNRnZkDh56Fe JMpDhhFCB9objdIjzpzf1Er54/udVAwZAQCmDHbTvxxgdUCbkQXm4KLZDnhzfuUtzGoX jGvC1qIjrMwENPzuYDPlmlp9ZZnd0bgJhURvC8Kj+4Hfs1NAXpMbk/dLCjnziMGFvkzT uQx43YwtsW72LR9+8JJfw/Pcg8O/YyyQVG7r5Ymb6ibDMjzeao6I9EZWHC20QHIM41EP MaJ1rGJzixlx/MzmBoZwCi3X/vZO+Zo2/kyj8OXB8jY8swNzx3CNK6pQe46b7H5ZqEne obBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=4QLtzhQo4fGwHvWa7njREcsj3AiC5duKX2SzuYekf4I=; b=NTl76Gza7NCVVRtIqm0lGnmyNwcNbsAkl5pQFLk/5rFV1zuCdAfTxF7mWzP7o2iQy8 wDing1W8mpNLgIjEoZKytsiu7yARc1qPjlK663ke5fiVisZKbDMqaNd04Dy+UuQ+fOJL uWfClsZzvY50q3omth8xWZCs3yyjoQLJ9tZD5+cmosxEb0Jm2fIlta0VYf00fmxGCYzR CpkxSRbMLYJa3Z2zWsezC78D26OeSXIgSRo6HYZhBpK/TNQAuo8LDmIyfqR3imKnF9Ty LgQDQuQ53nqO0msCvP3LtcRRkGzZG64pTTWOHRvS47EmKOU4XR/NfSpe/0BB3BcJjlLg bslg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=Z5VxiiKy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v184-20020a6389c1000000b0042a08b6ae1fsi200915pgd.4.2022.08.17.21.32.42; Wed, 17 Aug 2022 21:32:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=Z5VxiiKy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242975AbiHRERP (ORCPT + 99 others); Thu, 18 Aug 2022 00:17:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46080 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242843AbiHRERJ (ORCPT ); Thu, 18 Aug 2022 00:17:09 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3645083BFF; Wed, 17 Aug 2022 21:17:08 -0700 (PDT) Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 27I2QZv0003653; Thu, 18 Aug 2022 04:17:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=qcppdkim1; bh=4QLtzhQo4fGwHvWa7njREcsj3AiC5duKX2SzuYekf4I=; b=Z5VxiiKyTur7TKzE48teb7+B27Jh9O+4ZARucEdx7YdokfSdDyqPxUIancPS9xNxFNz2 AUZgGBP69gHRCPExAtVLZeIjJ9QqjNj1fGISTLD87vcK1A7WxWFuvZabxxwpm0O+hP7b 6ztZWYcQ+qF8sp0IGOraT5offFWO5Kc/eRohfFq51MhP/MfrpRNA81zgY/w85bJiLTcR xSVHoh8e9z5tqpQgqGVMflDTeGaS5G2+7b6o48Szwsx6KKJqGtPmYNfOd2oF0EwE/27g RSaNcgrpKJ51OmRuONx6BPeMU8Ptp6Okbga2VETQoFFiMHQDvDGY82ffv6itleIk5Iba pQ== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3j13v1j9ry-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 18 Aug 2022 04:17:03 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 27I4H2OZ017942 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 18 Aug 2022 04:17:02 GMT Received: from nalasex01b.na.qualcomm.com (10.47.209.197) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Wed, 17 Aug 2022 19:24:16 -0700 Received: from hu-wcheng-lv.qualcomm.com (10.49.16.6) by nalasex01b.na.qualcomm.com (10.47.209.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Wed, 17 Aug 2022 11:24:12 -0700 From: Wesley Cheng To: , , CC: , , , Wesley Cheng Subject: [PATCH v4 7/9] usb: dwc3: Increase DWC3 controller halt timeout Date: Wed, 17 Aug 2022 11:23:57 -0700 Message-ID: <20220817182359.13550-8-quic_wcheng@quicinc.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220817182359.13550-1-quic_wcheng@quicinc.com> References: <20220817182359.13550-1-quic_wcheng@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.49.16.6] X-ClientProxiedBy: nalasex01c.na.qualcomm.com (10.47.97.35) To nalasex01b.na.qualcomm.com (10.47.209.197) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: ypgn_AOO93hiq0pjYNQjVU2Snrg8k-C- X-Proofpoint-ORIG-GUID: ypgn_AOO93hiq0pjYNQjVU2Snrg8k-C- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-08-18_02,2022-08-16_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 impostorscore=0 mlxscore=0 clxscore=1015 malwarescore=0 mlxlogscore=592 bulkscore=0 phishscore=0 suspectscore=0 lowpriorityscore=0 priorityscore=1501 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000 definitions=main-2208180014 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since EP0 transactions need to be completed before the controller halt sequence is finished, this may take some time depending on the host and the enabled functions. Increase the controller halt timeout, so that we give the controller sufficient time to handle EP0 transfers. Signed-off-by: Wesley Cheng --- drivers/usb/dwc3/gadget.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index 57d83b3b4967..5f250df7066f 100644 --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -2444,7 +2444,7 @@ static void __dwc3_gadget_set_speed(struct dwc3 *dwc) static int dwc3_gadget_run_stop(struct dwc3 *dwc, int is_on, int suspend) { u32 reg; - u32 timeout = 500; + u32 timeout = 2000; if (pm_runtime_suspended(dwc->dev)) return 0; @@ -2477,6 +2477,7 @@ static int dwc3_gadget_run_stop(struct dwc3 *dwc, int is_on, int suspend) dwc3_gadget_dctl_write_safe(dwc, reg); do { + usleep_range(1000, 2000); reg = dwc3_readl(dwc->regs, DWC3_DSTS); reg &= DWC3_DSTS_DEVCTRLHLT; } while (--timeout && !(!is_on ^ !reg));