Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp35935rwb; Wed, 17 Aug 2022 22:11:00 -0700 (PDT) X-Google-Smtp-Source: AA6agR4w2LTmzD421oXxwjto/EsyupxEYj7+lgpg+Dp2UnlSn0XAKzFUVe3Jl7Ham2qgBztmo9xL X-Received: by 2002:a63:1d1d:0:b0:41c:3d54:b123 with SMTP id d29-20020a631d1d000000b0041c3d54b123mr1224148pgd.357.1660799459796; Wed, 17 Aug 2022 22:10:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660799459; cv=none; d=google.com; s=arc-20160816; b=ZGAKSkPeypJFyFJqDmyjclPmMZQL8cnJLd4BkGBLlA02JIdmL5CoigbKCKyrhaSHOz i5LyPYftNoUyPCNjvNNK+t9Klv74hAQ6phrEF/g6ztJfBlmjDWzkbO1CV/ZS4FEY/VoR 2EBn5FinLYypoSLK5XcRcZye75W7IH4lfP5xulsPEArMEXQtija5rbR6JFNg1rea5z4B fjc0TmZfhFF2FffA6kEbQ6PL8mrDdE/UsWGnSnW36GK/LlU/0o8P4pyhNLxY6iehXHDf bNy8oUj9+lC/ocQqZxfRq3niB+eacf8PGFrWDXm3PDZtVzcPJPmP0VEFVa3ABfzsTdbS +L8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=Nx33hXN1LossIpCnrHswpELkvsLkDlmpBkfWihCZXuM=; b=AGJtLBL50QE4m2bMtf9Gd/qyHmVLTpFAF8cTIO3oZdVmir3Nz0hvjIEbHZMcRa16wu oRtdBoiGkhZeU/DO68BOqvIQgd/YeqQj27wnUsk/ONKKf3LLOsl+lWdIRfgReTYmhu0R YVj1AfvhdhCdlhxlvrbOm9Wd1buNOPqwgk2ga5BmtMoHszi19M4kj8XOPOriHvSeVfG1 bUQpJmX/tcpAJylOgKCaT+mTVwj5uSHJbIZPjHcyH32Hp4JKWS47uQaNmDty7vDmC/aX SZBVQbbAWzWFs4asTojdKiP4yx4B0NeOu55BTegh9iH6HsWT780vydegOnbGX2LHAO3f 0NRQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=XuuHdZT5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f1-20020a17090274c100b0016f1eb1317esi427281plt.471.2022.08.17.22.10.48; Wed, 17 Aug 2022 22:10:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=XuuHdZT5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243404AbiHREfy (ORCPT + 99 others); Thu, 18 Aug 2022 00:35:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60262 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243396AbiHREfw (ORCPT ); Thu, 18 Aug 2022 00:35:52 -0400 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8678876A9; Wed, 17 Aug 2022 21:35:51 -0700 (PDT) Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 27I2uCSf002920; Thu, 18 Aug 2022 04:35:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=qcppdkim1; bh=Nx33hXN1LossIpCnrHswpELkvsLkDlmpBkfWihCZXuM=; b=XuuHdZT5jzjAJy+J82S5qrGXzUvjfJtlFCtnYoMaLNF2Xrafu7HAyDCQ8VLmzW+rM9AP hb3oj6Q0gOWVU0A/jJD02SUiXQ/9lirvrMneccD/eFWrT45qfpWGFRjc1GE1vG3gJSFt rSHMfK8hcWgqCotGlmeezHK2gdHVbPpf9eIbOHKsBVUI0+SZxduBSyYErG1KfTiXWEu0 DfIO83WLFeR2X1ZPdHHLvoZ04Wx7LNjLEXlxPuK7q98SLJh9GgRcy7POq4tSQ2WwgiTA H+CGINlQgEwS5bWvV3Zr+f4uIIFijqAU7DVv/h7d+GfcSJGTLBvDkg4qblDmxYSnpBEF 5g== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3j0tqccqjx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 18 Aug 2022 04:35:46 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 27I4HLAp018273 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 18 Aug 2022 04:17:21 GMT Received: from hyd-lnxbld559.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Wed, 17 Aug 2022 08:14:35 -0700 From: Akhil P Oommen To: freedreno , , , Rob Clark , Bjorn Andersson , "Dmitry Baryshkov" CC: Matthias Kaehlcke , Jonathan Marek , Jordan Crouse , Douglas Anderson , Akhil P Oommen , "Abhinav Kumar" , Daniel Vetter , "David Airlie" , Sean Paul , Subject: [PATCH v4 1/7] drm/msm: Remove unnecessary pm_runtime_get/put Date: Wed, 17 Aug 2022 20:44:14 +0530 Message-ID: <20220817204224.v4.1.Icf1e8f0c9b3e7e9933c3b48c70477d0582f3243f@changeid> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1660749261-7602-1-git-send-email-quic_akhilpo@quicinc.com> References: <1660749261-7602-1-git-send-email-quic_akhilpo@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: CBzs21x4baufWN-YVre6pDlhsCs9RAZY X-Proofpoint-ORIG-GUID: CBzs21x4baufWN-YVre6pDlhsCs9RAZY X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-08-18_02,2022-08-16_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 malwarescore=0 bulkscore=0 priorityscore=1501 impostorscore=0 phishscore=0 lowpriorityscore=0 adultscore=0 mlxlogscore=999 suspectscore=0 clxscore=1015 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000 definitions=main-2208180014 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We already enable gpu power from msm_gpu_submit(), so avoid a duplicate pm_runtime_get/put from msm_job_run(). Signed-off-by: Akhil P Oommen --- (no changes since v1) drivers/gpu/drm/msm/msm_ringbuffer.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_ringbuffer.c b/drivers/gpu/drm/msm/msm_ringbuffer.c index 56eecb4..cad4c35 100644 --- a/drivers/gpu/drm/msm/msm_ringbuffer.c +++ b/drivers/gpu/drm/msm/msm_ringbuffer.c @@ -29,8 +29,6 @@ static struct dma_fence *msm_job_run(struct drm_sched_job *job) msm_gem_unlock(obj); } - pm_runtime_get_sync(&gpu->pdev->dev); - /* TODO move submit path over to using a per-ring lock.. */ mutex_lock(&gpu->lock); @@ -38,8 +36,6 @@ static struct dma_fence *msm_job_run(struct drm_sched_job *job) mutex_unlock(&gpu->lock); - pm_runtime_put(&gpu->pdev->dev); - return dma_fence_get(submit->hw_fence); } -- 2.7.4