Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3bb043a4-987d-5896-29e1-21bb471da0e3@amd.com>
Date:   Thu, 18 Aug 2022 10:29:45 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v3] AMD_SFH: Add a DMI quirk entry for Chromebooks
Content-Language: en-US
To:     Akihiko Odaki <akihiko.odaki@gmail.com>
Cc:     Basavaraj Natikar <basavaraj.natikar@amd.com>,
        Jiri Kosina <jikos@kernel.org>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
        Mario Limonciello <mario.limonciello@amd.com>
References: <20220816102120.6131-1-akihiko.odaki@gmail.com>
From:   Basavaraj Natikar <bnatikar@amd.com>
In-Reply-To: <20220816102120.6131-1-akihiko.odaki@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M2VzOUozSjdBaFBobHc1UW9NVno1WVdlVTdteWgzaGVZUElaOEtJTmhVOWli?=
 =?utf-8?B?d2kzejlja2Q5M0RnUEhWZWIyOFRWdkJxL2R1eHJYaHRQS0lUeFFoc0MyUDlF?=
 =?utf-8?B?c2srQmMwYTFSa0l3TDFXVGFpY3VvRGtiNEV0TUZ2TUtzTWgwQ0lQTFRibTJ4?=
 =?utf-8?B?K3FoK1VJR0lyU3NjZkZkVGxsQlB5Uk1lOFJIYmQ1NytkclJkVHJXMTE3eWcw?=
 =?utf-8?B?R3lxbkNFRDQ5THlTTTJ5WWE2N3JVSXhlUmc2QUNQUnJkOUUvQVBOTy96c3N2?=
 =?utf-8?B?b3VsdnJKTUg4K1o1NGd0RTVyRFF1WVpJMUg2elVtQ3BFeEtTaGk0M1BhcjFw?=
 =?utf-8?B?L1FRYlhIdlliS2Y5MzhNTTcyNHI3bjNhQ3ZaaUVDdzRac084Nmg4U0JrRktO?=
 =?utf-8?B?aTNocmgrSFVkajBFdHVjWlM0MjBNRUpGeGRPUTV0VU80T1RiMFVBSU5MbWpl?=
 =?utf-8?B?RGI5Nk9IV1F1M2p1K2tZQVFka2ZQSDRmLzFDaGl6SU15Q05tdFNIR3NxbUpw?=
 =?utf-8?B?RDF4TFIrZERhUUJCMllxNWtXUWNodWp3YUlRWVRFVGpwd0dMamxGVzA3b201?=
 =?utf-8?B?OGRzUlJrRjVTZU41TzlDaVllRkl4Nmk5NmFCaE83bitvUzNJR2p2V25VbXQr?=
 =?utf-8?B?Ui9GdGRVRFBBNzF1ODRzVjVpZHZFV3lmYzVRMVVKeHdVSUNaZnJ4L0UvSGVD?=
 =?utf-8?B?b3REd0cvWXM2enhka2RzdklOcUlnWWg4dE5Mb2Z0SGNORzBock91eVR0S3RT?=
 =?utf-8?B?SVNIRDhPdFh6SUtaUnJXdW5uMDRLMU53ZUdjRlQ2M0gxMFpEcVF6RzhLNmNC?=
 =?utf-8?B?Z1BRTEpudmsrRVIvUmtRZ2ZxWUVySngrSWxEWHNMSUpiUlYvWGUrZXpySmoy?=
 =?utf-8?B?UUJDYlV2dHdickRJTS9kUHpGSlplbExBSnMwNjk5d3Y0a3JpcDlMT25FN242?=
 =?utf-8?B?MGlqcUp0NlZzZ2NZVmM1QlhvbzNwUDgveHhhM2Q2LzJyb2p1bGFpcHFqZHFE?=
 =?utf-8?B?SnRvNWJqcFA2VzlhOHRwSktFazhkWFJtTEZ0SGNGaGMwSys1azU0cE1QQXVW?=
 =?utf-8?B?OWdneHgxbTdEbVIrODJSRC92MHpDaDl0SGIxUU02VGxLOTJZTStKUGZFTEtH?=
 =?utf-8?B?VTdoRHRNaHBaYldNR2NQWS9iK0pjRjc4RGFBbnpWRTBTZWhaRUtIRWVlZlMx?=
 =?utf-8?B?ejFaVUJFVy9xdWNYS0daQkErOTRMcFJ1YjU3OFc2dXNQSXdQTHlQRUFaaFBL?=
 =?utf-8?B?a1BaN2o3T3hEa2VtaTY5L0tubmZtOTRiWC93M1MxTW00bUtjdjU1Z2dZZEN0?=
 =?utf-8?B?UWxsM1Z1cWxLaGNBRzVBVlpZMUhHZGlBUjZSQ0p6TU5HVmRlMlB0NXJRczJL?=
 =?utf-8?B?dUoxalB3bGdBbDRoanR3WmNkdHkwNzRKRWpVQUR4MStBVEhiWVM1MTJnOWRx?=
 =?utf-8?B?QW5PbFZtYVVhcy80b3VBQ3ozdmtKUmIrVUJDMnBMYUo3ZWRXSHkraHhGaThD?=
 =?utf-8?B?R29BUzkvU2l2b2NMS3hnZEZnQjU5aUErbGVxOWd2VjlpdTI3a0UyOWdKU3du?=
 =?utf-8?B?RVRIMkRmczF3WGVBRFdBQUlsRWtSdE5XcTh6SVdmK0xoc0NFMjBqUkFDSGlX?=
 =?utf-8?B?QkIzeDF5c3lYZ0VRZzh2ZDlFejFqMHBvS3Z2WjJCUklBYzBDOXVKY0x6a1BQ?=
 =?utf-8?B?TjgzQjVzTXpDMVZOMFVGVFdKaEpUbzkyTTk5NEhFWFZUUWR4MFJ4eUpzV1k3?=
 =?utf-8?B?TCtmSnpwZkJKME1NNmtocVd1dW1GUmJyZ2xqSU9GWjdRMjNRcGhtbkFyRTYy?=
 =?utf-8?B?RS9ZTGNkZjJGSkxUaCs0Rlg5L05kVkZ0MjVzdzZWZjJ0b3dObldCTnYyaVB6?=
 =?utf-8?B?N2JOcTJjNWRVZHU2ZUZqTVVRUnA2cjU1dllMbnBVSitmTUpEZm9YVzJmOGVk?=
 =?utf-8?B?c2ZQNG5UTzM3T1hqSllEQXZ0b29qQXpBd3Bxb1ZNQ3JWaDAwZ291ZnBaTHcy?=
 =?utf-8?B?Qno5aHhXcHdYR0NoZlkxQVpsdkY5SFYyYlJWUWVDTHBMVG9UVXgxQUlIb1Nx?=
 =?utf-8?B?T1ZiM05PU2Y4QzRUcVJGOHRKY0dSZ2hZbzRtUmRJSjR5MmVUemV5c29uNWIr?=
 =?utf-8?Q?4s1j8HAB0/O8G5AClveQz29LE?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 31d6452c-e51c-43f9-2690-08da80d67fa7
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5040.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Aug 2022 04:59:57.9965
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IuKLtB4Jp1unt5uY7lbfWHApYS+t1ANmLOiQ/mQz4YVQIvwBIEnCLe3dtUjXP7GnIl/TvMNeitK9RQYhlT3a/w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1850
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 8/16/2022 3:51 PM, Akihiko Odaki wrote:
> Google Chromebooks use Chrome OS Embedded Controller Sensor Hub instead
> of Sensor Hub Fusion and leaves MP2 uninitialized, which disables all
> functionalities, even including the registers necessary for feature
> detections.
>
> The behavior was observed with Lenovo ThinkPad C13 Yoga.
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
> Suggested-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
>  drivers/hid/amd-sfh-hid/amd_sfh_pcie.c | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>
> diff --git a/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c b/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c
> index 4b90c86ee5f8..47774b9ab3de 100644
> --- a/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c
> +++ b/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c
> @@ -288,11 +288,29 @@ int amd_sfh_irq_init(struct amd_mp2_dev *privdata)
>  	return 0;
>  }
>  
> +static const struct dmi_system_id dmi_nodevs[] = {
> +	{
> +		/*
> +		 * Google Chromebooks use Chrome OS Embedded Controller Sensor
> +		 * Hub instead of Sensor Hub Fusion and leaves MP2
> +		 * uninitialized, which disables all functionalities, even
> +		 * including the registers necessary for feature detections.
> +		 */
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Google"),
> +		},
> +	},
> +	{ }
> +};
> +
>  static int amd_mp2_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>  {
>  	struct amd_mp2_dev *privdata;
>  	int rc;
>  
> +	if (dmi_first_match(dmi_nodevs))
> +		return -ENODEV;
> +
>  	privdata = devm_kzalloc(&pdev->dev, sizeof(*privdata), GFP_KERNEL);
>  	if (!privdata)
>  		return -ENOMEM;

Could you please prefix amd_sfh patches with 'HID: amd_sfh:'
With that addressed,

Acked-by: Basavaraj Natikar <Basavaraj.Natikar@amd.com>

Thanks,
--
Basavaraj