Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp43975rwb; Wed, 17 Aug 2022 22:22:47 -0700 (PDT) X-Google-Smtp-Source: AA6agR6jZlmtJzjuCKCpYoliflQowTKFKvdGpswzRAu4zxv0SfEksFwwbvJA3BrS/9GR9xv7MXZf X-Received: by 2002:aa7:87d8:0:b0:52e:ba7a:7fc0 with SMTP id i24-20020aa787d8000000b0052eba7a7fc0mr1438359pfo.46.1660800167214; Wed, 17 Aug 2022 22:22:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660800167; cv=none; d=google.com; s=arc-20160816; b=Sx1/tG+aWOqxHIWTeBZYtnfWC49HLXzRKZnqa+/a5TcbPTQle/n3ENGlA/QLeIdkuv 6cOVTR0x0SZYeuArY2ea6n6K7PDnxo7hda6D3KjcZB7IwFbF4KGX+uoBzSTxbRg8H7Y1 Gx/Tg9wa30Ef7gWWF8AsUSe5RfR42zlbNPm01FW6KOKAJ4+bgsC4HDQWWdH7YE+o7qjz 8+koIDnJ3NphO7VpOqlnGBGEg2ac5AuQFEXnEhBIb7ojsHTW4ybeBEJDT/YtjmS5OVjx orgnYZ/oZlJngaoTcjAAgfIOyTNCvL0Ay2MskOWe6G2wCXenmLGT5O3SSL465X7FtbF0 dGmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=QFxPGXObEQnCzEMccM58YrwM1PsWK9See/nXiGkXHfk=; b=TFCisFOy5aPa559DWhsWNZkRLmqxeu+zuqamg1LaCW4w/RKc+rkwKtsJ1d2zue9qbP 9lp6gxRpnhGVKwLkiaJSl8lSilYfley4TpyCuY546Yz+t8y1wVlyau+vy8JnEdW99Ygh GilcAbAJPNt8oHyED31z1K9XemnvCUFxDpftenLEtXsTDIWfb2mfEQq+7wZY5rvpDSKs 1p2JR6FKLPdV7SOjgGGJZJjtXq9ySBjenbjsUTIYSmyzeKhgoQuKVLcpDJ+hB3j74giU 8DIuVMRAFbpV2kptTw7DQzcUuBa9mnPCwpAhNBcf7TppHXDY4QnQEjI8SQ26XrLNYqiN gvbQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cw1-20020a056a00450100b0051873a68dd2si661164pfb.252.2022.08.17.22.22.36; Wed, 17 Aug 2022 22:22:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243358AbiHRE3Y (ORCPT + 99 others); Thu, 18 Aug 2022 00:29:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238358AbiHRE3W (ORCPT ); Thu, 18 Aug 2022 00:29:22 -0400 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B58E6069E; Wed, 17 Aug 2022 21:29:21 -0700 (PDT) Received: from dggpemm500022.china.huawei.com (unknown [172.30.72.55]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4M7X1G34J7zGpXn; Thu, 18 Aug 2022 12:27:46 +0800 (CST) Received: from dggpemm500007.china.huawei.com (7.185.36.183) by dggpemm500022.china.huawei.com (7.185.36.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 18 Aug 2022 12:29:19 +0800 Received: from huawei.com (10.175.103.91) by dggpemm500007.china.huawei.com (7.185.36.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 18 Aug 2022 12:29:19 +0800 From: Yang Yingliang To: , CC: , , , Subject: [PATCH -next] net: neigh: use dev_kfree_skb_irq instead of kfree_skb() Date: Thu, 18 Aug 2022 12:37:29 +0800 Message-ID: <20220818043729.412753-1-yangyingliang@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.103.91] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpemm500007.china.huawei.com (7.185.36.183) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It is not allowed to call kfree_skb() from hardware interrupt context or with interrupts being disabled. So replace kfree_skb() with dev_kfree_skb_irq() under spin_lock_irqsave(). Fixes: 66ba215cb513 ("neigh: fix possible DoS due to net iface start/stop loop") Signed-off-by: Yang Yingliang --- net/core/neighbour.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/neighbour.c b/net/core/neighbour.c index 5b669eb80270..167826200f3e 100644 --- a/net/core/neighbour.c +++ b/net/core/neighbour.c @@ -328,7 +328,7 @@ static void pneigh_queue_purge(struct sk_buff_head *list, struct net *net) __skb_unlink(skb, list); dev_put(dev); - kfree_skb(skb); + dev_kfree_skb_irq(skb); } skb = skb_next; } -- 2.25.1