Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e5901866-4bda-e95e-c0a1-ec29ec487e19@quicinc.com>
Date:   Thu, 18 Aug 2022 10:15:59 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.1.2
Subject: Re: [PATCH v2] mm: oom_kill: add trace logs in process_mrelease()
 system call
Content-Language: en-US
To:     Andrew Morton <akpm@linux-foundation.org>
CC:     <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
        <quic_charante@quicinc.com>, <quic_pkondeti@quicinc.com>
References: <20220816060017.17996-1-pbrahma@qti.qualcomm.com>
 <20220817090247.ef99115ca7a6c847f90dc4c6@linux-foundation.org>
From:   Pratyush Brahma <quic_pbrahma@quicinc.com>
In-Reply-To: <20220817090247.ef99115ca7a6c847f90dc4c6@linux-foundation.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 17-08-2022 21:32, Andrew Morton wrote:
> On Tue, 16 Aug 2022 11:30:17 +0530 Pratyush Brahma <pbrahma@qti.qualcomm.com> wrote:
>
>> From: Charan Teja Kalla <quic_charante@quicinc.com>
>>
>> The process_mrelease() system call[1] is used to release the memory of
>> a dying process from the context of the caller, which is similar to and
>> uses the functions of the oom reaper logic. There exists trace logs for
>> a process when reaped by the oom reaper. Just extend the same to when
>> done by the process_mrelease() system call.
>>
>> ...
>>
>> +	pr_debug("process_mrelease: reaped process %d (%s), now anon-rss:%lukB, file-rss:%lukB, shmem-rss:%lukB\n",
>> +						task_pid_nr(task), task->comm,
>> +						K(get_mm_counter(mm, MM_ANONPAGES)),
>> +						K(get_mm_counter(mm, MM_FILEPAGES)),
>> +						K(get_mm_counter(mm, MM_SHMEMPAGES)));
> This addition wasn't changelogged.  It's the only pr_debug in
> oom_kill.c.  Please explain?

The equivalent pr_info() message as in oom_reap_task_mm() is made 
pr_debug() here as per review comments in patch-set v1.

>