Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp106188rwb; Thu, 18 Aug 2022 00:00:15 -0700 (PDT) X-Google-Smtp-Source: AA6agR4DX38/8fptimMlpZLNugN0Sg2CHqQr6pG79izrLjlhT/F223ktv44F2Q+5iif0mBxq5Hdf X-Received: by 2002:a17:906:844f:b0:730:8bb4:f39 with SMTP id e15-20020a170906844f00b007308bb40f39mr970275ejy.499.1660806015235; Thu, 18 Aug 2022 00:00:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660806015; cv=none; d=google.com; s=arc-20160816; b=ZktE5HhwzyNzGAaNfU43IZBPVUtGBt+Hw77MKIvy7cokD1MYez3+k4Y4JR2TiY6fHh GSvbf5Kuq3dfPGpIRqh2PCJcjexBmo9uJ6+MEdGJYNrWenDATAzcon8ThB5GdmEaRu0k jn8AsNK/HYfiHdZcm6grcWF/83xbIZ3E+SBxAq5oRc6TIl7KBnQ0oxe7lU2NKhNNv8qB oGuYOtEaZE3VAuhWiKa4Bt9P2uv2fqOnMBwxZ9ffptqPtajvY81fjBOvf4hCZMfUvqlA 5VMVsTqmJ0IlIkqMF7fb2ngLKMul6sYmeraTngcqMZSF0Zg67a3ijgAysxc7zsAQjVhA lAqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=K/LixJwA3WLA9TBt7KtHnI6QQXgIa8pTcdz8Qgajil0=; b=b40wDJit6f5kuEVk6IosamqzwYYDbtamvKEHCh5bnA1kDZTIBvYoCICPnju9F6ltRI ccpCXHBIkTuZtdIi6LqXv0dUIzBeu1S5WIR8SHnV77wx/2KIgdGdxJAJSDRBraundln7 FhN7Bu2sIEg/8t3WRgfjg7V2Gl7ntm6uSicMoPGvfhnzDN8XhUIGJlDdhLRbrBPiNXuw bvKik5jxh7qUbil+LdI+AGhcVvZ3RIoeqIW8Gcz7rsJOZX6Vez/G6SN/InFJzdZ6e1Mw mWUo5sDd/5gnS1un/0Zfnr5kLWUAmX3NwhPUB2kH2/P5qQMnUkN2r57JQ0Cgt8JoUjMg m9Kw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=WTitW138; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id pw12-20020a17090720ac00b0072f1f3ec581si451866ejb.264.2022.08.17.23.59.49; Thu, 18 Aug 2022 00:00:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=WTitW138; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243665AbiHRG0s (ORCPT + 99 others); Thu, 18 Aug 2022 02:26:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43490 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243648AbiHRG0p (ORCPT ); Thu, 18 Aug 2022 02:26:45 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00B50AA3D2; Wed, 17 Aug 2022 23:26:44 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 72DD1B82000; Thu, 18 Aug 2022 06:26:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A5C6EC433D7; Thu, 18 Aug 2022 06:26:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660804002; bh=EVJabPYCgEWslVXIIS5VTejmPf7jZfIhFfIDrDoGrMw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WTitW138d4FXxxArTaDl+vadMXEuef0DMy5kNFI2wQk1B2v5uTcpzXOQdV8WgYCGi 62f1oVsm0anAaezQ1daKMWbvNeruBv2BuWZBTMJG97kzOiUqIzdLg2nVgZ9p2lGN41 ZHCjW1vnf9imtDizIwk22LNZ4FsYuZwrBijO7xHM= Date: Thu, 18 Aug 2022 08:26:38 +0200 From: Greg KH To: Axel Rasmussen Cc: Alexander Viro , Andrew Morton , Dave Hansen , "Dmitry V . Levin" , Gleb Fotengauer-Malinovskiy , Hugh Dickins , Jan Kara , Jonathan Corbet , Mel Gorman , Mike Kravetz , Mike Rapoport , Nadav Amit , Peter Xu , Shuah Khan , Suren Baghdasaryan , Vlastimil Babka , zhangyi , linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, Mike Rapoport Subject: Re: [PATCH v6 2/5] userfaultfd: add /dev/userfaultfd for fine grained access control Message-ID: References: <20220817214728.489904-1-axelrasmussen@google.com> <20220817214728.489904-3-axelrasmussen@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220817214728.489904-3-axelrasmussen@google.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 17, 2022 at 02:47:25PM -0700, Axel Rasmussen wrote: > +static int userfaultfd_dev_open(struct inode *inode, struct file *file) > +{ > + return 0; If your open does nothing, no need to list it here at all, right? > +} > + > +static long userfaultfd_dev_ioctl(struct file *file, unsigned int cmd, unsigned long flags) > +{ > + if (cmd != USERFAULTFD_IOC_NEW) > + return -EINVAL; > + > + return new_userfaultfd(flags); > +} > + > +static const struct file_operations userfaultfd_dev_fops = { > + .open = userfaultfd_dev_open, > + .unlocked_ioctl = userfaultfd_dev_ioctl, > + .compat_ioctl = userfaultfd_dev_ioctl, Why do you need to set compat_ioctl? Shouldn't it just default to the existing one? And why is this a device node at all? Shouldn't the syscall handle all of this (to be honest, I didn't read anything but the misc code, sorry.) thanks, greg k-h