Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e692b61d-7760-48bd-b22a-9ffa9162b4f7@virtuozzo.com>
Date:   Thu, 18 Aug 2022 09:43:29 +0300
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.1.2
Subject: Re: [PATCH v2 1/4] Make place for common balloon code
To:     Ritesh Harjani <ritesh.list@gmail.com>
Cc:     Michael Ellerman <mpe@ellerman.id.au>,
        Nicholas Piggin <npiggin@gmail.com>,
        Christophe Leroy <christophe.leroy@csgroup.eu>,
        Nadav Amit <namit@vmware.com>,
        VMware PV-Drivers Reviewers <pv-drivers@vmware.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Michael S. Tsirkin" <mst@redhat.com>,
        David Hildenbrand <david@redhat.com>,
        Jason Wang <jasowang@redhat.com>,
        Andrew Morton <akpm@linux-foundation.org>, kernel@openvz.org,
        linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
        virtualization@lists.linux-foundation.org, linux-mm@kvack.org
References: <20220816094117.3144881-1-alexander.atanasov@virtuozzo.com>
 <20220816094117.3144881-2-alexander.atanasov@virtuozzo.com>
 <20220818044123.q5yzdaszcxl7mcl6@riteshh-domain>
From:   Alexander Atanasov <alexander.atanasov@virtuozzo.com>
In-Reply-To: <20220818044123.q5yzdaszcxl7mcl6@riteshh-domain>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UFZTb2NDSjZyVlJ3ZGI5bVNHazllaHBEMXJVd1NkSFFOd0FuekxicFhpUVBK?=
 =?utf-8?B?Y3B1cVNBemgwcENCbjR4ZkdzNXJRdFVjb1JIaXBrc0kveHZ2T1ZkV1d2ZmVo?=
 =?utf-8?B?TGhXa29VUnpwZmw3cnZjUVg4NlpJdDBadlBSQ0lDbVBwUUVENW13YSs3NVRJ?=
 =?utf-8?B?L3JvWFFJRG83UzNFcFB3SEh1R0dpUkVCLzI4ZGZSdStZZzQvNlkzbFRYenJB?=
 =?utf-8?B?M1p6TmpHbnk0T1BIcmMrbFEzUlEwNlNEWVRuWjRYeWJEbE5DZ0NaSTBXQStP?=
 =?utf-8?B?V0YwUkszdnczMHBQZEFpT1hBeWM4eHBNUURzTUU4VjBQa1dFODhnWUVjQWhm?=
 =?utf-8?B?cVVvODllbGFGUjdMZDFEajJlSmpTNENRNjNqV0Y4ZElyTTdhallFLzRNMGU5?=
 =?utf-8?B?dWVRYnV5d2ZsMDZBZnQ1bEs1ODNkOFZIMUlaNU9kOXRha0NiQ0xZUEk5UkJw?=
 =?utf-8?B?NmZDK3Bqc1dwclBOaXVGNTJML2ZBU2VFUFRrMmpKcEc5UWNNM0drb2pVUDUr?=
 =?utf-8?B?UytpL2pKK0RHaFJyUEEyZ1Y0Vjk4K1NDYlRKbGQ5UEpkUk9DaFlPcXVsdTh4?=
 =?utf-8?B?Wm1EN3QrQnZZQWZ6ZlEyM29mM0YwcDNBZDdudVVXR1puL253dC95R1lVcmhr?=
 =?utf-8?B?MW4yMGEvNEUveFJrR1QvVjB4UHB5Q2U1NFg4VWhoSGVPdHhEbWxOekRzeHRS?=
 =?utf-8?B?VXlWNXJ6Q2t1UjVjcFU3ZVI1UG8xMDQzSEpNTnJXTnBqMnRvOTlQN2VPa3hJ?=
 =?utf-8?B?NThORVdMMmdOQW9xTmltckZyQ1JKdzd1OWJ5dzM1c2c5YnVaWmkxNUFMVDJF?=
 =?utf-8?B?QnNpNTR2VEN5UVBINGxONnlpRjRDdTlqNmkvMWUrN1F4N0l4T09tVGlTY0Fy?=
 =?utf-8?B?TzlLT0d4UUl4M0VBUENMOUo2Z0lIWXNYZmpYYnJ1UjU4RWxESG9kUTE1Qy9x?=
 =?utf-8?B?UzB2VitwbGpUMVU3M0dGQlNGWm5rcjc4aFNRaFVWMzFiWEFLY3QxK0tQdFlk?=
 =?utf-8?B?cytYK09SaFZBOHltTnR5ZWlQTHNqaXZ3dXA3cEU2K3M0cWFjTk1PdGttUXBO?=
 =?utf-8?B?MnF4bmxyUnREY2hqeThUY1VwcDliSmdYc2JhZ2dMdnNmbUJDY1ZqQVMrZ2hq?=
 =?utf-8?B?RGl1ZjJGM3o5NlYwK2ZBZmZyZE02VEk4bWlJL01KUlM4NGlRU2E5WWh3Q1dk?=
 =?utf-8?B?WUY1NXZYN0dNOVllaUxsUzFlN2Qvb1h5NnMwMnFVQnFwdzR1ODlDNjh1L0Qv?=
 =?utf-8?B?QUhXTDBpdEM0ZEpoM1lJa09ER0VaZ1FGT2l4YTFVZTBCeVVMUkI2MEhzWlNS?=
 =?utf-8?B?NThZWU92d3BmdzJvL2RyZFJLNVdrRGthRWpUZGlYQ0Iyd2k1TlpHRWNPNm55?=
 =?utf-8?B?NVh1Q2VtWDhRdUYwaDdVNXdOUWRsalRocm1lNXg2ZkVJeDk1bFdYenJwY1pP?=
 =?utf-8?B?ZHBDcnBlNFFCYlBWeEJOcTFYS1JYbkFsWDRBeW9waEp0Sm1raWdEcjFUdVVl?=
 =?utf-8?B?S1dhVC9zVm1udlBCRWNvVVBTVGJKU3JZdWtMTFI1bGluVHZTaUhRcElUKzJX?=
 =?utf-8?B?OGhySGtmRGlRZkJHNTZXZXIyZndsYXkyNnNBV3hvZ0I0a3dNSXAyVWlzdTZC?=
 =?utf-8?B?anlRMDZBT2ZPcFRZak82OVJLci9vdVFOeTFWem9HT3BWZ3VDYmFpK1NBdURu?=
 =?utf-8?B?WXorV0UwcjRLQ01wUUJCVmFkWmZHRzBJa2xrSnM4cHNmMUdpWm9MQjl4NG5H?=
 =?utf-8?B?T0hDTnFCaHhDWHExN0owWjJEQlRaeXVRbnZGb3RITis5OUhPNGZJYnN2ZUx1?=
 =?utf-8?B?ejZlVVZSMlF3VFg3UGdYYTJBeGxCSE9RWW10UlJUSmtobDBob3ZmS1NyUS9w?=
 =?utf-8?B?UXQrSXZ0Q0l5bVBtRitCdTJUQnVzNTNKcVlXK2dIL2Z2ckNsdi9lV20yT0tH?=
 =?utf-8?B?aW5ZU0VFdjJ3VFlFVnVSZmpkenVPNEY2S3F0NTdVcUVTMDB2TU90RElPamtt?=
 =?utf-8?B?di9BNTAwWFdlWDAwNkYramE3V0l1SWFBZ2pGQW9sNFIyQWp0WGZ2blkyVmFn?=
 =?utf-8?B?SmcrVldXZEd0d1cvRnYwdXdQSWRiN3UzME1hcWpPQ1VDdjl6bXlVekpiZVFD?=
 =?utf-8?B?RE1qUVl2OTlhVHVPdDIzNG1oK3ZYcUFUTTNmcU1jdHk0Uy85bGYyNllSSnpw?=
 =?utf-8?Q?z5KyCKBa0MDL7cuvNmopxAo=3D?=
X-OriginatorOrg: virtuozzo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ad0092db-501c-481b-cdee-08da80e4f7dc
X-MS-Exchange-CrossTenant-AuthSource: VE1PR08MB4765.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Aug 2022 06:43:32.7563
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9KK9X8yKbgb9JPA0U9d+7wxzZZU6jTy9Bj27+raXbm/kzSj5/rSBDNpj2pprpMV5Asco5RilV4H2C1aqydI9N2jjj4Xamt1LqhHs89OMPsY6h5TG3O4VJgIs0TCz+0aK
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9106
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello,

On 18.08.22 7:41, Ritesh Harjani wrote:
> On 22/08/16 12:41PM, Alexander Atanasov wrote:
>> File already contains code that is common along balloon
>> drivers so rename it to reflect its contents.
>> mm/balloon_compaction.c -> mm/balloon_common.c
>>
>> Signed-off-by: Alexander Atanasov <alexander.atanasov@virtuozzo.com>
>> ---
>>   MAINTAINERS                                              | 4 ++--
>>   arch/powerpc/platforms/pseries/cmm.c                     | 2 +-
>>   drivers/misc/vmw_balloon.c                               | 2 +-
>>   drivers/virtio/virtio_balloon.c                          | 2 +-
>>   include/linux/{balloon_compaction.h => balloon_common.h} | 2 +-
>>   mm/Makefile                                              | 2 +-
>>   mm/{balloon_compaction.c => balloon_common.c}            | 4 ++--
> 
>>   mm/migrate.c                                             | 2 +-
>>   mm/vmscan.c                                              | 2 +-
> I think we don't need balloon headers in above two files at all.
> I don't see any references of balloon functions in them.

...

> Since I don't often look into this side of code, it's better to confirm :)

Yes, you are right. It passed a visual and compile verification.
I will remove them in the next iteration. Thanks for pointing it out :)

-- 
Regards,
Alexander Atanasov