Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220816120759.11552-1-ilpo.jarvinen@linux.intel.com>
In-Reply-To: <20220816120759.11552-1-ilpo.jarvinen@linux.intel.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Thu, 18 Aug 2022 10:18:19 +0300
Message-ID: <CAHp75Vf-2daFdRiB_ZqA6QshaEO5iLn-XQn8fBENZoCkkf_nKA@mail.gmail.com>
Subject: Re: [PATCH 1/1] serial: 8250: Add helper for clearing IER
To:     =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jirislaby@kernel.org>,
        "open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Aug 16, 2022 at 3:14 PM Ilpo J=C3=A4rvinen
<ilpo.jarvinen@linux.intel.com> wrote:
>
> A number of places want to clear IER with the same CAP_UUE trick.
> Create a helper for that.

No objections,
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

> Signed-off-by: Ilpo J=C3=A4rvinen <ilpo.jarvinen@linux.intel.com>
> ---
>  drivers/tty/serial/8250/8250_port.c | 24 +++++++++++-------------
>  1 file changed, 11 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/tty/serial/8250/8250_port.c b/drivers/tty/serial/825=
0/8250_port.c
> index 39b35a61958c..25e4761e3c57 100644
> --- a/drivers/tty/serial/8250/8250_port.c
> +++ b/drivers/tty/serial/8250/8250_port.c
> @@ -752,6 +752,14 @@ static void serial8250_set_sleep(struct uart_8250_po=
rt *p, int sleep)
>         serial8250_rpm_put(p);
>  }
>
> +static void serial8250_clear_IER(struct uart_8250_port *up)
> +{
> +       if (up->capabilities & UART_CAP_UUE)
> +               serial_out(up, UART_IER, UART_IER_UUE);
> +       else
> +               serial_out(up, UART_IER, 0);
> +}
> +
>  #ifdef CONFIG_SERIAL_8250_RSA
>  /*
>   * Attempts to turn on the RSA FIFO.  Returns zero on failure.
> @@ -1329,10 +1337,7 @@ static void autoconfig(struct uart_8250_port *up)
>         serial8250_out_MCR(up, save_mcr);
>         serial8250_clear_fifos(up);
>         serial_in(up, UART_RX);
> -       if (up->capabilities & UART_CAP_UUE)
> -               serial_out(up, UART_IER, UART_IER_UUE);
> -       else
> -               serial_out(up, UART_IER, 0);
> +       serial8250_clear_IER(up);
>
>  out_unlock:
>         spin_unlock_irqrestore(&port->lock, flags);
> @@ -2142,10 +2147,7 @@ static void serial8250_put_poll_char(struct uart_p=
ort *port,
>          *      First save the IER then disable the interrupts
>          */
>         ier =3D serial_port_in(port, UART_IER);
> -       if (up->capabilities & UART_CAP_UUE)
> -               serial_port_out(port, UART_IER, UART_IER_UUE);
> -       else
> -               serial_port_out(port, UART_IER, 0);
> +       serial8250_clear_IER(up);
>
>         wait_for_xmitr(up, UART_LSR_BOTH_EMPTY);
>         /*
> @@ -3383,11 +3385,7 @@ void serial8250_console_write(struct uart_8250_por=
t *up, const char *s,
>          *      First save the IER then disable the interrupts
>          */
>         ier =3D serial_port_in(port, UART_IER);
> -
> -       if (up->capabilities & UART_CAP_UUE)
> -               serial_port_out(port, UART_IER, UART_IER_UUE);
> -       else
> -               serial_port_out(port, UART_IER, 0);
> +       serial8250_clear_IER(up);
>
>         /* check scratch reg to see if port powered off during system sle=
ep */
>         if (up->canary && (up->canary !=3D serial_port_in(port, UART_SCR)=
)) {
> --
> 2.30.2
>


--=20
With Best Regards,
Andy Shevchenko