Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754048AbXFKQWy (ORCPT ); Mon, 11 Jun 2007 12:22:54 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752125AbXFKQWr (ORCPT ); Mon, 11 Jun 2007 12:22:47 -0400 Received: from e5.ny.us.ibm.com ([32.97.182.145]:40785 "EHLO e5.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751805AbXFKQWq (ORCPT ); Mon, 11 Jun 2007 12:22:46 -0400 Message-ID: <466D76DC.7020900@us.ibm.com> Date: Mon, 11 Jun 2007 09:22:52 -0700 From: Badari Pulavarty User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:0.9.4.1) Gecko/20020508 Netscape6/6.2.3 X-Accept-Language: en-us MIME-Version: 1.0 To: Cedric Le Goater CC: Linux Kernel Mailing List , Andrew Morton , Pavel Emelianov , Herbert Poetzl , "Eric W. Biederman" , "Serge E. Hallyn" , Linux Containers Subject: Re: PATCH -mm] fix create_new_namespaces() return value References: <466D5830.9010200@fr.ibm.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2670 Lines: 91 Cedric Le Goater wrote: >The following patch modifies create_new_namespaces() to also use the >errors returned by the copy_*_ns routines and not to systematically >return ENOMEM. > In my initial version, I did same. It doesn't work :( copy_*_ns() routines doesn't return any errors. All they return is NULL in case of a failure + with the exception of copy_mnt_ns, there are no other failure cases. So, there is no way to find out why the copy_*_ns() routines failed from create_new_namespaces(). If you really really want to do this, change all copy_*_ns() routines to returns meaningful errors instead of NULL. > > >Signed-off-by: Cedric Le Goater >Cc: Serge E. Hallyn >Cc: Badari Pulavarty >Cc: Pavel Emelianov >Cc: Herbert Poetzl >Cc: Eric W. Biederman >--- > kernel/nsproxy.c | 23 +++++++++++++++++------ > 1 file changed, 17 insertions(+), 6 deletions(-) > >Index: 2.6.22-rc4-mm2/kernel/nsproxy.c >=================================================================== >--- 2.6.22-rc4-mm2.orig/kernel/nsproxy.c >+++ 2.6.22-rc4-mm2/kernel/nsproxy.c >@@ -58,30 +58,41 @@ static struct nsproxy *create_new_namesp > struct fs_struct *new_fs) > { > struct nsproxy *new_nsp; >+ int err; > > new_nsp = clone_nsproxy(tsk->nsproxy); > if (!new_nsp) > return ERR_PTR(-ENOMEM); > > new_nsp->mnt_ns = copy_mnt_ns(flags, tsk->nsproxy->mnt_ns, new_fs); >- if (IS_ERR(new_nsp->mnt_ns)) >+ if (IS_ERR(new_nsp->mnt_ns)) { >+ err = PTR_ERR(new_nsp->mnt_ns); > goto out_ns; >+ } > > new_nsp->uts_ns = copy_utsname(flags, tsk->nsproxy->uts_ns); >- if (IS_ERR(new_nsp->uts_ns)) >+ if (IS_ERR(new_nsp->uts_ns)) { >+ err = PTR_ERR(new_nsp->uts_ns); > goto out_uts; >+ } > > new_nsp->ipc_ns = copy_ipcs(flags, tsk->nsproxy->ipc_ns); >- if (IS_ERR(new_nsp->ipc_ns)) >+ if (IS_ERR(new_nsp->ipc_ns)) { >+ err = PTR_ERR(new_nsp->ipc_ns); > goto out_ipc; >+ } > > new_nsp->pid_ns = copy_pid_ns(flags, tsk->nsproxy->pid_ns); >- if (IS_ERR(new_nsp->pid_ns)) >+ if (IS_ERR(new_nsp->pid_ns)) { >+ err = PTR_ERR(new_nsp->pid_ns); > goto out_pid; >+ } > > new_nsp->user_ns = copy_user_ns(flags, tsk->nsproxy->user_ns); >- if (IS_ERR(new_nsp->user_ns)) >+ if (IS_ERR(new_nsp->user_ns)) { >+ err = PTR_ERR(new_nsp->user_ns); > Hmm.. copy_user_ns() ? I don't see this in rc4-mm2. Thanks, Badari - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/