Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <85193de5-244c-2cda-e442-656769b97b14@linaro.org>
Date:   Thu, 18 Aug 2022 11:09:53 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH v3 2/2] power: supply: rt9471: Add Richtek RT9471 charger
 driver
Content-Language: en-US
To:     cy_huang <u0084500@gmail.com>, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, sre@kernel.org
Cc:     mazziesaccount@gmail.com, alina_yu@richtek.com,
        cy_huang@richtek.com, alinayu829@gmail.com,
        linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <1660785696-9010-1-git-send-email-u0084500@gmail.com>
 <1660785696-9010-3-git-send-email-u0084500@gmail.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <1660785696-9010-3-git-send-email-u0084500@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 18/08/2022 04:21, cy_huang wrote:
> From: ChiYuan Huang <cy_huang@richtek.com>
> 
> Add support for the RT9471 3A 1-Cell Li+ battery charger.
> 
> The RT9471 is a highly-integrated 3A switch mode battery charger with
> low impedance power path to better optimize the charging efficiency.
> 
> Co-developed-by: Alina Yu <alina_yu@richtek.com>
> Signed-off-by: Alina Yu <alina_yu@richtek.com>
> Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
> ---
> Since v2:
> - Fix checkpatch error about 'foo * bar' to 'foo *bar' in psy_device_to_chip function.
> - Specify the member name directly for the use of linear range.
> 
> ---

(...)

> +
> +static DEVICE_ATTR_RW(sysoff_enable);
> +static DEVICE_ATTR_RW(charge_term_enable);
> +static DEVICE_ATTR_RW(port_detect_enable);
> +
> +static struct attribute *rt9471_sysfs_entries[] = {
> +	&dev_attr_sysoff_enable.attr,
> +	&dev_attr_charge_term_enable.attr,
> +	&dev_attr_port_detect_enable.attr,
> +	NULL

You need to document the sysfs ABI in Documentation.

> +};
> +
> +static const struct attribute_group rt9471_attr_group = {
> +	.attrs	= rt9471_sysfs_entries,
> +};
> +
> +static const struct attribute_group *rt9471_attr_groups[] = {
> +	&rt9471_attr_group,
> +	NULL
> +};

(...)

> +
> +static const struct of_device_id rt9471_of_device_id[] = {
> +	{ .compatible = "richtek,rt9471" },
> +	{}
> +};
> +MODULE_DEVICE_TABLE(of, rt9471_of_device_id);
> +
> +static struct i2c_driver rt9471_driver = {
> +	.driver = {
> +		.name = "rt9471",
> +		.owner = THIS_MODULE,

You should not need this. Run coccinelle/coccicheck on your driver.


Best regards,
Krzysztof