Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <afcaffc6-aa07-d95f-6823-a858b53ee978@linux.intel.com>
Date:   Thu, 18 Aug 2022 11:14:41 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.12.0
Subject: Re: [PATCH -next] ASoC: SOF: ipc4-topology: fix wrong use of sizeof
 in sof_ipc4_widget_setup_comp_src()
Content-Language: en-US
To:     Yang Yingliang <yangyingliang@huawei.com>,
        linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
        sound-open-firmware@alsa-project.org
Cc:     rander.wang@intel.com, pierre-louis.bossart@linux.intel.com,
        ranjani.sridharan@linux.intel.com, broonie@kernel.org
References: <20220818081751.2407066-1-yangyingliang@huawei.com>
From:   =?UTF-8?Q?P=c3=a9ter_Ujfalusi?= <peter.ujfalusi@linux.intel.com>
In-Reply-To: <20220818081751.2407066-1-yangyingliang@huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 18/08/2022 11:17, Yang Yingliang wrote:
> It should be size of the struct sof_ipc4_src, not data pointer pass to
> sof_update_ipc_object().

Good find, thank you.

Acked-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>

> Fixes: b85f4fc40d56 ("ASoC: SOF: add ipc4 SRC module support")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
>  sound/soc/sof/ipc4-topology.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/sof/ipc4-topology.c b/sound/soc/sof/ipc4-topology.c
> index af072b484a60..c6abfaf5d532 100644
> --- a/sound/soc/sof/ipc4-topology.c
> +++ b/sound/soc/sof/ipc4-topology.c
> @@ -771,7 +771,7 @@ static int sof_ipc4_widget_setup_comp_src(struct snd_sof_widget *swidget)
>  		goto err;
>  
>  	ret = sof_update_ipc_object(scomp, src, SOF_SRC_TOKENS, swidget->tuples,
> -				    swidget->num_tuples, sizeof(src), 1);
> +				    swidget->num_tuples, sizeof(*src), 1);
>  	if (ret) {
>  		dev_err(scomp->dev, "Parsing SRC tokens failed\n");
>  		goto err;

-- 
Péter