Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp201276rwb; Thu, 18 Aug 2022 02:09:36 -0700 (PDT) X-Google-Smtp-Source: AA6agR7qsz8IYf9pwukWzrPseQEvHVE6eq3ad/Skki+YsxonGyuZUHZee8fBl05ln36TGBh6YbF4 X-Received: by 2002:aa7:989c:0:b0:535:e03b:2979 with SMTP id r28-20020aa7989c000000b00535e03b2979mr709706pfl.53.1660813775722; Thu, 18 Aug 2022 02:09:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660813775; cv=none; d=google.com; s=arc-20160816; b=e8/Gqk2MbrItPb12EWf8mK+3cKwsfk+fMqkalaFnrfgj6f07iIDIB3rjLeLVufNAJK JOR+cjFgTB/oqeGwudo22yK+Kw1aHd9//lXS1H7UaXlTl9M8+Zb7kpscufIWPeIrG6rN T2vHBSa+Ougi1apbe+MqGejjCdoMdq7ZF1JkTOcByBBTxyrng6+nYHTra7pw9sprcakg 6T55CCb6oMLYO5wMl3bvmjQfrE61HNxwYnbWQE4E5lGmQ2fCVGrAJuTBEL94JV+SYuCr 6hDbmOUp1l+JHFVFIqOgyDcCqIDKkgTjY7nTufubRx9R9kHpNi5V5w/5qkYUpVtU8wH3 737g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:references:message-id :content-transfer-encoding:cc:date:in-reply-to:from:subject :mime-version:dkim-signature; bh=qf/fOtvxzphZECcP4g0SbRjHJLvM9rnNKj1D8UYOdCU=; b=HMp4KsJ0VronxzLn1Yw8muyEFHP7IWEbJG/S13UJAW6Ytso9daeRoFoCjT362dAgcm NIB8GHy+bHX7NjFZtzB3t5Xw1YuFtj6xOUt3ySVCE5QyJKSCVoKRnRg1PoUB43hCim69 vzh33MDQHibIw/G1mvRraQ8rktZFfvku+BtsJgjF0p21uuZSZBtSuSuSX9AKozuMVC7I hA4qL31oZswvOWKAoXxZj2dwCRGCA2HPkR6oAd7Ankg/fffoO6NLBgQCFoXHydDadAMB ZIJagY+iWThRn6i9nE4d4WkuHy94ZxpCy5kwa+QIrtOOUrKH16S7PGPBUxzVEYWDC5jd Wt1w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b="F/jfdAqr"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j8-20020a170902758800b001714080c147si792171pll.515.2022.08.18.02.09.24; Thu, 18 Aug 2022 02:09:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b="F/jfdAqr"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240191AbiHRJH5 (ORCPT + 99 others); Thu, 18 Aug 2022 05:07:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50122 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239788AbiHRJHz (ORCPT ); Thu, 18 Aug 2022 05:07:55 -0400 Received: from out1.migadu.com (out1.migadu.com [91.121.223.63]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 573AFB08A4 for ; Thu, 18 Aug 2022 02:07:54 -0700 (PDT) Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1660813672; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qf/fOtvxzphZECcP4g0SbRjHJLvM9rnNKj1D8UYOdCU=; b=F/jfdAqruc6NZpYfm4kHww/8zt7yCw/PiZesk1jAs3NJOvJangOTjsU6uFj9E7rUxFuXJ7 5ieJIptdFb3hY8PByLbsyV6cIbEe+VQLfRd7/3vilGT7HAiXeYGmfuEUFVrMwEy4M1YewR sJQltiej44aVBe0G2b8tkMrWT8QiJpM= MIME-Version: 1.0 Subject: Re: [PATCH v2 2/2] mm/damon: replace pmd_huge() with pmd_trans_huge() for THP X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: Date: Thu, 18 Aug 2022 17:07:23 +0800 Cc: sj@kernel.org, Andrew Morton , Mike Kravetz , damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: <228E21D0-536C-40BC-A21A-52C1762DD2EB@linux.dev> References: <58b1d1f5fbda7db49ca886d9ef6783e3dcbbbc98.1660805030.git.baolin.wang@linux.alibaba.com> <58b1d1f5fbda7db49ca886d9ef6783e3dcbbbc98.1660805030.git.baolin.wang@linux.alibaba.com> To: Baolin Wang X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Aug 18, 2022, at 15:37, Baolin Wang = wrote: >=20 > The pmd_huge() is usually used to indicate if a pmd level hugetlb, > however a pmd mapped huge page can only be THP in = damon_mkold_pmd_entry() > or damon_young_pmd_entry(), so replacing pmd_huge() with = pmd_trans_huge() > in this case to make code more readable according to the discussion = [1]. >=20 > [1] = https://lore.kernel.org/all/098c1480-416d-bca9-cedb-ca495df69b64@linux.ali= baba.com/ >=20 > Signed-off-by: Baolin Wang Reviewed-by: Muchun Song Thanks.