Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp215487rwb; Thu, 18 Aug 2022 02:28:50 -0700 (PDT) X-Google-Smtp-Source: AA6agR4e9jAoOIown03CvLaK7lQE9/cpKZFhYiOhNotWrym+xu+kKzSjQ6ETu79s87S8I61JDrwK X-Received: by 2002:a05:6a00:816:b0:52f:43f9:b644 with SMTP id m22-20020a056a00081600b0052f43f9b644mr2152293pfk.57.1660814929865; Thu, 18 Aug 2022 02:28:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660814929; cv=none; d=google.com; s=arc-20160816; b=REq23VZrgvQlKPyTxsnBgAQ3cqku99oVWhTiqaXVo3TKzUOGbxWqOOrBmXLFva+8lW YLB5gXfGEfKs8oSuj6EpwRBoAYK9ylFN+cDIVOK2lh7zMrvsx3epwvuComhkkaod4LST QLtTPUjyLAnU5d7tFqkVT8Ld29i1IcLzxQKuIixgQB+Hvt87CrH3X/jdRwufoyBG1yoH 4daHS7LKFAoyZfm0mrZ1eso1tnwQAzblEmmDd9SBwg+XitCNpgzmS/0TzQhzYljrDkor FFGJEmX7M+IXtXikuUcOx4IK+EX3utow5g+luKy4ADlWcOgu/JNFD1Y5uHXZuor8/+OX D0Ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=20C+wP6RLvGXbBd56waFCzKOUBParbX3x6QwIv4oHS0=; b=nbOQOkS0TzNX4Ge95oilqb60kryd9pZJqsalm0ZSJzWCBXIQaEGxjLrssTgC2HPPvo /6vYNpLUcxPZaI63bz50uOmGnT1e83So5x1V0H5bW76wqSlCClhkEpdLhZR+S+uwHb52 1+wYlT7M30QWbCJRJYQLn5rZL2HXeE8UfCgJuFWl897hPHo/59J4Liqc8nEt/W7UAbFV YSXtfpG0TBvRkUQtriaycnpJlOybk4i1rFz3JGOPjTL50LflRDigF/w61jvh9oXiZTKC 04OzSBuv1WEYUYK4OEwWmSJT8jL31RBDZNjFLoc8TcOcvhflIxaVq+8qjI+Vn0NdpDhF 8aQw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@denx.de header.s=phobos-20191101 header.b=ayUWVnAz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d9-20020a170902aa8900b0016d4e5ca5fbsi840615plr.308.2022.08.18.02.28.39; Thu, 18 Aug 2022 02:28:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@denx.de header.s=phobos-20191101 header.b=ayUWVnAz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239604AbiHRJUg (ORCPT + 99 others); Thu, 18 Aug 2022 05:20:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53866 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230506AbiHRJUd (ORCPT ); Thu, 18 Aug 2022 05:20:33 -0400 Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 336A47F082; Thu, 18 Aug 2022 02:20:32 -0700 (PDT) Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 1A36484889; Thu, 18 Aug 2022 11:20:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1660814430; bh=20C+wP6RLvGXbBd56waFCzKOUBParbX3x6QwIv4oHS0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ayUWVnAzMVp/7f2uTUIeUhejcYHkGaDQtAi5WC2REd0FNKzPVxGAWQuTcEMxU72dn wl2NKbMPVENpdmV5SdnFbdrbqgB3IsaN4oXVF4npk9yv0IoIcwJMy0K5nSyMw6VzvG ZoZxpJUD5gnFJSzKDcSE2yGvmEIQHZ+pVKvWoCOpAlGEIfSO3CSVe7kAwVzWp3QrRQ SL4LVFTQ9yLhjGNdF1QRfWtzDlqvIXFPjOMox9upujX5FJyYCpgE+GCUTht6kE9jPg QQA6LgvfAv6ytUS6Gw33uk4l1HwVMeipnBwUSHdNiyu8kMeEDRXq8Tqaq+tXWurqAk XXqvaV8StsQuw== Message-ID: <2afdb802-9a86-8313-ebfa-9f2fee7e0023@denx.de> Date: Thu, 18 Aug 2022 11:20:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.1.2 Subject: Re: [PATCH v3 0/6] Add the iMX8MP PCIe support Content-Language: en-US To: Richard Zhu , p.zabel@pengutronix.de, l.stach@pengutronix.de, bhelgaas@google.com, lorenzo.pieralisi@arm.com, robh@kernel.org, shawnguo@kernel.org, vkoul@kernel.org, alexander.stein@ew.tq-group.com Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, linux-imx@nxp.com References: <1660806153-29001-1-git-send-email-hongxing.zhu@nxp.com> From: Marek Vasut In-Reply-To: <1660806153-29001-1-git-send-email-hongxing.zhu@nxp.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/18/22 09:02, Richard Zhu wrote: > Based on the 6.0-rc1 of the pci/next branch. > This series adds the i.MX8MP PCIe support and had been tested on i.MX8MP > EVK board when one PCIe NVME device is used. > > - i.MX8MP PCIe has reversed initial PERST bit value refer to i.MX8MQ/i.MX8MM. > Add the PHY PERST explicitly for i.MX8MP PCIe PHY. > - Add the i.MX8MP PCIe PHY support in the i.MX8M PCIe PHY driver. > And share as much as possible codes with i.MX8MM PCIe PHY. > - Add the i.MX8MP PCIe support in binding document, DTS files, and PCIe > driver. > > Main changes v2-->v3: > - Fix the schema checking error in the PHY dt-binding patch. > - Inspired by Lucas, the PLL configurations might not required when > external OSC is used as PCIe referrence clock. It's true. Remove all > the HSIO PLL bit manipulations, and PCIe works fine on i.MX8MP EVK board > with one NVME device is used. > - Drop the #4 patch of v2, since it had been applied by Rob. > > Main changes v1-->v2: > - It's my fault forget including Vinod, re-send v2 after include Vinod > and linux-phy@lists.infradead.org. > - List the basements of this patch-set. The branch, codes changes and so on. > - Clean up some useless register and bit definitions in #3 patch. > > Documentation/devicetree/bindings/phy/fsl,imx8-pcie-phy.yaml | 16 +++++++-- > arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 53 +++++++++++++++++++++++++++++ > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 46 ++++++++++++++++++++++++- > drivers/pci/controller/dwc/pci-imx6.c | 17 +++++++++- > drivers/phy/freescale/phy-fsl-imx8m-pcie.c | 150 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++------------------------- > drivers/reset/reset-imx7.c | 1 + > 6 files changed, 232 insertions(+), 51 deletions(-) For the entire series: Tested-by: Marek Vasut Thanks !