Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <1660785696-9010-1-git-send-email-u0084500@gmail.com>
 <1660785696-9010-3-git-send-email-u0084500@gmail.com> <85193de5-244c-2cda-e442-656769b97b14@linaro.org>
In-Reply-To: <85193de5-244c-2cda-e442-656769b97b14@linaro.org>
From:   ChiYuan Huang <u0084500@gmail.com>
Date:   Thu, 18 Aug 2022 18:16:04 +0800
Message-ID: <CADiBU3_RUTiG0T5vEKe0qHmHHQDXyMQL2BxFA+YgL_u-VGUNkA@mail.gmail.com>
Subject: Re: [PATCH v3 2/2] power: supply: rt9471: Add Richtek RT9471 charger driver
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Sebastian Reichel <sre@kernel.org>,
        Matti Vaittinen <mazziesaccount@gmail.com>,
        =?UTF-8?B?5ri45a2Q6aao?= <alina_yu@richtek.com>,
        cy_huang <cy_huang@richtek.com>, alinayu829@gmail.com,
        Linux PM <linux-pm@vger.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>, lkml <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> =E6=96=BC 2022=E5=B9=
=B48=E6=9C=8818=E6=97=A5 =E9=80=B1=E5=9B=9B =E4=B8=8B=E5=8D=884:09=E5=AF=AB=
=E9=81=93=EF=BC=9A
>
> On 18/08/2022 04:21, cy_huang wrote:
> > From: ChiYuan Huang <cy_huang@richtek.com>
> >
> > Add support for the RT9471 3A 1-Cell Li+ battery charger.
> >
> > The RT9471 is a highly-integrated 3A switch mode battery charger with
> > low impedance power path to better optimize the charging efficiency.
> >
> > Co-developed-by: Alina Yu <alina_yu@richtek.com>
> > Signed-off-by: Alina Yu <alina_yu@richtek.com>
> > Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
> > ---
> > Since v2:
> > - Fix checkpatch error about 'foo * bar' to 'foo *bar' in psy_device_to=
_chip function.
> > - Specify the member name directly for the use of linear range.
> >
> > ---
>
> (...)
>
> > +
> > +static DEVICE_ATTR_RW(sysoff_enable);
> > +static DEVICE_ATTR_RW(charge_term_enable);
> > +static DEVICE_ATTR_RW(port_detect_enable);
> > +
> > +static struct attribute *rt9471_sysfs_entries[] =3D {
> > +     &dev_attr_sysoff_enable.attr,
> > +     &dev_attr_charge_term_enable.attr,
> > +     &dev_attr_port_detect_enable.attr,
> > +     NULL
>
> You need to document the sysfs ABI in Documentation.
Can it be define in 'sysfs-class-power' or a dedicated file called
'sysfs-class-power-rt9471'?
Not sure which one is better.

>
> > +};
> > +
> > +static const struct attribute_group rt9471_attr_group =3D {
> > +     .attrs  =3D rt9471_sysfs_entries,
> > +};
> > +
> > +static const struct attribute_group *rt9471_attr_groups[] =3D {
> > +     &rt9471_attr_group,
> > +     NULL
> > +};
>
> (...)
>
> > +
> > +static const struct of_device_id rt9471_of_device_id[] =3D {
> > +     { .compatible =3D "richtek,rt9471" },
> > +     {}
> > +};
> > +MODULE_DEVICE_TABLE(of, rt9471_of_device_id);
> > +
> > +static struct i2c_driver rt9471_driver =3D {
> > +     .driver =3D {
> > +             .name =3D "rt9471",
> > +             .owner =3D THIS_MODULE,
>
> You should not need this. Run coccinelle/coccicheck on your driver.
Yes, I found it. 'module_i2c_driver' already include this owner setting.
Just remove it. Thanks.
>
>
> Best regards,
> Krzysztof