Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp318246rwb; Thu, 18 Aug 2022 04:34:56 -0700 (PDT) X-Google-Smtp-Source: AA6agR7Ozs8oE/3nAgjjxidtvz5pLUO+BF+ZcSQq7RmjyT5usQ1EFlkIT5koniq3Xhg0u5DZlF0Q X-Received: by 2002:a17:90b:3e8b:b0:1f5:8706:18a1 with SMTP id rj11-20020a17090b3e8b00b001f5870618a1mr8565278pjb.112.1660822495777; Thu, 18 Aug 2022 04:34:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660822495; cv=none; d=google.com; s=arc-20160816; b=GhtnBPFi5bTB6F2CDHf4FVduMjtTKMCBb/LOHdiGX5H6Zij610RCqGPtgl+4ND2IJV AFQcQcxnv/Y6CD3rmBdOpSJuU2d8OMms+EMH8lCYoi9JQSzUCsw1huMsTXNYOgbmVH07 0mesyz4yBGxVaP3z/MLgXLteutDeM1UJoTsnrWDgY+SUdAJE2OEu0UZ3i2PJ9rs2SGsB lyOJO5VSCobL1EUSNDSBFF10Fop6G3ZvBWa0ibQK7g6cnJ+n348/Kq7MHh4ug+H0mpko lviIsjMkn48lib1/mRvYgl4aAb9XaJRkw7k1L4cE0xIsFSkuvo4PtHPjUyEU4eBD6VRU /V+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=DYZp5fUojkgEmQPdhASVjuZI+pEOCNYSl5ZiimZkaT8=; b=e2b0gJAzKlxTZa0dGeV/wRlWU2OBJbevJgvKw5oTAvtydoCqCaR8xuN+Bzel/HiJkY S3gyk6n4hbXcWjz04I4vtfpVkqfJCxjwIeQx7ucMxDSykK3mzj9ZPFFvQBjiL5Xz0f8M miyzwXErpNsa28SvJQujsXpgd0gHolIuYcFZXV5Eu4dCWMkQMStW87qZdVROAMtjHsx+ 73eZdn8qII51jskYny8OI4c9+0I66pHM48aFJ8VHyY/1cHPBiHWMRnOz2i/vRdmAwWh8 8hr1Jjm2n5rlJ9sxtSgY5dXtlT2g1oAeCwxYyyzuw4snsxsYvpdM/4L9J7EK24B/kctt umFg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id jm12-20020a17090304cc00b00158643c240asi1086636plb.87.2022.08.18.04.34.44; Thu, 18 Aug 2022 04:34:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244335AbiHRLNV (ORCPT + 99 others); Thu, 18 Aug 2022 07:13:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244325AbiHRLNT (ORCPT ); Thu, 18 Aug 2022 07:13:19 -0400 Received: from a.mx.secunet.com (a.mx.secunet.com [62.96.220.36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 784FDC1B; Thu, 18 Aug 2022 04:13:15 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by a.mx.secunet.com (Postfix) with ESMTP id 2883F20538; Thu, 18 Aug 2022 13:13:14 +0200 (CEST) X-Virus-Scanned: by secunet Received: from a.mx.secunet.com ([127.0.0.1]) by localhost (a.mx.secunet.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lked6gCadlW7; Thu, 18 Aug 2022 13:13:13 +0200 (CEST) Received: from mailout2.secunet.com (mailout2.secunet.com [62.96.220.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by a.mx.secunet.com (Postfix) with ESMTPS id A1C2820519; Thu, 18 Aug 2022 13:13:13 +0200 (CEST) Received: from cas-essen-01.secunet.de (unknown [10.53.40.201]) by mailout2.secunet.com (Postfix) with ESMTP id 8ED5B80004A; Thu, 18 Aug 2022 13:13:13 +0200 (CEST) Received: from mbx-essen-01.secunet.de (10.53.40.197) by cas-essen-01.secunet.de (10.53.40.201) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 18 Aug 2022 13:13:13 +0200 Received: from gauss2.secunet.de (10.182.7.193) by mbx-essen-01.secunet.de (10.53.40.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 18 Aug 2022 13:13:13 +0200 Received: by gauss2.secunet.de (Postfix, from userid 1000) id AB11A3182AA7; Thu, 18 Aug 2022 13:13:12 +0200 (CEST) Date: Thu, 18 Aug 2022 13:13:12 +0200 From: Steffen Klassert To: Gautam Menghani CC: , , , , , , , , , Subject: Re: [PATCH v3] selftests/net: Refactor xfrm_fill_key() to use array of structs Message-ID: <20220818111312.GH566407@gauss3.secunet.de> References: <55c8de7e-a6e8-fc79-794d-53536ad7a65d@collabora.com> <20220806163530.70182-1-gautammenghani201@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20220806163530.70182-1-gautammenghani201@gmail.com> X-ClientProxiedBy: cas-essen-02.secunet.de (10.53.40.202) To mbx-essen-01.secunet.de (10.53.40.197) X-EXCLAIMER-MD-CONFIG: 2c86f778-e09b-4440-8b15-867914633a10 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 06, 2022 at 10:05:30PM +0530, Gautam Menghani wrote: > A TODO in net/ipsec.c asks to refactor the code in xfrm_fill_key() to > use set/map to avoid manually comparing each algorithm with the "name" > parameter passed to the function as an argument. This patch refactors > the code to create an array of structs where each struct contains the > algorithm name and its corresponding key length. > > Signed-off-by: Gautam Menghani Applied to ipsec-next, thanks!