Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [v2] cachefiles: fix error return code in
 cachefiles_ondemand_copen()
To:     JeffleXu <jefflexu@linux.alibaba.com>, <dhowells@redhat.com>
CC:     <linux-cachefs@redhat.com>, <linux-kernel@vger.kernel.org>,
        <kernel-janitors@vger.kernel.org>,
        "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
References: <20220818111935.1683062-1-sunke32@huawei.com>
 <e4e18421-7820-f1e3-6762-5959c2bd7ea4@linux.alibaba.com>
From:   Sun Ke <sunke32@huawei.com>
Message-ID: <adf4b4c2-75a2-705d-8870-df130fb583fb@huawei.com>
Date:   Thu, 18 Aug 2022 19:27:59 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.1
MIME-Version: 1.0
In-Reply-To: <e4e18421-7820-f1e3-6762-5959c2bd7ea4@linux.alibaba.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


在 2022/8/18 19:14, JeffleXu 写道:
> 
> 
> On 8/18/22 7:19 PM, Sun Ke wrote:
>> If size < 0; open request will fail, but cachefiles_ondemand_copen return 0.
>> Fix to return a negative error code.
> 
> Could you please also update the commit log?

The cache_size field of copen is specified by the user daemon. If 
cache_size < 0, then the OPEN request is expected to fail, while copen 
itself shall succeed. However, return 0 is indeed unexpected when 
cache_size is an invalid error code.
Fix to return a negative error code.

right?
> 
> Otherwise LGTM.
> 
> Reviewed-by: Jingbo Xu <jefflexu@linux.alibaba.com>
> 
> 
> BTW, also cc linux-fsdevel@vger.kernel.org
> 
>>
>> Fixes: c8383054506c ("cachefiles: notify the user daemon when looking up cookie")
>> Signed-off-by: Sun Ke <sunke32@huawei.com>
>> ---
>>   fs/cachefiles/ondemand.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/cachefiles/ondemand.c b/fs/cachefiles/ondemand.c
>> index 1fee702d5529..ea8a1e8317d9 100644
>> --- a/fs/cachefiles/ondemand.c
>> +++ b/fs/cachefiles/ondemand.c
>> @@ -159,7 +159,7 @@ int cachefiles_ondemand_copen(struct cachefiles_cache *cache, char *args)
>>   	/* fail OPEN request if daemon reports an error */
>>   	if (size < 0) {
>>   		if (!IS_ERR_VALUE(size))
>> -			size = -EINVAL;
>> +			ret = size = -EINVAL;
>>   		req->error = size;
>>   		goto out;
>>   	}
>