Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <CANXPkT6mYusYe8O0dbq3vW+24SsUZ19PqhOL+wLFRnbFXwu0Zg@mail.gmail.com>
 <CANXPkT7nOhH+5bD0ycyRBT9FKQBBszCVuWkqp4tFtVRf2+8DFg@mail.gmail.com>
 <CANXPkT5k9Pw4ka6CihyCg0oTd-32Te-ox=f3=9rtCphVgrdctA@mail.gmail.com>
 <165590120140.1149771.2257818527859865760@Monstersaurus> <4883f0a7-6a1b-31bd-33fe-db8f6dcf73fa@selasky.org>
 <CANXPkT73ssg6RRyfDtp7c_8sO60a-UT0-Y4S1_=D=M_mcLNN9g@mail.gmail.com> <CANXPkT4qYOYPL+F=-Pi_NbQErq9WwrR-M-BHe=gP9Ay4bSs+=w@mail.gmail.com>
In-Reply-To: <CANXPkT4qYOYPL+F=-Pi_NbQErq9WwrR-M-BHe=gP9Ay4bSs+=w@mail.gmail.com>
From:   =?UTF-8?B?7Jyg7Jqp7IiY?= <yongsuyoo0215@gmail.com>
Date:   Thu, 18 Aug 2022 21:55:43 +0900
Message-ID: <CANXPkT5=ryAFvb1cO+Wb0CQYmytwedS2dqVTYqt2Km1fkK4w9Q@mail.gmail.com>
Subject: Re: [PATCH] media: dvb_ringbuffer : Fix a bug in dvb_ringbuffer.c
To:     Hans Petter Selasky <hps@selasky.org>,
        Kieran Bingham <kieran.bingham@ideasonboard.com>,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
        mchehab@kernel.org
Cc:     0215yys@hanmail.net,
        =?UTF-8?B?7Jyg7Jqp7IiY?= <yongsuyoo0215@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Dear All,

Can you pay your attention to this patch ?
This is a very simple modification.
But, too much time has already passed since I sent the first E-mail.

2022=EB=85=84 8=EC=9B=94 3=EC=9D=BC (=EC=88=98) =EC=98=A4=ED=9B=84 9:04, =
=EC=9C=A0=EC=9A=A9=EC=88=98 <yongsuyoo0215@gmail.com>=EB=8B=98=EC=9D=B4 =EC=
=9E=91=EC=84=B1:
>
> Dear All.
> Too much time has already passed since I first sent this Email.
> Can you share how this patch is going ?
>
> 2022=EB=85=84 6=EC=9B=94 23=EC=9D=BC (=EB=AA=A9) =EC=98=A4=ED=9B=84 6:11,=
 =EC=9C=A0=EC=9A=A9=EC=88=98 <yongsuyoo0215@gmail.com>=EB=8B=98=EC=9D=B4 =
=EC=9E=91=EC=84=B1:
> >
> > Dear Kieran Bingham
> >
> > I sent E-mail again by Linux terminal by using the command " ... git
> > send-email .."
> > I believe that you will surely get the diff file.
> >
> > Thank you
> >
> > 2022=EB=85=84 6=EC=9B=94 22=EC=9D=BC (=EC=88=98) =EC=98=A4=ED=9B=84 10:=
12, Hans Petter Selasky <hps@selasky.org>=EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=
=B1:
> > >
> > > Hi Kieran,
> > >
> > > The consumed variable should not be negative. This bug has been there
> > > since the beginning of the GIT at Linux from what I can see.
> > >
> > > +1
> > >
> > > --HPS
> > >
> > >  From 108c6acb2cc4bc4314b96f6f254a04b2873a096c Mon Sep 17 00:00:00 20=
01
> > > From: YongSu Yoo <yongsuyoo0215@gmail.com>
> > > Date: Sun, 22 May 2022 04:53:12 +0000
> > > Subject: [PATCH] media: dvb_ringbuffer : Fix a bug in dvb_ringbuffer.=
c
> > >
> > > Signed-off-by:Yongsu Yoo <yongsuyoo0215@gmail.com>
> > >
> > > The function dvb_ringbuffer_pkt_next in
> > > /linux-next/drviers/media/dvb-core/dvb_ringbuffer.c,
> > > which searches the idx of the next valid packet in the ring
> > > buffer of the ca->slot_info[slot].rx_buffer at
> > > /linux-next/drivers/media/dvb-core/dvb_ca_en50221.c,
> > > has the following problem.
> > > In calculating the amounts of the consumed address of the ring
> > > buffer, if the read address(rbuf->pread) of the ring buffer is
> > > smaller than the idx, the amounts of the searched address
> > > should be (idx - rbuf->pread),
> > > whereas if the read address(rbuf->pread) of the ring buffer is
> > > larger than the idx, the amounts of the consumed address should
> > > be (idx - rbuf->pread + rbug->size). But there exists an
> > > incorrect logic that the rbug-size was not properly added on
> > > (idx - rbug->pread) in the later case. With this commit, we
> > > fixed this bug.
> > > ---
> > >   drivers/media/dvb-core/dvb_ringbuffer.c | 4 +++-
> > >   1 file changed, 3 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/media/dvb-core/dvb_ringbuffer.c
> > > b/drivers/media/dvb-core/dvb_ringbuffer.c
> > > index d1d471af0636..7d4558de8e83 100644
> > > --- a/drivers/media/dvb-core/dvb_ringbuffer.c
> > > +++ b/drivers/media/dvb-core/dvb_ringbuffer.c
> > > @@ -335,7 +335,9 @@ ssize_t dvb_ringbuffer_pkt_next(struct
> > > dvb_ringbuffer *rbuf, size_t idx, size_t*
> > >                 idx =3D (idx + curpktlen + DVB_RINGBUFFER_PKTHDRSIZE)=
 % rbuf->size;
> > >         }
> > >
> > > -       consumed =3D (idx - rbuf->pread) % rbuf->size;
> > > +       consumed =3D (idx - rbuf->pread);
> > > +       if (consumed < 0)
> > > +               consumed +=3D rbuf->size;
> > >
> > >         while((dvb_ringbuffer_avail(rbuf) - consumed) >
> > > DVB_RINGBUFFER_PKTHDRSIZE) {
> > >
> > > --
> > > 2.17.1