Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 18 Aug 2022 10:04:16 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Lu Baolu <baolu.lu@linux.intel.com>
Cc:     Joerg Roedel <joro@8bytes.org>,
        Christoph Hellwig <hch@infradead.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Kevin Tian <kevin.tian@intel.com>,
        Ashok Raj <ashok.raj@intel.com>, Will Deacon <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        Jean-Philippe Brucker <jean-philippe@linaro.com>,
        Dave Jiang <dave.jiang@intel.com>,
        Vinod Koul <vkoul@kernel.org>,
        Eric Auger <eric.auger@redhat.com>,
        Liu Yi L <yi.l.liu@intel.com>,
        Jacob jun Pan <jacob.jun.pan@intel.com>,
        Zhangfei Gao <zhangfei.gao@linaro.org>,
        Zhu Tony <tony.zhu@intel.com>, iommu@lists.linux.dev,
        linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v11 04/13] PCI: Allow PASID only when ACS enforced on
 upstreaming path
Message-ID: <Yv440MU1UeD9u67g@nvidia.com>
References: <20220817012024.3251276-1-baolu.lu@linux.intel.com>
 <20220817012024.3251276-5-baolu.lu@linux.intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220817012024.3251276-5-baolu.lu@linux.intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?VMqb7lKQ7AnhzcpMrxG4uy69h4utDzFE4AODr6KyF4OlExrps4drVRcL9ir+?=
 =?us-ascii?Q?Va/KSEVRBXHk59/SjqAojh+DDetR09MnFtpGmgD2wQs4hXE1h/My+xHalfk6?=
 =?us-ascii?Q?N9Ut7h2o3cNL6JAUS/cNxtJOF64Jmah/6erwUAcgrULOSGI3wbeZ7aoR2vcv?=
 =?us-ascii?Q?EcG+YrgOTjdm41R2mwICq4ZkEZmxbnvu4o9BY2Z2qLxEO9PWCVkGpFk7gabX?=
 =?us-ascii?Q?kRRGa0rxIE3j9D4xkm4Hy4sUStYiFi0dDRFlo33dQZf3Rdr/Iz6iOX2cCmsn?=
 =?us-ascii?Q?3aQFwQgc0NSHg4W5M+0Tw8G9+jUq7gT+jkWf03GR6tssuVQ3mwpk2XUj3SAK?=
 =?us-ascii?Q?eY/4CbiacFmiLEsA2nrhCR5vZ1oEC33KJgnsPLi8d7v6T5YDVmiWgy+GcqI+?=
 =?us-ascii?Q?eOEllGntbJoftVXm6fJnv8Dy31guPR/eIo31YXjBUDbMpvTz/s26R1sRxmln?=
 =?us-ascii?Q?oFQQS1638GUbQtc86Xulk1ooGtbWh2wpmCMmzekh1rMjmcX4AGX8eKjtg4GC?=
 =?us-ascii?Q?TtrupfEIdXziuAdawaZWvY258JBihhExJ94aq9YZ10qWY3UobeUrro8xATBJ?=
 =?us-ascii?Q?hytDFlfc98jFHkx6fr4YSDrTQi8LLvRfJxk6a8AeFxPIxFF8f5ZaRBWQfHyH?=
 =?us-ascii?Q?CyDT43GYQ8pPEqiu1xdhIjRZ3rSaPn0RvHgr7JzEsypej5WybhEPrgK9AXem?=
 =?us-ascii?Q?pgyNww2WkeBrQfuGEzvue0oI4vzwgz32ZDuqz00VgnDDXuW6LPdx4G4LJ9sL?=
 =?us-ascii?Q?4ar2gR51dOsYQpXCywymZY3dVwdQNsxfsoPDZUdCWeH455rQKkOVZWkNtyJL?=
 =?us-ascii?Q?kimFBG4Q7caeOuBgNcHaDh3xVYG8Df9KDQHGWuEeYEIH+aJbxcecTFDTwOa4?=
 =?us-ascii?Q?thq7U+LrlU3k/YHGCtuC+zydUdFA/fQ6X/cKNvlYWxDSAYt1kOpJJxpCtYN0?=
 =?us-ascii?Q?EbG6P942IuS4DgoIhJNyAuou0aODmKTL+tk4zJjFFbBk5mwzoyqijh6vC57S?=
 =?us-ascii?Q?X52O/m3yu1Z9SijaYbLazLTX3nSdV0BkK/E66xj3y0ZseP4R3/EVmFZVUbnd?=
 =?us-ascii?Q?7rYt4Or5lmGOL0ny1oLyFKuVvlFW8JYy3dI7ERmhppm3MzzDbNeagQrFYCrK?=
 =?us-ascii?Q?vg3DKVEj4DiBV8VGmETG0Qrcysty0fSkJCV4lQBa3NM5pS6noTc1q7WPuYOD?=
 =?us-ascii?Q?r33BtQX5dzM6mry4faDRDprSc9XTMorD+DDc9mQAp8R0dYwwmoGUxclrMLHa?=
 =?us-ascii?Q?+8JvUz1VVeOKlFB7Jw6wiWpEgXwPOskEfUdf3RtQpmZ/N8EY2qVFyjJObtFm?=
 =?us-ascii?Q?W+leT1bDSrSmSvaV3Mq08C5udtcvG0+UxhYt9+WrCapu26tiKBrADQQbDQsc?=
 =?us-ascii?Q?AQaHEJoTq+PPpoR2m+5IaEsSLQMEmvfmDhjmsvXQKq3DR7CsAoAMmXK4oUUR?=
 =?us-ascii?Q?hQAn2wZoXFhPac3BDK8s3hLJeVNdNk3TLZoX5RX7ENyuovRBlCkqewTIukgD?=
 =?us-ascii?Q?M4msXeHDX6g4R4Ve1oNKoQJ/ntkNirCXS94omXthBOAerKpj8Yzi89S7qUD2?=
 =?us-ascii?Q?InU/6Fle7f2loCeuu0MV7IX9eIJWtgSUMQy+0HdN?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dfbc4279-2f3b-4336-2408-08da811a2856
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Aug 2022 13:04:17.3543
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ER/k2LrFuSte8TzmPMAuUAP4FF8HiYQwn3FDT8MXnTRCXrKFIdTLgI8pOOlcVxNI
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB3172
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Aug 17, 2022 at 09:20:15AM +0800, Lu Baolu wrote:
> Some configurations of the PCI fabric will route device originated TLP
> packets based on the memory addresses. These configurations are
> incompatible with PASID as the PASID packets form a distinct address
> space. For instance, any configuration where switches are present
> without ACS enabled is incompatible.
> 
> This enhances the pci_enable_pasid() interface by requiring the ACS to
> support Source Validation, Request Redirection, Completer Redirection,
> and Upstream Forwarding. This effectively means that devices cannot
> spoof their requester ID, requests and completions cannot be redirected,
> and all transactions are forwarded upstream, even as it passes through a
> bridge where the target device is downstream.
> 
> Suggested-by: Jason Gunthorpe <jgg@nvidia.com>
> Suggested-by: Kevin Tian <kevin.tian@intel.com>
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
> ---
>  drivers/pci/ats.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/pci/ats.c b/drivers/pci/ats.c
> index c967ad6e2626..0715e48e7973 100644
> --- a/drivers/pci/ats.c
> +++ b/drivers/pci/ats.c
> @@ -382,6 +382,11 @@ int pci_enable_pasid(struct pci_dev *pdev, int features)
>  	if (!pasid)
>  		return -EINVAL;
>  
> +	if (!pci_acs_path_enabled(pdev, NULL,
> +				  PCI_ACS_SV | PCI_ACS_RR |
> +				  PCI_ACS_CR | PCI_ACS_UF))

I think we only need RR and UF here?

Source Validation causes the switch to validate the requestor RID in
each TLP which has nothing to do with address based routing

Completion Redirect changes how RID routing works, and has nothing to
do with address based routing.

Yes, both of those are usually set for virtualization scenarios but we
shouldn't check it here as a basic requirement to enable PASID.

Jason