Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp436364rwb; Thu, 18 Aug 2022 06:31:40 -0700 (PDT) X-Google-Smtp-Source: AA6agR7pRhptyXUfcQDcpRPA+5xug0ro9BuFkQFc0lOiFM62CAHXTx5CXRsh1329kPQ1MUPHoOMS X-Received: by 2002:a17:90b:1d02:b0:1f5:8526:303 with SMTP id on2-20020a17090b1d0200b001f585260303mr8909308pjb.79.1660829499999; Thu, 18 Aug 2022 06:31:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660829499; cv=none; d=google.com; s=arc-20160816; b=XMXcXLhQ1d3/Fq+8g3D4GvvXcoMCw8ULYCX9Bgaym7lvPFz8SdvBufQv2AKUwKRhOZ 6FgWhdHwUWRYL/6KisWK7P/EQQxGcUXFWoEGlyxR7+4gs0QaYgmkM0hZ/AC6fURxcv/8 +OPkhRqfO1Wnj5D/ndPpmqZuEzX8Rg1eRQSfMNQ42t7u9jnF2gGqQTc/qKtFp/eMQXwz KRtH417yHSSBMbL6AFmUH/mjByEAdKvLc5HkaLj47RothiHXI2Sqlo2lMQ353ViW6Iad kfr1pYd1OTIplvRk140MmGy4R8eLfLSE+GCZZ6Ze/MQfLMqtKSSi0aCmNcmpX3A9uw6x SGNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=7Jvb9VTNTGyJevS3lgNMgSmphDuDuYli74EbuMld70M=; b=srHDdsCqMRUdx//FLgw2ZlwPTi48NhqGguQqlBjwBdu4NBOBWV+kPUxvF/8ur/CyXl JvOUFrpFA0Q8W/xMDQZ/qvt06RkgUg4XNcq113xIXcWJSUeAOYISGYX3YqHoozoM3Iql FEH7fEysBcjyyBV3fyKsrUinyVAuolui6rWu7HpjBAS2bi3VoDn16wSs2pNmqOTyZF6C BmhIgSq3aR+4QS/AQyhOjSibK6sUN86NIwpN3KbnO8+GEZXM1vC8G63PPdwK0iecVa1W I4RyixxgD29yVlrZ+yk3p+lv8GvzsYiThWb5y4IVw2Z5fd81pgF7c9YBy/AMmxFOH3fy Sgzg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=vJRAhCjx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j38-20020a63fc26000000b0040d7ac04fafsi1530101pgi.36.2022.08.18.06.31.27; Thu, 18 Aug 2022 06:31:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=vJRAhCjx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245026AbiHRNX4 (ORCPT + 99 others); Thu, 18 Aug 2022 09:23:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242702AbiHRNXu (ORCPT ); Thu, 18 Aug 2022 09:23:50 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B35E15FFE; Thu, 18 Aug 2022 06:23:48 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AE31D6153A; Thu, 18 Aug 2022 13:23:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 58B2FC433D6; Thu, 18 Aug 2022 13:23:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660829027; bh=7Jvb9VTNTGyJevS3lgNMgSmphDuDuYli74EbuMld70M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vJRAhCjxfceD0/NRdpH1rqi3S9qlJKifQfmcF0Qojaje3rJ+Zc4mlYEP17mKisiL3 rUnXKoskTQ4OPazWMfmsvCMTJ6W72qcQUf3DBqtGpJXZQBUFxUPmqoK9iiEvbySh7c ikr7l5/4FuUrY7yv9iSSqsn17N57qEtJ3XXhYswTfM+VXPE7oN18CChPr7vm+7ohBZ 6RFZoFIJxSedXUlZJowCGCEpgMfKx06YXs1nKcanpUyr9JA/bsJntdaeqlcWFv/5fg n7GvHEr3/lYueiSjBdobJ6zpLwXyvCaLt+f9H6WWR7oR8Mumxgb3IyxEjUBqTxjk7l JodKLTToJxIXg== Date: Thu, 18 Aug 2022 14:23:42 +0100 From: Mark Brown To: Shreeya Patel Cc: sanju.mehta@amd.com, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@collabora.com, krisman@collabora.com, alvaro.soliverez@collabora.com, Lucas Tanure Subject: Re: [PATCH] spi: amd: Configure device speed Message-ID: References: <20220817131809.312533-1-shreeya.patel@collabora.com> <3e2a0f50-c396-5af6-5cbe-303978378587@collabora.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="wpON6ygzczDYYJtZ" Content-Disposition: inline In-Reply-To: <3e2a0f50-c396-5af6-5cbe-303978378587@collabora.com> X-Cookie: Logic is the chastity belt of the mind! X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --wpON6ygzczDYYJtZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Aug 17, 2022 at 07:40:31PM +0530, Shreeya Patel wrote: > yes, the code is actually configuring it to use the frequency which is > strictly less than the requested one. > I just didn't use the correct words. I will make the change in commit > message for v2 once you review the patch. Please just resend with a fixed commit message, I'll only have to review it again anyway when you resend. --wpON6ygzczDYYJtZ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmL+PV0ACgkQJNaLcl1U h9BEBwgAhIXtiH5DF+MI83yuJvAokOdJxz4J+febdaSBzNrTECfN7mr7moYpsmyT JzKCQubxRAPeFRStvx47bB2cbLiNCLZmXDq+bfxd87vPLGOmRhxsmkQAwTB40NeB +m/ToXHS65FsMZo2Z1zDAE/3BtTW6VkQFoMXzw6xUlokN2yFHekhLMj2zSLsbpK4 cGt+HX+AVu5LE/KvDqm73mBnDnVZ4MV1IWCqChFielHqbx+YRfmCPp/HNMkCFFar x3GNngih9khR+FRAv7heZH+Wuj2fFbO/IA5eIQ9nCr6Rd0Dh8XMLFSB8Io8Jmq6Z Z0lWGLNIMzNcdm/tNM5SfS3Gtbz7Uw== =nDTc -----END PGP SIGNATURE----- --wpON6ygzczDYYJtZ--