Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 18 Aug 2022 15:08:14 +0200
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Dario Binacchi <dario.binacchi@amarulasolutions.com>
Cc:     linux-kernel@vger.kernel.org,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Amarula patchwork <linux-amarula@amarulasolutions.com>,
        michael@amarulasolutions.com, Dario Binacchi <dariobin@libero.it>,
        linux-can@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [RFC PATCH 4/4] can: bxcan: add support for ST bxCAN controller
Message-ID: <20220818130814.z7b4rvmld6wvk4fg@pengutronix.de>
References: <20220817143529.257908-1-dario.binacchi@amarulasolutions.com>
 <20220817143529.257908-5-dario.binacchi@amarulasolutions.com>
 <20220818103031.m7bl6gbzcc76etig@pengutronix.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="dtkjkszqd6mas3zd"
Content-Disposition: inline
In-Reply-To: <20220818103031.m7bl6gbzcc76etig@pengutronix.de>
Precedence: bulk


--dtkjkszqd6mas3zd
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 18.08.2022 12:30:31, Marc Kleine-Budde wrote:
> One step at a time, let's look at the TX path:
>=20
> On 17.08.2022 16:35:29, Dario Binacchi wrote:
> > +static netdev_tx_t bxcan_start_xmit(struct sk_buff *skb,
> > +				    struct net_device *ndev)
> > +{
> > +	struct bxcan_priv *priv =3D netdev_priv(ndev);
> > +	struct can_frame *cf =3D (struct can_frame *)skb->data;
> > +	struct bxcan_regs *regs =3D priv->regs;
> > +	struct bxcan_mb *mb_regs;
>=20
> __iomem?
>=20
> > +	unsigned int mb_id;
> > +	u32 id, tsr;
> > +	int i, j;
> > +
> > +	if (can_dropped_invalid_skb(ndev, skb))
> > +		return NETDEV_TX_OK;
> > +
> > +	tsr =3D readl(&regs->tsr);
> > +	mb_id =3D ffs((tsr & BXCAN_TSR_TME) >> BXCAN_TSR_TME_SHIFT);
>=20
> We want to send the CAN frames in the exact order they are pushed into
> the driver, so don't pick the first free mailbox you find. How a
                                                                 are
> priorities for the TX mailboxes handled?
>=20
> Is the mailbox with the lowest number send first? Is there a priority
> field in the mailbox?

I just had a look into the data sheet and it says that the TX mailboxes
are handled in transmit request order. This is good.

[...]

> The mcp251xfd has a proper hardware FIFO ring buffer for TX, the bxcan
> probably doesn't. The get_tx_free() check is a bit different. Look at
> c_can_get_tx_free() in:

This means you can use the simpler get_tx_free from the mcp251xfd driver.
>=20
> | https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/comm=
it/?id=3D28e86e9ab522e65b08545e5008d0f1ac5b19dad1
>=20
> This patch is a good example for the relevant changes.

This patch is non the less a good example for the TX path.

Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--dtkjkszqd6mas3zd
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmL+OboACgkQrX5LkNig
0111dwgAsKHBnsZaWy6rH4/lkSd7m7BsivcwGcyfFO0SqgkUt/hKtV9luwypGM5y
0EpYLPJJDxJyZHtcv9Xc65ceMWYAu/KrodPF9gYvHdPusZLer42UZX7OSCZjRKg/
rg5QNEmMSFGsaXuOV13F2vkdUgCHqO+RMQzA1QkrCWXfGBfP8KEOBEyGkWRBWV3B
EOiXp+XK1KLoHTD7cCCh0usmj+OqTc98mntbSq92UUB6UQph0PecyrNYU07PIvAW
bZ9zoUdVC/0aAEGLHWY3pUXj7/nj8GxUiLCQiPH+Vvv+xYT2pe1kHpMWL7qp03WH
NIfB5M8Vu2g7sAF39XW6q0VdHXTu0g==
=JlUx
-----END PGP SIGNATURE-----

--dtkjkszqd6mas3zd--