Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Marc Zyngier <maz@kernel.org>
CC:     Lee Jones <lee.jones@linaro.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        Arnd Bergmann <arnd@arndb.de>,
        "Z.Q. Hou" <zhiqiang.hou@nxp.com>, Biwen Li <biwen.li@nxp.com>,
        Sean Anderson <sean.anderson@seco.com>
Subject: Re: [PATCH v4] irqchip/ls-extirq: fix invalid wait context by
 avoiding to use regmap
Thread-Topic: [PATCH v4] irqchip/ls-extirq: fix invalid wait context by
 avoiding to use regmap
Thread-Index: AQHYopBXddIttVt6zkGyOalTC33MGK201CiA
Date:   Thu, 18 Aug 2022 14:13:13 +0000
Message-ID: <20220818141309.ifl3kddmxojqc2jl@skbuf>
References: <20220728144254.175385-1-vladimir.oltean@nxp.com>
In-Reply-To: <20220728144254.175385-1-vladimir.oltean@nxp.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Lc2Zm1FZnFZsZsiWHwjQBNCnqJmUaaUitEJ0eRKT90ItMrOmawRWTDBqEAVo?=
 =?us-ascii?Q?rPf8nziHFI3Igv7lopmrI4GXuCg6sxOXzUhEV1tH7IzuhCBymYdietLAqHYa?=
 =?us-ascii?Q?gTGNWzEHS1b2JyQyMonKYT9dbVDFdJ2FehcBzzfZ4hU2QGouDwgJyCXAbuux?=
 =?us-ascii?Q?AZWidyjYMCr/DZTaq7q24DQF7OJGdcNlTdomGVpS2RGcqdALvsGNKspp3IVW?=
 =?us-ascii?Q?0kPEaAEvMuTGuKdJkuDd22x9ahpdjq3YIma4DByXjklB3hl32G94isHGpq/l?=
 =?us-ascii?Q?Zgm8Ronz2UStoyQfXV2O55/IFVnmiq+F1nzlXx6meul68xzzu4aDToQCayEq?=
 =?us-ascii?Q?w0ydEUARS36nXWTSZcE5+tdrQyM4o0ZzWuixuIB0eSLoLywR04mPF0AcrvJO?=
 =?us-ascii?Q?sglwvhyp5w09FmWQH/c0WZIxaYGjoTBRaR3so481GOeL80ikkY34oPBMGj82?=
 =?us-ascii?Q?1e8Sqdh1dcrD2+VIMJ2hv5jY6OhhvvojLnQaRl7V6m9hqIvCJOtN6ntqU8a0?=
 =?us-ascii?Q?AZmGZ5Nr8CTCDkVj48T1kVjWODJ7He+/xXNnAjT9OkKv5ffuAOVc+VA0WXWa?=
 =?us-ascii?Q?rbWcCT99Q/JQM67HatswoCbav3RbrcAYV4qdsuYMHxYIRXPaDQ1muugbXJ+n?=
 =?us-ascii?Q?am18eIW7MmBmeiyK9UJ59i3FnG/MtimE541QydTE7A16IbicXUsOiW8WeIsL?=
 =?us-ascii?Q?92OugbIzSFnErLweoN8+unMJLbS9YculZM0C+I/H3vy1qr39oxSxvIsniljo?=
 =?us-ascii?Q?MAW8CjTECYRRcNeqNhpMipidapNwhxhPvUmN80rdMhQ25ZzFWr52L/pQfh/u?=
 =?us-ascii?Q?IF1P1M+vBE7TcjmyZFJmLRjKbYjOV8PQmcdoA7U/65eNfhSqrjJbp50zYdLM?=
 =?us-ascii?Q?g1RshisoIXl81meZKHqGGNnjERnVo6H14y0H6Sv0Orn7rqPaqZMJg183EqrO?=
 =?us-ascii?Q?O7uZJ435DasMSvYoBpIhpQrCevDAkeYsF6Y8/aAM5Mt0cbalClWK/MilmSzC?=
 =?us-ascii?Q?3X4FUG3vvAn3uEhKmWRayMlP2huCqvOY03HodnCwlLsQwBXVMqN9lChL03Va?=
 =?us-ascii?Q?ApO7zM7FjnzyUL74dHHrK4d6O5B70gC8DnhMjhNelMpgC2gCNgl39z1Mihrt?=
 =?us-ascii?Q?m5aO8ZetYPzXbGnTW8D+nDr+mQAJ7cYuSbh+Khd22Vu1Hf5netUA7UPPIYWy?=
 =?us-ascii?Q?TvaBcvGrzLbzjzLgBuhoS+gbDaQalpl4OC35ZlV9ox9bapGWHt1xvm0YmgM8?=
 =?us-ascii?Q?9TwWO8z08vztDVy/dSQqNsn1qACvMiHT+PrjAAFKXR6FiLPtnea3vrp0Xowy?=
 =?us-ascii?Q?vS8ENgrNhTbVeaQwwhwU+OxKranTzICvUnbtS/eS8Td8VaeH9DnemUc2AGRB?=
 =?us-ascii?Q?TG6yio8swgGETjgvsdrFTzFgglg8FOCPRNLdGXTf1SoBkKQMMyk1LtqAe6ua?=
 =?us-ascii?Q?n0n3YOGlXQE32d4GpH3VUwz6t1Mm82qpEj1iHyGA3iLwX7E/ze6tEqMmw6F1?=
 =?us-ascii?Q?k1iB7Ew5uNEapMOij/wWfeU/+HlaWxosDnKF3G4bQkGCERCUkGv13shrtixz?=
 =?us-ascii?Q?p2e/dGyMlGGXPIhdoyhM2ycHFGg39OdJ0DplZV+T1BM3y6REHamz3tuja01D?=
 =?us-ascii?Q?0g=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <606E61399BF8AD48A82A091CF8545209@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 09dd29bb-a011-42bb-7b17-08da8123c995
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Aug 2022 14:13:13.1576
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: vdyF6juNWY2YJhvujSrQ+aL6VNoh/64ygbEI3O+6xkiDgf3wl6LmxGThpezVs8mQpY+utz69KtoavPahmRyp7w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7904
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

On Thu, Jul 28, 2022 at 05:42:54PM +0300, Vladimir Oltean wrote:
> The irqchip->irq_set_type method is called by __irq_set_trigger() under
> the desc->lock raw spinlock.
>=20
> The ls-extirq implementation, ls_extirq_irq_set_type(), uses an MMIO
> regmap created by of_syscon_register(), which uses plain spinlocks
> (the kind that are sleepable on RT).
>=20
> Therefore, this is an invalid locking scheme for which we get a kernel
> splat stating just that ("[ BUG: Invalid wait context ]"), because the
> context in which the plain spinlock may sleep is atomic due to the raw
> spinlock. We need to go raw spinlocks all the way.
>=20
> Make this driver ioremap its INTPCR register on its own, and stop
> relying on syscon to provide a regmap. Since the regmap we got from
> syscon belonged to the parent and the newly ioremapped region belongs
> just to us, the offset to the INTPCR register is now 0, because of the
> address translation that takes place through the device tree.
>=20
> One complication, due to the fact that this driver uses IRQCHIP_DECLARE
> rather than traditional platform devices with probe and remove methods,
> is that we cannot use devres, so we need to implement a full-blown
> cleanup procedure on the error path.
>=20
> Fixes: 0dcd9f872769 ("irqchip: Add support for Layerscape external interr=
upt lines")
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> ---

Just checking in on this patch to make sure it hasn't been forgotten.=