Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220812061805.88627-1-dzm91@hust.edu.cn> <20220812061805.88627-2-dzm91@hust.edu.cn>
 <Yv5VkNvk6CDBFgNK@kroah.com>
In-Reply-To: <Yv5VkNvk6CDBFgNK@kroah.com>
From:   Dongliang Mu <mudongliangabcd@gmail.com>
Date:   Thu, 18 Aug 2022 23:15:22 +0800
Message-ID: <CAD-N9QUO9i0rkUGu_buBLSkFaTvvHp69ynkP30kEcmCRDDQg8A@mail.gmail.com>
Subject: Re: [PATCH v3 2/2] USB: trancevibrator: simplify tv_probe
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Dongliang Mu <dzm91@hust.edu.cn>, USB <linux-usb@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Aug 18, 2022 at 11:06 PM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Fri, Aug 12, 2022 at 02:18:02PM +0800, Dongliang Mu wrote:
> > From: Dongliang Mu <mudongliangabcd@gmail.com>
> >
> > The function tv_probe does not need to invoke kfree when the
> > allocation fails. So let's simplify the code of tv_probe.
> >
> > Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
> > ---
> > v2->v3: fix the truncated subject of PATCH 2/2.
> > v1->v2: no change
> >
> >  drivers/usb/misc/trancevibrator.c | 11 ++---------
> >  1 file changed, 2 insertions(+), 9 deletions(-)
>
> Note, I would recommend you work on basic "clean up" patches in the
> drivers/staging/ directory so as to get experience on how to submit
> patches properly before working in other parts of the kernel tree.  That
> way subsystems that don't normally take "cleanup" patches don't get
> bogged down in basic patch-process issues like this one did.

I see. Thanks for your suggestion.

>
> thanks,
>
> greg k-h