Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp585608rwb; Thu, 18 Aug 2022 08:43:24 -0700 (PDT) X-Google-Smtp-Source: AA6agR546Xk/rwDRW5cOY2e1GSW56KuTDUGwjDgOtTdJbxVjOqLhO9J3OjmnEkU3Va4Hn8Fhe3O/ X-Received: by 2002:a17:906:93e8:b0:730:9e5c:b45a with SMTP id yl8-20020a17090693e800b007309e5cb45amr2170737ejb.530.1660837404741; Thu, 18 Aug 2022 08:43:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660837404; cv=none; d=google.com; s=arc-20160816; b=BG7jSEhnT5XrYogI0/cBTtNyUPSx7SGIGOy2WtRZxdMc+Sc61IbhRaZXHEcIALzzEw 0tJ0KMWN61fr4ifZNIbeoMdeixGtj6QhbIB0cl38bbSM7z/+KknibfdehAor0SG+r+it hEdrszt/Fz5DnJf45N+uUbZfpKKNRDUsmqDmewhayRJrHOFP5g1jkKm3Dhd3LqCpEW9O 9PRAWdzdesYpylDNorxCD5TmQLA8SJDamjJWAjAipuzvPLWsg3JMfAnycvfEj5L9tlVK ha0B81mINT4Mb6vkbSJi6W+12AG2fntTzzmc72gGz2ecNymBhtsVjvgemuG7J2Ptlqlb jyCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=uyozQI3UEo6Plv2DnbvjiyT7gwfcH5+1vUvyMnT8P9M=; b=gn3xMt58MpnsJQpQIivfCOGm9z8UPDuiUj18b/N8MKX1GtW25ZXe4ASlYva7OmX5iv RRzx42voMDbZomdownj1PsaXMQoDPtxyBW15q2CSeAnBtvcoI3W+ZjtXSY9pIxq/NRLE EEIGpmrRasAVoccFlGz4Of4F4GN/g3s6rBqMEvynrB1mXfTnTu4dq/MLVntR9KBNzi2B vfXK9sb+tMytca7QDItxZd3MEAx/1JASPsjwkqFb31UAn012kwXuobdKlZfgkp5ZgJ78 zwWTkuLCAyBM6pZGHT1uLii813+0KTdIMPVkhEXmFh0ld4+CMjjtHEbrrGhGM1idSFuz BEAQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=VMDbJXG3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g15-20020a1709065d0f00b0072f40d666d6si1387568ejt.602.2022.08.18.08.42.58; Thu, 18 Aug 2022 08:43:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=VMDbJXG3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344060AbiHRPHJ (ORCPT + 99 others); Thu, 18 Aug 2022 11:07:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37780 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344113AbiHRPHG (ORCPT ); Thu, 18 Aug 2022 11:07:06 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 805D19C53D; Thu, 18 Aug 2022 08:07:00 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 142526135F; Thu, 18 Aug 2022 15:07:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 20718C433D6; Thu, 18 Aug 2022 15:06:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660835219; bh=WkrNCbKYD3xZKpJJ81qL8Xck1IuTybQeeZNEiImLgSQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VMDbJXG35jSoumiaoCsmU82g7/aLhi4RiQpct4YTnPDkJaqqXE4mYRFxCzn4ruLzL 8AHcJr1atGYjPOo28gFL4fz2xH6p0aLhE67gJGgVfq87WuDI7EDyhFy6Xe15zvM6Zt esN+nxXBVuQNKf7tqC2jLC7cwwd2qHtT5b+79LKI= Date: Thu, 18 Aug 2022 17:06:56 +0200 From: Greg Kroah-Hartman To: Dongliang Mu Cc: Dongliang Mu , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/2] USB: trancevibrator: simplify tv_probe Message-ID: References: <20220812061805.88627-1-dzm91@hust.edu.cn> <20220812061805.88627-2-dzm91@hust.edu.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220812061805.88627-2-dzm91@hust.edu.cn> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 12, 2022 at 02:18:02PM +0800, Dongliang Mu wrote: > From: Dongliang Mu > > The function tv_probe does not need to invoke kfree when the > allocation fails. So let's simplify the code of tv_probe. > > Signed-off-by: Dongliang Mu > --- > v2->v3: fix the truncated subject of PATCH 2/2. > v1->v2: no change > > drivers/usb/misc/trancevibrator.c | 11 ++--------- > 1 file changed, 2 insertions(+), 9 deletions(-) Note, I would recommend you work on basic "clean up" patches in the drivers/staging/ directory so as to get experience on how to submit patches properly before working in other parts of the kernel tree. That way subsystems that don't normally take "cleanup" patches don't get bogged down in basic patch-process issues like this one did. thanks, greg k-h