Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Asmaa Mnebhi <asmaa@nvidia.com>
To:     Wolfram Sang <wsa@kernel.org>
CC:     Wolfram Sang <wsa+renesas@sang-engineering.com>,
        "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Khalil Blaiech <kblaiech@nvidia.com>
Subject: RE: [PATCH v1 4/7] i2c-mlxbf.c: incorrect base address passed during
 io write
Thread-Topic: [PATCH v1 4/7] i2c-mlxbf.c: incorrect base address passed during
 io write
Thread-Index: AQHYscMo59o17RgFDU6O7GkYAYNjea2020kAgAADfQA=
Date:   Thu, 18 Aug 2022 16:40:53 +0000
Message-ID: <CH2PR12MB38951132E24E6F1EDCCD18C6D76D9@CH2PR12MB3895.namprd12.prod.outlook.com>
References: <20220816225412.9095-1-asmaa@nvidia.com>
 <20220816225412.9095-5-asmaa@nvidia.com>
 <20220818162728.lnq5y7qzxbdsyexr@the-dreams.de>
In-Reply-To: <20220818162728.lnq5y7qzxbdsyexr@the-dreams.de>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?2NbqhvUosvph9S0Qs4oLy53ZiPQWrRUCg3Ieoykm2Txudm80p5Vq94dAurUZ?=
 =?us-ascii?Q?X38CxiNwWwSHicdmf+bbdRov3quUZp+ssmh/+VtEVsofF6JtagCDAsesQv3Q?=
 =?us-ascii?Q?nxDBSb39wmv45GvJT76mDNQuMDfrRKbTDQYQreQJ9SsKro9CB0Pb9ncbM1je?=
 =?us-ascii?Q?dZ8YpkOF6mD1uvKUnjkfdVt88m7w2l6RNx5/9tl0ShMT6LoCGwfocc1CMd1c?=
 =?us-ascii?Q?lPGLxB9CPwe4vTeMxorDPPULnr0q3+4hP9T5tdGACIV0FbioPiOyntX9cmRJ?=
 =?us-ascii?Q?xNK9wpkY5DenLycb9IhJ3R33Ae5SerzX+NT2KPRSAHFMqJb8kxEPDDqtrnu0?=
 =?us-ascii?Q?tHJUmKTZfHsobXbDVZRomguPONjshgA7y0PmapnFACJ0G66W9osZHOSot8Y+?=
 =?us-ascii?Q?yTKU5P3Kz4KIzeAWuM71E7WrH7r2tcjiZ+S22ZL/hVI2oQNG6k1U8+zl9Nf6?=
 =?us-ascii?Q?Ebpf3uIpwtVI8bfQ+NWXefrxgmOMV9Igm0hHvFTgLpgRisFgOdqmKmiVvF6U?=
 =?us-ascii?Q?BpnyJtPaRg85cxvFP/aScp5zGAzmFvT8pjU5QGA9mMfpSYvvzPRa60HfxLqb?=
 =?us-ascii?Q?zeXyukFlJzicQS4lmmvIxnLBVZvDd1vdpap8Mu9V5Yshkh0gbZJcTTBSVfVk?=
 =?us-ascii?Q?Bo9rVU/Bt7hDtZB+l4MXw0Xd8DeHacXEyXLew4kqDTv6pqA6Jqimh5Nqs+cC?=
 =?us-ascii?Q?VlUBBRhy6kCfsuyQI5J2ZwLyat8hnS1l5dE4QjZN6UVmJuiP04ryLAX9ksZT?=
 =?us-ascii?Q?3YegFCO2kPI1LuwDs+RhvsCEBpZ+VkWc96bot5qkA8WPZeZ5ENvygqhKw70f?=
 =?us-ascii?Q?aKBPfaAqHT+fSo1LvCRg9EZdwtBfJkSkKVe6VljPpRZyA5iBq9lafItdzEWD?=
 =?us-ascii?Q?6YgdDu7jhiAYCfaxGxlnYcRVL2Jqbn6UgdUE13Zgx8RqShGQ2iqit9PdE3cQ?=
 =?us-ascii?Q?Yin3FPWsU5dVJaSEK8+GV135PVj4j0xC9MpE+2H32LsCapj6caHG4o+iRBZQ?=
 =?us-ascii?Q?SItH1MkERlRTkXb+OvYBJsmiNYHU1v9v+g4qkwfrDEdxB/jf/ADv4pvZe0me?=
 =?us-ascii?Q?Wl/oCLqP7QVXgTHwVu+no/5kM/8e5eZwJDTCUppcrLOljspK5cmkjEzY1pLA?=
 =?us-ascii?Q?bDqUkIP+/QvamS2abTy+4eFpoI36GQcU1Y8aPzdhZtAqjfxz0MuKUBVNRcmO?=
 =?us-ascii?Q?0ppgnm0tpxu+Y10wU5pXkxPlBQhr3uzTNSbY2SUvl7oyY79m8pzTSbBsZNdh?=
 =?us-ascii?Q?xeFes78QofUKDMXIxsCxN1/Ezk9fGq6K487JAIVTfrDlPrUaiVkYb782qGB1?=
 =?us-ascii?Q?PrUJq+1IHcJrPbEeOWSUz1Y1feelP+C7aUu+XoO6tYVzB4MSPisqUvGPjJnw?=
 =?us-ascii?Q?qt7gzia/SKFfgL3ULK/HiHIkI9O+XHyrONSPPrDG+89C/oaTo78qVOisTPVo?=
 =?us-ascii?Q?GUX3XVlOszXKwgT+M32lCgacjNWWidHL34GAdnnonZZukPn7DLyPo3qYY9Ck?=
 =?us-ascii?Q?B8k68LVw8CHjxyaS5dNhoTT7AgOxXDY3VZrz5VrqANZ86mYJBPDZ1eCzd82d?=
 =?us-ascii?Q?g7YNzjQJNbjdNvtOgl8=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3895.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1111da6e-1ec9-4205-85f4-08da81386af4
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Aug 2022 16:40:53.8283
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: B9EvXdIAczvZPvpFAhdAeEqAowczBNz60Jib/4c9PtvcLU7Ve2c8SJV4xt5E5AKVaBYFTfI4KjUha59g275Ntw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB4675
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

It only worked on our first generation of BlueField (and we were lucky I th=
ink), not in BlueField-2 gen.

-----Original Message-----
From: Wolfram Sang <wsa@kernel.org>=20
Sent: Thursday, August 18, 2022 12:27 PM
To: Asmaa Mnebhi <asmaa@nvidia.com>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>; linux-i2c@vger.kernel.=
org; linux-kernel@vger.kernel.org; Khalil Blaiech <kblaiech@nvidia.com>
Subject: Re: [PATCH v1 4/7] i2c-mlxbf.c: incorrect base address passed duri=
ng io write

On Tue, Aug 16, 2022 at 06:54:09PM -0400, Asmaa Mnebhi wrote:
> Correct base address used during io write.

So, the driver never ever worked? Or were we lucky that it worked somehow?

>=20
> Reviewed-by: Khalil Blaiech <kblaiech@nvidia.com>
> Signed-off-by: Asmaa Mnebhi <asmaa@nvidia.com>
> ---
>  drivers/i2c/busses/i2c-mlxbf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/i2c/busses/i2c-mlxbf.c=20
> b/drivers/i2c/busses/i2c-mlxbf.c index 39051c4a6db2..02ed6983c35c=20
> 100644
> --- a/drivers/i2c/busses/i2c-mlxbf.c
> +++ b/drivers/i2c/busses/i2c-mlxbf.c
> @@ -655,7 +655,7 @@ static int mlxbf_i2c_smbus_enable(struct mlxbf_i2c_pr=
iv *priv, u8 slave,
>  	/* Clear status bits. */
>  	writel(0x0, priv->smbus->io + MLXBF_I2C_SMBUS_MASTER_STATUS);
>  	/* Set the cause data. */
> -	writel(~0x0, priv->smbus->io + MLXBF_I2C_CAUSE_OR_CLEAR);
> +	writel(~0x0, priv->mst_cause->io + MLXBF_I2C_CAUSE_OR_CLEAR);
>  	/* Zero PEC byte. */
>  	writel(0x0, priv->smbus->io + MLXBF_I2C_SMBUS_MASTER_PEC);
>  	/* Zero byte count. */
> --
> 2.30.1
>=20