Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp668870rwb; Thu, 18 Aug 2022 10:04:25 -0700 (PDT) X-Google-Smtp-Source: AA6agR4jjn8bYQgqkh8TX9W00j6Og2O+rO3ScszlO68k5eDvw0Spai11UNWDHxU2/4/oPgGrtvkH X-Received: by 2002:a17:90b:1c85:b0:1f1:d78a:512b with SMTP id oo5-20020a17090b1c8500b001f1d78a512bmr9627480pjb.92.1660842264853; Thu, 18 Aug 2022 10:04:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660842264; cv=none; d=google.com; s=arc-20160816; b=kVMbeMxZ7rlueNOOi1e1WICRr3zzSj9oWFEBK6mgNq+FGRkkfkkHSE06qQSUlc0EzO uywLbeIfhrC4E4S7liegYSnO+UQ9NhLWO28kYotFEP3Bio5DE2+6pt0Rn6iuKWhIDXUl qqfqVJKJFeON4vIEWMl9AX2iWew+ZbOyyl+YKt/gdLMjRyjlncDMNs0chsC952I7/xMF yxkKkcg8jnfj70ERuGNSXA11DY8SocPJkRNypFQA7k8gf6Xe6JewXsakrRyHBfNYUpBo uTBkEcdxmwYZ6j33ugeuo6pWEYacnD2YuFaihuYmMVXWQpuOC5Hs689TWkMWfNa/OC0w /8PA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:dkim-signature :dkim-signature:date; bh=eRWjvTJioZag0NL+kWuQAJgjY2OnnzM0BJxuNTpvQzY=; b=jz/xJYtBDj1xG5hj7fUwMFRTU0YG41gZ8NsTR4HngdNATJaUFAdbfb3ux0fuGKNBbS KAGfuT5hAXEMqYkexdHZxCIZ43Kb2SKVuYj07yeDX+9A86F7Wx+kNEr0pd/M+owhueYu zv74642p5qBDQxVhYEP+LKNkv/PTdbWTenLPDWU8wrdVtWsrPu0GV0HLrdGBOgDYXJv+ fPkv6HBDl4XR1GUTksP3vlty62eSWJIXk7m1d77FKfqI9tdABqz64phyK7JSuchZEFlp kMwtvjlNBJif0go0yi0v1pUaBiG47+6ozHKGBqM6M1Vi1SijMzHpEL/FEwjUPpsdlMyg D5GA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=mbGcKzxS; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=aRiygy3j; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p20-20020a635b14000000b00428bf1f3c67si1826615pgb.861.2022.08.18.10.04.05; Thu, 18 Aug 2022 10:04:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=mbGcKzxS; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=aRiygy3j; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344812AbiHRQcs (ORCPT + 99 others); Thu, 18 Aug 2022 12:32:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344800AbiHRQck (ORCPT ); Thu, 18 Aug 2022 12:32:40 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C09B72856; Thu, 18 Aug 2022 09:32:39 -0700 (PDT) Date: Thu, 18 Aug 2022 18:32:37 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1660840358; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eRWjvTJioZag0NL+kWuQAJgjY2OnnzM0BJxuNTpvQzY=; b=mbGcKzxS+qB5xSvStj9dpA9H4TOAHWwkS1PTIqeQyi2gsgd2a/Fb/UgemvsAhSPd0chOZb GKXKABd84cUonoMmt/8mVioyyO3FcHeMg13E6VXdNtsHzXdBECS0ZMl7VsoxP6o2W/aH3o boGHcBh52ve9rGMGFwg9zZfH+SDuD2zBEHyxw/BqwYjVYhEXXWIQzMqqqLk78MOhrDEWmu wlnvvGwv+ZlkKFt49EaDnTQ0qb/EPVdo0SSZ/hGUzaXyA1Kxc7A+g+HVDr3c5zPdVFptX6 UQ4UVPC9xirjNFQKH1kCCvGOBZOpjxdfreFuuPIE0PnfP9j8iNa8nZyQR16Rlw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1660840358; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eRWjvTJioZag0NL+kWuQAJgjY2OnnzM0BJxuNTpvQzY=; b=aRiygy3jAMbToG5V+llK9UZ2dRmLzGWkArvNLdtFSKyqqr5UU53FvgpUBMrCZNWNt4LzSp qMaJGAiAxXxNj0BA== From: Sebastian Andrzej Siewior To: Yajun Deng , "Luis Claudio R. Goncalves" Cc: peterz@infradead.org, mingo@redhat.com, will@kernel.org, linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org Subject: Re: [PATCH 5.10-rt] locking/rtmutex: switch to EXPORT_SYMBOL() for ww_mutex_lock{,_interruptible}() Message-ID: References: <20220803062430.1307312-1-yajun.deng@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220803062430.1307312-1-yajun.deng@linux.dev> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022-08-03 14:24:30 [+0800], Yajun Deng wrote: > We can use EXPORT_SYMBOL() instead of EXPORT_SYMBOL_GPL() in > ww_mutex_lock_interruptible() and ww_mutex_lock(). That match > ww_mutex_unlock() well. And also good for 3rd kernel modules. Not that I am fan of this but it will sync the symbols with what landed upstream as of commit f8635d509d807 ("locking/ww_mutex: Implement rtmutex based ww_mutex API functions") therefore it would be good to have. Luis? > Signed-off-by: Yajun Deng Sebastian