Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <62e6d510-8e7c-8a31-fb7f-905bb13afe67@nvidia.com>
Date:   Thu, 18 Aug 2022 22:31:03 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH v6 5/5] vfio/pci: Implement
 VFIO_DEVICE_FEATURE_LOW_POWER_ENTRY_WITH_WAKEUP
Content-Language: en-US
To:     Jason Gunthorpe <jgg@nvidia.com>
Cc:     Alex Williamson <alex.williamson@redhat.com>,
        Cornelia Huck <cohuck@redhat.com>,
        Yishai Hadas <yishaih@nvidia.com>,
        Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>,
        Kevin Tian <kevin.tian@intel.com>,
        "Rafael J . Wysocki" <rafael@kernel.org>,
        Max Gurtovoy <mgurtovoy@nvidia.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        linux-pm@vger.kernel.org, linux-pci@vger.kernel.org
References: <20220817051323.20091-1-abhsahu@nvidia.com>
 <20220817051323.20091-6-abhsahu@nvidia.com> <Yvzy0VOfKkKod0OV@nvidia.com>
 <5363303b-30bb-3c4a-bf42-426dd7f8138d@nvidia.com>
 <Yv0oH23UYbI/LI+X@nvidia.com>
From:   Abhishek Sahu <abhsahu@nvidia.com>
In-Reply-To: <Yv0oH23UYbI/LI+X@nvidia.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OGNYVldSQnduc09td1VaenFySTZoSFJTMURTTDl6eVQwR3dubVZNTnBic256?=
 =?utf-8?B?NGZjRVV3aU1nR0lKVWhvNUVIUTBCaTVSYytJVzNmSHFBdUlldTZFSXpYdkps?=
 =?utf-8?B?QWZBRmJQcW0yeEQ5SUpESUtLMjFULzc5ZzFFVVdCSzNtL05nV2N2aXZUTHZB?=
 =?utf-8?B?c2JyamdsMlIyZFJSTGJWU0RaUE92a010emN3K3gwSUtZanVqQnhxU3BMQlRO?=
 =?utf-8?B?dkkvRnBDQVN2M0JSQ2lVRlhtYUxCMkQyWHdVZXczMERYSnB3QzlZdi9XaHpu?=
 =?utf-8?B?YmZmN3JzTkFlWk4wM01jMThTODY0MGxGdUp2NWo3T1hrVmdNQVl1WjZOUkZW?=
 =?utf-8?B?VUZKRFRIdnRJV2NzYzAreVB3UmhVWG5HN0FrTEtBTW1wYzY2bzRDWnp5Zm1v?=
 =?utf-8?B?blNhQVpxVXczclBWOTBrUVdKNi84RWxNV0tzYkVtYjN2YkNWVFk0bk1XUTho?=
 =?utf-8?B?SzhZb08yY3V5WHU0WmM1STZpQWtZaHNFb3RwWHNreWlqLzR2RDRkLzlHNnFq?=
 =?utf-8?B?dk5LdjNGUFBPaVoyaTZ6S3NWSmV0WmYwVVgzdDVsKzVHRDFucFYxUUJYMzRV?=
 =?utf-8?B?a1BrWWh6ZkYreEdMYmxSTXpZSHhmbHczbnBEc1htb01oeFErd2xYRGRsU0po?=
 =?utf-8?B?V0Jxd2VGbk9RSHJhSjFjLzc4QlFPdzVvSlFKamhONVVlRTR6T25qL3M3WnU1?=
 =?utf-8?B?YXpWQU15L0xkdTNZZDRCeDJtQkVkQWJTZTE0MXRkS0VMY0lyb2ZyRlAwRTVJ?=
 =?utf-8?B?TkpMTWNoK29KVzFyeTlJZDNKZVhMRzNmUXNxb1VqKzhEWTFKQWNGQ2tCRTZk?=
 =?utf-8?B?ZEV2TTEyVml2R1hkeTNKNEM1cVNwYncwdjM0TEdWR05JaEUwWkp4MTZJeFNV?=
 =?utf-8?B?UmdWUk10NlpMK2cxOFp6YmFEQnhMUE5LVVlZaFZWdnMrS1lnTi9seURLTDh6?=
 =?utf-8?B?MVRNdUIxNjM4NEVOdThlL2V2YU5PTkxLMEkvSWRWZHM1TGY4a0ViUDlld0lD?=
 =?utf-8?B?cXRsU21peDZoUkpDdEpjRkJGSjZZYVpCTlo4dnNaT2NjOTk1alZXL1RtelhE?=
 =?utf-8?B?dW94NzBtQWdzVVJ5UklvK2FIMHJBRllnTExkeHhlMGZjckw0dEhIRVh4NkdU?=
 =?utf-8?B?R2JHYWR2NkllNFV5V0Z3cmdONTJnNTZtaWxwSndDeEdDVnp5Uzlna2hFR25L?=
 =?utf-8?B?YkRBMUZxcXNyYmFUK01vNnI0Q3FRNlVrKzV1YnZjL1RvUUxmTVRnS0dyNVMv?=
 =?utf-8?B?eVJZRHhaemg0TU1zRGgxTHZQcHh3R1Z1WWNRRmRPeloyY2owOWxxUmVEUmw1?=
 =?utf-8?B?dFdNeWhUWnEyWHBTbGpZSURUYzI0SC9PaGd1UWhLY3B6Z0U4cUdpcXJZbmVh?=
 =?utf-8?B?Yll5SmRJdWRpRUcrZDBncjg3ZmFNOTN5RXJ2ZDM3cnB6Z2g3MndLdVh5VVo0?=
 =?utf-8?B?Mkx6dVVRMzhNZFRjMHd2SThQZUIwWUJjMXROVHNncGp5SDVCRytkSzZjUkg4?=
 =?utf-8?B?c3VaMXdVWXlKNUNSRWdmb3NwSER2TWNNVHBPbElkY3FSOHVVd1JkdVYxS0VJ?=
 =?utf-8?B?YjNqZER4dVlqOWszdDlTRFZyOTBKUmhWQlAzeTQrM0swSmhVUlFHazZIdFFn?=
 =?utf-8?B?ME4rMi83SElSVjN3MUlmWjkvb2RqWHRFYWQ5ZS9JUFg2ODVnRWJvWW5kNGli?=
 =?utf-8?B?dTZxYnpWcGp6dHNyUzBiYXhEemtHTGRYUUdORkpVSHhRejEvZ2dHaEJDTW02?=
 =?utf-8?B?bk5uWldHZDZMN2xnTjROaHhQVXVuM3ZHMGpMazdtLyt5RExJejk0dTZMenNw?=
 =?utf-8?B?OUdWMlg0aU41eFNBSlBqY0JuVmlxdmZsVUhJYzYvVUY4OUp3eWZ4K0RibUdY?=
 =?utf-8?B?L3dnejZjclY2Ym4xeVNuUHVGTDRDcmhDbFh4TFRXUStEWW0vNC9obUNkNzRt?=
 =?utf-8?B?SzdGb1JFaisrS2FSSTQxVFdRSzFNYllEREM1TFNOMWp0MHZTbkUreU01eDVG?=
 =?utf-8?B?WkpLODdFV0p4WG85M2ZwQ1NCZVZObDlwVFBhYjhVYUVMT2ZkdWEzbUlzQ0pi?=
 =?utf-8?B?dlorL3hhUXdtZytIc1BSbmpXbmRORVlSKzFoMS9EUVQwNkduQ1IxWDdJNG51?=
 =?utf-8?Q?BL9vMhZ728r6p1dhUUu5iqv3d?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 296d275c-5438-4b0e-612a-08da813b4267
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5304.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Aug 2022 17:01:14.7064
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mgQsE8kVGZZ5unZ72mWMThKb+zC8pz+LUyKTeiSOhw7qmdn0uJGQeCnLKXcgWEek+Xcjth7nZJy+pMjAaSlh4g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB3751
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 8/17/2022 11:10 PM, Jason Gunthorpe wrote:
> On Wed, Aug 17, 2022 at 09:34:30PM +0530, Abhishek Sahu wrote:
>> On 8/17/2022 7:23 PM, Jason Gunthorpe wrote:
>>> On Wed, Aug 17, 2022 at 10:43:23AM +0530, Abhishek Sahu wrote:
>>>
>>>> +static int
>>>> +vfio_pci_core_pm_entry_with_wakeup(struct vfio_device *device, u32 flags,
>>>> +				   void __user *arg, size_t argsz)
>>>
>>> This should be
>>>   struct vfio_device_low_power_entry_with_wakeup __user *arg
>>>
>>
>>  Thanks Jason.
>>
>>  I can update this.
>>
>>  But if we look the existing code, for example
>>  (vfio_ioctl_device_feature_mig_device_state()), then there it still uses
>>  'void __user *arg' only. Is this a new guideline which we need to take
>>  care ?
> 
> I just sent a patch that fixes that too
> 

 Thanks for the update.
 I will change this. 

>>  Do we need to keep the IOCTL name alphabetically sorted in the case list.
>>  Currently, I have added in the order of IOCTL numbers.
> 
> It is generally a good practice to sort lists of things.
> 
> Jason

 Sure. I will make the sorted list.

 Regards,
 Abhishek