Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220628145552.349839-1-xiehuan09@gmail.com> <20220628145552.349839-5-xiehuan09@gmail.com>
 <Yv5gkKnufS7CUq9A@google.com> <CAEr6+ED7UovW1BbrK4s5tCRrTrfkESpa4m3VO4a4PBAY9nK_JA@mail.gmail.com>
In-Reply-To: <CAEr6+ED7UovW1BbrK4s5tCRrTrfkESpa4m3VO4a4PBAY9nK_JA@mail.gmail.com>
From:   Joel Fernandes <joel@joelfernandes.org>
Date:   Thu, 18 Aug 2022 13:05:44 -0400
Message-ID: <CAEXW_YQAFVJRe9mUnR1HAXvYDiQ3jCwrKhO52t8O=bxb_qSCzQ@mail.gmail.com>
Subject: Re: [PATCH v14 4/4] Documentation: trace/objtrace: Add documentation
 for objtrace
To:     Jeff Xie <xiehuan09@gmail.com>
Cc:     Steven Rostedt <rostedt@goodmis.org>,
        Ingo Molnar <mingo@redhat.com>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        Tom Zanussi <zanussi@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>, chensong_2000@189.cn,
        Jonathan Corbet <corbet@lwn.net>,
        Bagas Sanjaya <bagasdotme@gmail.com>,
        "open list:DOCUMENTATION" <linux-doc@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Aug 18, 2022 at 12:38 PM Jeff Xie <xiehuan09@gmail.com> wrote:
>
> Hi Joel,
>
> Thank you for your review.
>
> On Thu, Aug 18, 2022 at 11:53 PM Joel Fernandes <joel@joelfernandes.org> wrote:
> >
> > On Tue, Jun 28, 2022 at 10:55:52PM +0800, Jeff Xie wrote:
> > > Add documentation explaining how to use objtrace trigger to get the value
> > > of the object.
> > >
> > > Cc: Jonathan Corbet <corbet@lwn.net>
> > > Cc: Bagas Sanjaya <bagasdotme@gmail.com>
> > > Cc: linux-doc@vger.kernel.org
> > > Signed-off-by: Jeff Xie <xiehuan09@gmail.com>
> > > Reviewed-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
> > > ---
> > > Changelog:
> > > v14:
> > > - make documentation more readable and fix literal code block by Bagas Sanjaya
> > >
> > >  Documentation/trace/events.rst | 87 ++++++++++++++++++++++++++++++++++
> > >  1 file changed, 87 insertions(+)
> > >
> > > diff --git a/Documentation/trace/events.rst b/Documentation/trace/events.rst
> > > index c47f381d0c00..c15f1d25d4a0 100644
> > > --- a/Documentation/trace/events.rst
> > > +++ b/Documentation/trace/events.rst
> > > @@ -546,6 +546,93 @@ The following commands are supported:
> > >
> > >    See Documentation/trace/histogram.rst for details and examples.
> > >
> > > +- objtrace
> > > +
> > > +  This command provides a way to get the value of any object, The object
> > > +  can be obtained from the dynamic event (kprobe_event/uprobe_event) or the
> > > +  static event (tracepoint).
> > > +
> > > +  Usage:
> > > +  When using the kprobe event, by only need to set the objtrace (a new
> > > +  trigger), we can get the value of object that is set by kprobe event.
> > > +
> > > +  For example, for the function bio_add_page():
> > > +
> > > +  .. code-block:: c
> > > +
> > > +     int bio_add_page(struct bio *bio, struct page *page,
> > > +                   unsigned int len, unsigned int offset)
> > > +
> > > +  Firstly, we can set the base of the object as first parameter (arg1) to
> > > +  to the function:
> > > +
> > > +  .. code-block::
> > > +
> > > +     # echo 'p bio_add_page arg1=$arg1' > ./kprobe_events
> > > +
> > > +  Secondly, we can get the value dynamically based on the object:
> > > +
> > > +  .. code-block::
> > > +
> > > +     find the offset of the bi_size in struct bio:
> > > +     $ gdb vmlinux
> > > +     (gdb) p &(((struct bio *)0)->bi_iter.bi_size)
> > > +     $1 = (unsigned int *) 0x28
> > > +
> > > +     # echo 'objtrace:add:arg1,0x28:u32:1 if comm == "cat"' > ./events/kprobes/ \
> > > +       p_bio_add_page_0/trigger
> > > +
> > > +     # cd /sys/kernel/debug/tracing/
> > > +     # echo 'p bio_add_page arg1=$arg1' > ./kprobe_events
> > > +     # echo 'objtrace:add:arg1,0x28:u32:1 if comm == "cat"' > ./events/kprobes/p_bio_add_page_0/trigger
> >
> > No offense but this documentation is not well written and hard to read.
> >
> > Admittedly though I am just casually browsing through, so apologies.
> >
> > So basically, 0x28 is the offset of the u32 within the bio, that you want to
> > track down, as it passes through functions?
>
> Yes, Not only track the bio, but also get a value with an offset of
> 0x28 relative to the bio.

Right.

> >
> > The example is good, but I suggest breakdown each of the commands separated
> > by ':' and document those as well.
>
> I don't know how to explain it in more detail, maybe need to be
> familiar with kprobe event and trigger in advance ;-)

That's not a strong argument IMO.

Shouldn't it be super easy to add the following to the documentation
since you already mentioned it in the commit log? Or am I missing
something?

Syntax:
        objtrace:add:obj[,offset][:type][:count][if <filter>]

Thanks,

- Joel