Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH v3 02/11] net: phy: Add 1000BASE-KX interface mode
From:   Sean Anderson <sean.anderson@seco.com>
To:     Vladimir Oltean <olteanv@gmail.com>
Cc:     netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        Paolo Abeni <pabeni@redhat.com>,
        Eric Dumazet <edumazet@google.com>,
        Alexandru Marginean <alexandru.marginean@nxp.com>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, linux-kernel@vger.kernel.org
References: <20220725153730.2604096-1-sean.anderson@seco.com>
 <20220725153730.2604096-3-sean.anderson@seco.com>
 <20220818165303.zzp57kd7wfjyytza@skbuf>
 <8a7ee3c9-3bf9-cfd1-67ab-bb11c1a0c82a@seco.com>
Message-ID: <35779736-8787-f4cb-4160-4ff35946666d@seco.com>
Date:   Thu, 18 Aug 2022 13:03:54 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
In-Reply-To: <8a7ee3c9-3bf9-cfd1-67ab-bb11c1a0c82a@seco.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MEVLRnpaNTFNY2RJcXFlVkY3dHpkdW1ZYXFqTERuandPK0JIbHZ5OXVnMGhX?=
 =?utf-8?B?U0duRHprUWVCY3lUWGNJU0JmM2hBeUdEcExVa3FMMExrZWgxMlhqaXVGQkox?=
 =?utf-8?B?Vm9CalM0ODBjdGJVam0zUktKZlFqUmh6VjZNRTBDbHFkYzVpRUVJd3hLcHVQ?=
 =?utf-8?B?M3NDSU9ZdE1zaTJnVUZ6VS9hZWRzMkJpT0ZnV1lqMWtQb0xKNTN5TU9tS1ZT?=
 =?utf-8?B?NXpzVWtSd3VlU1g3WTBQc094a2xmWjBFL1dSNzBCbmpibUxHYWVQalZ0ckxM?=
 =?utf-8?B?a05ZQUEreDVxYjRzckhDT1c0dDhaQjI1d1Ixa0w4dlJMOXBYamxWc1lyRWtZ?=
 =?utf-8?B?SmFNN3NpZ0NxNjJIbUVWdzdHZXVlQkhqbkhzcE9rdWY5NFB1OG4vZ0dycHdm?=
 =?utf-8?B?NjlGT1BHOTJSNW0vd1JENlZsclB5ZzFjUFNRSnhWUE9CZFpqZkt2U2FCeExV?=
 =?utf-8?B?Smo1QXhZZmhmQVYyby9sS21JQ0p6TjdBT3Q3Z0ltT1BuT05Ycmw4OEMxaHRI?=
 =?utf-8?B?eDJEenBYY0IzeVhvZmdGY1dubC92OGZ0V1FGb2xTbW9JV0kvUVBQOCtVUVZo?=
 =?utf-8?B?U2w2dDBWWWNCRGZSSEtKcjA4TjNIdzB0SDVPTXNWSysrL05zOVhEVEFtd28y?=
 =?utf-8?B?OG9XUlkyL1A2TC91QldyaEZYNE1OZXRrd3M2RkliMlNPNlZTZ2NkZlE1Sm5F?=
 =?utf-8?B?bzl1OWxCenc3LzhkTVlBZFFpcTd5a2VtN3RneUNtRG9zYnJ6TUYxSVIwdTVr?=
 =?utf-8?B?TmxFZnFsRks2emI1SkZGeE0xQWc1QWgvdDdkSituWThpKzhMajlzM3ZtVGQr?=
 =?utf-8?B?UUx0MlpVV0tiRXdFQkRLdlV0NzlCZmRMM2hpSWFHRi9LdFFmY3laMEFnZE1t?=
 =?utf-8?B?YVFGWWVzVUpzU2ZhaDhhQnd6ZkFobzRjUnhWRVJMY0dJMmc3T3Q3Nnd3NHd0?=
 =?utf-8?B?MFh5TUxINDlOWno1Z3doa3BhVDNLQ2dxYkRkNzdka3hNTldOalB0NzRzbmJV?=
 =?utf-8?B?NkI3Zmt0TVNKeG9ORElML3d0WlFHYnQ3OXo2SDI5Mnkya0FzZEUxQ2hSUXNM?=
 =?utf-8?B?TTNqSFZYVFlmQ1g2ZHk4aXlRelZRS2hHb3h4VXk1QTNPRDZCTXlMd2YyL25G?=
 =?utf-8?B?S0VNVnIzdm9jeWJqTm9GUWFVdWJWZm9UNmJKVnhTbUhHcjNncUtpZnNMcVZN?=
 =?utf-8?B?VXNjcFh1YUhaS1FkUVYxWUtlcElicEhlNXBTb21KeWphMHhpL2VUeGdneGJj?=
 =?utf-8?B?Qk9MTjZxTlVjWm8zMTkrd2JEdVdQVk1iaDhVSysySWpuL0FzSEQ2SlVlOThK?=
 =?utf-8?B?ZHdLVHU3YW1LUWNHVkM4VW03VkdoaENDT0NwanZOTVluWmRLdkgvb2JaNUdD?=
 =?utf-8?B?K25OYm54c3A4cmxudHBXNkIxWGZweXhObVZTS0gxWGdUaVluQWprVThlNlBN?=
 =?utf-8?B?VzZhRFpVRjA0ZXFuWnFtcEJWK1YxenFQZExJQ2tVY2ZtK0hSU3Z4OEdkY3FM?=
 =?utf-8?B?WjRXWEpTQ2lwekUwZUNBVjBSNjNCTGFram1qcExxeDBYR3p3cEczUC9FNmcv?=
 =?utf-8?B?Qm1nbWJBQmV6R1dFa0lHc2ovcHJpUnhaM1FTZTVNNDB4QWdFVWtZOTh2NVIr?=
 =?utf-8?B?UkRsZThvWFhyb1Jwdk9LMWdZdTNEckZteC9VemFJTCtHUHlzNjEzR0dIeU9W?=
 =?utf-8?B?bENhM2ovMFJ2MHM1ZHY4K0JFeDhNcHkzWmRNQlczWk5JanA0NzQ1NysxdnRn?=
 =?utf-8?B?bHVoSTk0bElvUVR0bXFHWTdUZ3BESnkxWW03cU13anJ1UkpNanF3TlF5TXlt?=
 =?utf-8?B?a05LWDdpa085R0RadU5PUVVlcmk1d2hoZlN1Y21mUVZIS0RLMEFDbjZyVG1u?=
 =?utf-8?B?OC85QWJ0dStUeHNLK2gySTlpdnVzQ2JvK3dhSUMrQWZGcHRLR1pGUVRuai9h?=
 =?utf-8?B?M1puRXhiaWMzM05mblNZV2NBVnFQL0w2dTRhTjcwQTh0QkNDRHhCa1lqd0h6?=
 =?utf-8?B?ZFYrc3hNRW5Oa3RGR21TaG85REEvV1VVVjA0bERONDIvUG5IRzJkOFdhK0V1?=
 =?utf-8?B?NkRVZXl6OU90NWI3ZnY3RE5zalRmZTVPamtvMmJVMFJxaldtdHhyenduc0da?=
 =?utf-8?B?RXA1bjh6UG5ZcngzWHdlLzRRcm1WRmV0NE9uUW5OaGZUdnh5SG54SFFwWlNU?=
 =?utf-8?B?MUE9PQ==?=
X-OriginatorOrg: seco.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d6bdaa43-d860-4306-2358-08da813ba399
X-MS-Exchange-CrossTenant-AuthSource: DB7PR03MB4972.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Aug 2022 17:03:57.5059
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xLs+EyBRmaeGt/IYy8xwZSAOUxxrFiWiy1O3FOaCNYnTU+MOvNdhpXkeNZcI7kzFUr42YJpnenKuSLZ7Aje7gw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR03MB4263
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,
        SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 8/18/22 12:57 PM, Sean Anderson wrote:
> 
> 
> On 8/18/22 12:53 PM, Vladimir Oltean wrote:
>> On Mon, Jul 25, 2022 at 11:37:20AM -0400, Sean Anderson wrote:
>>> Add 1000BASE-KX interface mode. This 1G backplane ethernet as described in
>>> clause 70. Clause 73 autonegotiation is mandatory, and only full duplex
>>> operation is supported.
>>> 
>>> Signed-off-by: Sean Anderson <sean.anderson@seco.com>
>>> ---
>> 
>> What does 1000BASE-KX have to do with anything?
>> 
> 
> It doesn't, really. This should have been part of [1], but it looks like I
> put it in the wrong series.
> 
> --Sean
> 
> [1] https://lore.kernel.org/linux-phy/20220804220602.477589-1-sean.anderson@seco.com/
> 

Well, I suppose the real reason is that this will cause a merge conflict
(or lack of one), since this series introduces phylink_interface_max_speed
in patch 7, which is supposed to contain all the phy modes. So depending on
what gets merged first, the other series will have to be modified and resent.

To be honest, I had expected that trivial patches like that would have been
applied and merged already.

--Sean