Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [RESEND PATCH net-next v4 00/25] net: dpaa: Cleanups in
 preparation for phylink conversion
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org,
        Camelia Groza <camelia.groza@nxp.com>,
        open list <linux-kernel@vger.kernel.org>,
        Madalin Bucur <madalin.bucur@nxp.com>,
        linuxppc-dev@lists.ozlabs.org,
        linux-arm-kernel@lists.infradead.org,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Li Yang <leoyang.li@nxp.com>, Rob Herring <robh+dt@kernel.org>,
        devicetree@vger.kernel.org
References: <20220818161649.2058728-1-sean.anderson@seco.com>
 <20220818112054.29cd77fb@kernel.org>
 <f085609c-24c9-a9fb-e714-18ba7f3ef48a@seco.com>
 <20220818115815.72809e33@kernel.org>
From:   Sean Anderson <sean.anderson@seco.com>
Message-ID: <583c7997-fb01-63ad-775e-b6a8a8e93566@seco.com>
Date:   Thu, 18 Aug 2022 15:14:04 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
In-Reply-To: <20220818115815.72809e33@kernel.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NThGUWswa204b3lOMlNvY2oyejBOZzRBNGFraG4yZ0IrdGFjTnBwMTVuTFhX?=
 =?utf-8?B?STM1WXBzaUsyVzVKa2RiMWFrSFJ4U0ZrMHJHa2FPd3lneWhQa09iYlA2V2hD?=
 =?utf-8?B?cUIzaVlOTkJNbXFDNU02cEJleHN0QUhCQlUxTVdTNitXU3NrcVNRdXkvTktF?=
 =?utf-8?B?VVlKRC81c3ZlM3lyVmFsU1g0aThmOGtKY0FadXRESFkraCs3eHd4V2lRQ1hv?=
 =?utf-8?B?YWZWdmV0QXhTMmYvaXpNa1NDVDQrOHlVVkpoWHZPOFVHSEZVU2EybklSNzFm?=
 =?utf-8?B?azhHZDdxalhhTysyaFp4QXJydmhyMjU2V3hGaktNdDNJenBabHRrWHRHbCsw?=
 =?utf-8?B?SG8vYkw4aXArem5hd3NxWEJicTVyek5BM2c5U1RIVVhpcy9rZmVKSEFGVnhx?=
 =?utf-8?B?d0FqaGMyUmlJdE5zc21QSHdiZXFKS3JVQWd0RVF3cDVCRm01QkpiUGxicGVJ?=
 =?utf-8?B?NlY4eGI5SGdwUG1CWHdvbEVqZ1VoNnRMMDBoaHl5UUZncW9iRk5kdkZvWGsv?=
 =?utf-8?B?OUR6OFBPZjlIQmJheGFBeTAvSllDVm5hbG0wZlZIZWIwelNlZ3MyTWNsV0Jt?=
 =?utf-8?B?cXovSHkycDFRbnBhTWFMMmYxM2hWSEtONVRLNG5NNTdVOFRTQlV0aVVlY0tr?=
 =?utf-8?B?WlV3eC9mS0paVjV5a1ZZSFpmWmtJelVGa2pKV210SXNEN2tCQWo4T1BLQU13?=
 =?utf-8?B?QU0vZFdGOEJPN0tpS2NoNlpSVk9zY2pKUWd0aWR1WGljYzQ1ZkVFYnFEb3RU?=
 =?utf-8?B?UjNwVlRvWkxDZ0ZvUjArVlVrcWp1eTlHbmRyaUhBWklJS0hiRFZGVkgwZTNH?=
 =?utf-8?B?QXUvSmdFRVEzU1VLVDllbWNRaW5wUXNKZkVqYUdwMzUwcTVyY05CZndyd1Fo?=
 =?utf-8?B?NWVUbG5meGprUE51V2d4RzE1YzlEN2pJL2VTVUZkZ2ZGV1lQL2VrWEtGRW5z?=
 =?utf-8?B?UGhhSi9oVzdLdkhJdGwxMi9SY01mb0t5bzdxVmFGczFNV0xWU2V1cEZhb01q?=
 =?utf-8?B?c3cwU2pITFFvRWYycTdwUEtEbGlWZCtCOVQ5Vm5xL3VaZ1F3NEVST2tYS1c5?=
 =?utf-8?B?bG5FZXpuUVdNNWYxV0tnSSt4cUEzZkdGYTUySGRLZzlITkUvdjV3bWxOVUcx?=
 =?utf-8?B?SStmTW5YVVAyNkhGOXZGQkxocGMrOGJkZGVQcFo1K1JZMVd2VTZBOGdubG9Q?=
 =?utf-8?B?SzNueVJBVjZVdGQxZnVTMTJyclVMVFRpcUJJYkFaU1QwNXRuOUN6dVBwdkZR?=
 =?utf-8?B?ZVc1dGZoU2ZIMVh1VXo2c1IrZVpqRHJVQ1FNYVZ2c1N1a0ZPOXpkZkpXQVNC?=
 =?utf-8?B?TzBpcEE1cnBLeFZ5VHg0TlJyTG1KSkNwcVkrWVE5OFFITEsyTVZzY2FkdTdI?=
 =?utf-8?B?VHA3MWUyZzdUQ3ZPQ1dZNGQ4ZEdyNjdRczlYQkE4ZWxUYWQ4UGtieStFS010?=
 =?utf-8?B?QjkrVkM5V2JHdVpuZVp5aUpicUVOSjlrZGltK3VhUUNRQUN0M3YwQ3J4Tklm?=
 =?utf-8?B?R2ZTUG4vOUx5OHhlYmNhbFUveUxmY084RHg5WDR2MVFieDR3NnQ0Ujk1ZGc2?=
 =?utf-8?B?VTAwcVQyTXVXOEJUR1h1RDcxVVo0V2pKR0pGK012QUhBTDV0ZzhJbUloejVi?=
 =?utf-8?B?SUpZNURKTmYrSUpwOTZ3N3VpSVhLNEVEWjBzU3l3ZjdFK0NSeG4wQ2RJT1NH?=
 =?utf-8?B?Qzl2MzAwblUwSHpIWDFleTNqRG5Ja0xjV2RzcFoweVoveW9IWGVucCsyZ1hS?=
 =?utf-8?B?L1RYTHRKTjN6cG9MZUdOKzdOQzZ5ZXZ6UzVGSm1yb2VhQWcyRnp4bi9naEw0?=
 =?utf-8?B?eWpaMlpPYVZLQWVMZkNMOUN1b0xMdFJhOVY4YVhvNHV2dERwdUJRV3BkNFQ2?=
 =?utf-8?B?d0puUlR4SE9TSGdDWjN1eGlpM3NDSkxlQzRQeWQ4ZjR2eUU4dVZTRk80RVRU?=
 =?utf-8?B?OVlpay9uOUwxcTZxQmw4UENVbWlDajUwVndpdmlTQUJ6ampDQ0hUSU85enlX?=
 =?utf-8?B?d3dnSUFydURZd3R0aURocDRQWSs0K1d6ZjUrRjY5UHhDcERNUklYMmt2SWJC?=
 =?utf-8?B?ZzNhWmFTMnVETEtmTldWbWU2MjVkYjAzZ2NnamRZcWRDbzhkenZxWHZuR3BM?=
 =?utf-8?B?amZnQUZRNnNaZGtOazNjNE1PQUhYVUR1cWUwaTRnMmNyTDhmWVhObVZ2UlMw?=
 =?utf-8?B?SkE9PQ==?=
X-OriginatorOrg: seco.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1218c5aa-946e-4213-4cdd-08da814dd350
X-MS-Exchange-CrossTenant-AuthSource: DB7PR03MB4972.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Aug 2022 19:14:08.5160
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: f2v/i4T+g5AjmB7TFRJIEpp5X69fjam5JVMzZRlLbjhhflWDHEnM8DZFjFy8AO6REciS2WJLzHsqtWMXo573BA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR03MB6714
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 8/18/22 2:58 PM, Jakub Kicinski wrote:
> On Thu, 18 Aug 2022 14:37:23 -0400 Sean Anderson wrote:
>> On 8/18/22 2:20 PM, Jakub Kicinski wrote:
>> > On Thu, 18 Aug 2022 12:16:24 -0400 Sean Anderson wrote:  
>> >> This series contains several cleanup patches for dpaa/fman. While they
>> >> are intended to prepare for a phylink conversion, they stand on their
>> >> own. This series was originally submitted as part of [1].  
>> > 
>> > Still over the limit of patches in a patch series, and looks pretty
>> > easy to chunk up. We review and apply patches in netdev in 1-3 days,
>> > it really is more efficient to post smaller series.   
>> 
>> Last time I offered to arbitrarily chunk things [1], but I did not receive
>> a response for 3 weeks.
> 
> I sent you the link to the rules. Admittedly not the most polite and
> clear feedback to put it mildly but that was the reason.

It would have helped if you'd clarified; I thought the primary thing was
the missing net-next.

>> > And with the other series you sent to the list we have nearly 50
>> > patches from you queued for review. I don't think this is reasonable,
>> > people reviewing this code are all volunteers trying to get their
>> > work done as well :(  
>> 
>> These patches have been sent to the list in one form or another since
>> I first sent out an RFC for DPAA conversion back in June [2]. I have not
>> substantially modified any of them (although I did add a few more
>> since v2). It's not like I came up with these just now; I have been
>> seeking feedback on these series for 2-3 months so far. The only
>> reviews I have gotten were from Camelia Groza, who has provided some
>> helpful feedback.
> 
> Ack, no question. I'm trying to tell you got to actually get stuff in.
> It's the first week after the merge window and people are dumping code
> the had written over the dead time on the list, while some reviewers
> and maintainers are still on their summer vacation. So being
> considerate is even more important than normally.

OK, so perhaps a nice place to split the series is after patch 11. If
you would like to review/apply a set of <15 patches, that is the place
to break things. I can of course resend again with just those, if that's
what I need to do to get these applied.

That said, I specifically broke this series up into many small patches
to make it easier to review. Each patch does exactly one thing. Had I
known about these limits based on patch size, I would have just squashed
everything into 15 patches. I think an arbitrary limit such as this has
a perverse incentive.

--Sean