Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 18 Aug 2022 21:29:07 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     wei.fang@nxp.com
Cc:     hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
        robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        f.fainelli@gmail.com, netdev@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3 net 2/2] net: phy: at803x: add disable hibernation
 mode support
Message-ID: <Yv6TA9xfx4m2+YrH@lunn.ch>
References: <20220818030054.1010660-1-wei.fang@nxp.com>
 <20220818030054.1010660-3-wei.fang@nxp.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220818030054.1010660-3-wei.fang@nxp.com>
Precedence: bulk

On Thu, Aug 18, 2022 at 11:00:54AM +0800, wei.fang@nxp.com wrote:
> From: Wei Fang <wei.fang@nxp.com>
> 
> When the cable is unplugged, the Atheros AR803x PHYs will enter
> hibernation mode after about 10 seconds if the hibernation mode
> is enabled and will not provide any clock to the MAC. But for
> some MACs, this feature might cause unexpected issues due to the
> logic of MACs.
> Taking SYNP MAC (stmmac) as an example, if the cable is unplugged
> and the "eth0" interface is down, the AR803x PHY will enter
> hibernation mode. Then perform the "ifconfig eth0 up" operation,
> the stmmac can't be able to complete the software reset operation
> and fail to init it's own DMA. Therefore, the "eth0" interface is
> failed to ifconfig up. Why does it cause this issue? The truth is
> that the software reset operation of the stmmac is designed to
> depend on the RX_CLK of PHY.
> So, this patch offers an option for the user to determine whether
> to disable the hibernation mode of AR803x PHYs.
> 
> Signed-off-by: Wei Fang <wei.fang@nxp.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew