Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp839814rwb; Thu, 18 Aug 2022 13:15:20 -0700 (PDT) X-Google-Smtp-Source: AA6agR7MQ8mGMHKfoByZtpyLRGP8xaz34kYbyNYu5HK+yZn6wveia3HTNEmHhbtkkxtVHB+kXzyN X-Received: by 2002:a17:907:e89:b0:730:af06:e345 with SMTP id ho9-20020a1709070e8900b00730af06e345mr2931560ejc.665.1660853720151; Thu, 18 Aug 2022 13:15:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660853720; cv=none; d=google.com; s=arc-20160816; b=tPcEleeoUVVNKMqvtsCKkGeS4Qkif2lz8ctLSedaLQRpry0tFnlnozlL5isf3kjCL9 4mLWOOy+m9iQQHpB+sN2cGQXPUUxYKoeeQKmkSnDMWjOoEl+bzsyfSPKSjp0hqzYS1+I oZ3lmuq6o4C5nIG8gZisSfxxPqjK9kgi4NKhQEuPOkRj1VefpmOuGkh+1Fb2UsRGHFwX q9XwAqIjAhV93Ym5CJiWgrmrNv8C+uoFUcMal293LS8RHie5LCnb2pRu3bxQr1o+HULz H8us+Ghtz/54PUn54s6EDE8Jbg0+FENdiIHbvfNPEsLsW12aZ+fmNs1PsIpyhUxqxP2w tI3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=zGb9AUD76XSe+9n25olXgP8J31+p67LHtLCVbcvi+vk=; b=qYnepbXiet3sMC3BpOjssrXe0WQQQ/MQdc0eLNUiohTaJ8KHj3Le6jOi0EjkJxdWBj LDUqcFAu6j1zpp3jWgre2g2T94j50usByKb3gB+kJZr0IByYZte1x2fk8apiK6Fj+9r0 FlYoj5XBjGNaJX+9d9x9ecPGbtzf47r6Szr4OaaGJNa2Ya0maCGqsbYAiMaKYMN7zVQ3 tvPcf60ehuy2hZ/27czIxdSRsQM+SKvidpNSDH1Hv8M9TZd3WvX+WU+fuuI7Q4az9Rqc OR2/ivrhd2aDkUEvYrLgb+3nv9f3nc2svxQ8ROoKn/LpOuivqxboX/KTjnJtvmW9SCcc RxOQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Ebkx32TB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ho17-20020a1709070e9100b0073094a56feesi1880883ejc.546.2022.08.18.13.14.53; Thu, 18 Aug 2022 13:15:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Ebkx32TB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345235AbiHRS7b (ORCPT + 99 others); Thu, 18 Aug 2022 14:59:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345292AbiHRS72 (ORCPT ); Thu, 18 Aug 2022 14:59:28 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D21DBFC7F for ; Thu, 18 Aug 2022 11:59:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1660849166; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zGb9AUD76XSe+9n25olXgP8J31+p67LHtLCVbcvi+vk=; b=Ebkx32TBbbUh+j9m0J/9dJsBXS1PHwK1WTvKbOyE2DGemt+dPpE8sG4eIWpFVJaPECwlnf iAxNwJ+unlrRvfPunBBZspnkzSJVbl878gvJOWVJ30Ej2GFaQBZ8gNnWZf/N0nxXElVt3y Dbnf1ozzgHwku8pkgxsar24CZ5K/LVI= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-659-AZpQlQbzPEiLEdtn3aT2zQ-1; Thu, 18 Aug 2022 14:59:21 -0400 X-MC-Unique: AZpQlQbzPEiLEdtn3aT2zQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B75461824603; Thu, 18 Aug 2022 18:59:20 +0000 (UTC) Received: from localhost (unknown [10.22.16.111]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6BD4740CFD05; Thu, 18 Aug 2022 18:59:20 +0000 (UTC) Date: Thu, 18 Aug 2022 15:59:19 -0300 From: "Luis Claudio R. Goncalves" To: Sebastian Andrzej Siewior Cc: Yajun Deng , peterz@infradead.org, mingo@redhat.com, will@kernel.org, linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org Subject: Re: [PATCH 5.10-rt] locking/rtmutex: switch to EXPORT_SYMBOL() for ww_mutex_lock{,_interruptible}() Message-ID: References: <20220803062430.1307312-1-yajun.deng@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 18, 2022 at 06:32:37PM +0200, Sebastian Andrzej Siewior wrote: > On 2022-08-03 14:24:30 [+0800], Yajun Deng wrote: > > We can use EXPORT_SYMBOL() instead of EXPORT_SYMBOL_GPL() in > > ww_mutex_lock_interruptible() and ww_mutex_lock(). That match > > ww_mutex_unlock() well. And also good for 3rd kernel modules. > > Not that I am fan of this but it will sync the symbols with what landed > upstream as of commit > f8635d509d807 ("locking/ww_mutex: Implement rtmutex based ww_mutex API functions") > > therefore it would be good to have. > Luis? Looks good to me. I can add that to my next update. Luis > > Signed-off-by: Yajun Deng > > Sebastian > ---end quoted text---