Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <02e92b29-9fcd-b52f-3ddb-e5e20e6db604@acm.org>
Date:   Thu, 18 Aug 2022 13:24:17 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.1.2
Subject: Re: [RFC PATCH v2 1/2] scsi: ufs: Add Multi-Circular Queue support
Content-Language: en-US
To:     Manivannan Sadhasivam <mani@kernel.org>,
        Can Guo <quic_cang@quicinc.com>
Cc:     quic_asutoshd@quicinc.com, quic_nguyenb@quicinc.com,
        quic_xiaosenh@quicinc.com, stanley.chu@mediatek.com,
        adrian.hunter@intel.com, beanhuo@micron.com, avri.altman@wdc.com,
        linux-scsi@vger.kernel.org, kernel-team@android.com,
        Alim Akhtar <alim.akhtar@samsung.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Jinyoung Choi <j-young.choi@samsung.com>,
        jongmin jeong <jjmin.jeong@samsung.com>,
        Kiwoong Kim <kwmad.kim@samsung.com>,
        open list <linux-kernel@vger.kernel.org>
References: <1660213984-37793-1-git-send-email-quic_cang@quicinc.com>
 <1660213984-37793-2-git-send-email-quic_cang@quicinc.com>
 <20220812091012.GB4956@thinkpad>
From:   Bart Van Assche <bvanassche@acm.org>
In-Reply-To: <20220812091012.GB4956@thinkpad>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 8/12/22 02:10, Manivannan Sadhasivam wrote:
> On Thu, Aug 11, 2022 at 03:33:03AM -0700, Can Guo wrote:
>> +static unsigned int dev_cmd_queue = 1;
>> +static unsigned int read_queues;
> 
> Where is this initialized?

The Linux kernel coding style does not allow to explicitly initialize 
static variables to zero.

>> +
>> +static int rw_queue_count_set(const char *val, const struct kernel_param *kp)
>> +{
>> +	unsigned int n;
>> +	int ret;
>> +
>> +	ret = kstrtouint(val, 10, &n);
>> +	if (ret)
>> +		return ret;
>> +	if (n > num_possible_cpus())
>> +		return -EINVAL;
>> +	return param_set_uint(val, kp);
>> +}
>> +
>> +static const struct kernel_param_ops rw_queue_count_ops = {
>> +	.set = rw_queue_count_set,
>> +	.get = param_get_uint,
>> +};
>> +
>> +static unsigned int rw_queues = 8;
>> +module_param_cb(rw_queues, &rw_queue_count_ops, &rw_queues, 0644);
>> +MODULE_PARM_DESC(rw_queues, "Number of queues used for rw. Default value is 8");
>> +
> 
> Using module params is not encouraged these days. So please switch to Kconfig.

Hmm ... I think using CONFIG_* variables is worse than using module 
parameters since modifying CONFIG_* variables requires rebuilding the 
kernel.

>> +struct cq_entry {
>> +	/* DW 0-1 */
>> +	__le32 command_desc_base_addr_lo;
>> +	__le32 command_desc_base_addr_hi;
>> +
>> +	/* DW 2 */
>> +	__le16  response_upiu_length;
>> +	__le16  response_upiu_offset;
>> +
>> +	/* DW 3 */
>> +	__le16  prd_table_length;
>> +	__le16  prd_table_offset;
>> +
>> +	/* DW 4 */
>> +	__le32 status;
>> +
>> +	/* DW 5-7 */
>> +	u32 reserved[3];
>> +};
> 
> packed?

Using __packed if it is not necessary is wrong since it makes code slower.

Thanks,

Bart.