Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Guenter Roeck <groeck7@gmail.com>
Date:   Thu, 18 Aug 2022 13:01:38 -0700
From:   Guenter Roeck <linux@roeck-us.net>
To:     Eliav Farber <farbere@amazon.com>
Cc:     jdelvare@suse.com, robh+dt@kernel.org, mark.rutland@arm.com,
        linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, talel@amazon.com, hhhawa@amazon.com,
        jonnyc@amazon.com, hanochu@amazon.com, ronenk@amazon.com,
        itamark@amazon.com, shellykz@amazon.com, shorer@amazon.com,
        amitlavi@amazon.com, almogbs@amazon.com, dwmw@amazon.co.uk,
        rtanwar@maxlinear.com
Subject: Re: [PATCH v2 04/16] hwmon: (mr75203) add Moortec PVT controller
 reset-control-skip property
Message-ID: <20220818195742.GA3287145@roeck-us.net>
References: <20220817054321.6519-1-farbere@amazon.com>
 <20220817054321.6519-5-farbere@amazon.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220817054321.6519-5-farbere@amazon.com>
Precedence: bulk

On Wed, Aug 17, 2022 at 05:43:09AM +0000, Eliav Farber wrote:
> Adding a "reset-control-skip" bool property to the mr75203 node will
> avoid looking up and obtaining a reference to a reset controller.
> 

This seems overly complex. WHy not just declare the "resets"
property optional ?

Guenter

> Signed-off-by: Eliav Farber <farbere@amazon.com>
> ---
>  .../devicetree/bindings/hwmon/moortec,mr75203.yaml          | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> index f9e849cc73e0..da9c3cdcb6f0 100644
> --- a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> @@ -44,6 +44,11 @@ properties:
>    "#thermal-sensor-cells":
>      const: 1
>  
> +  reset-control-skip:
> +    description:
> +      reset-control-skip bool property defines if obtaining a
> +      reference to a reset controller should be skipped.
> +
>  required:
>    - compatible
>    - reg
> @@ -54,6 +59,7 @@ required:
>  
>  additionalProperties:
>    - intel,vm-map
> +  - reset-control-skip
>  
>  examples:
>    - |