Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp941350rwb; Thu, 18 Aug 2022 15:23:27 -0700 (PDT) X-Google-Smtp-Source: AA6agR4Mb8/9nY2o6UA7HwtFhQzg7H4mU2f7sPUwpnyClELxGnDuU4AEsKYFhOe/EfEIKYQIENRD X-Received: by 2002:a17:902:d4d1:b0:16e:ec0b:75d0 with SMTP id o17-20020a170902d4d100b0016eec0b75d0mr4418272plg.123.1660861407102; Thu, 18 Aug 2022 15:23:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660861407; cv=none; d=google.com; s=arc-20160816; b=cQmUvaitSA1bjsEspK9OmfipvRpCt6/mUspTbUNbJV1IuhLXb9wST5lSOj3LCCYs+5 6WkruQ8me8mz/p56V5GKcZ7td+TV3D0YAxfUoNmYAVziB/pPRpigbOMGclb/FIp/3Ng4 Jat+Kwk6c+3DoI1qncu7BCC4Bz7xM/emuwUGGm5aiY9S2lGcZF/uxrtalmWb0KmPBFQc tfu2SfLNKmYyBNseUW2npXU+MUOSv8g+o1seBla2eNEDh4JR3O736fihuKRPA7+I1S0n AkigiyhwRoEmAMYjHvgP/U1W4WJ4JJfTerXDXK9PaCI2tHKRldYbmVkONfJxu8etLxlM MAQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=9w8PCaO1EnGCgJx3m49n5Qyuu9AUpPsUIAQ1LHX01iw=; b=Mi4ms92CSY/4UcsFnqVQEJijFLd9bVpOAFD7MXr8Ek1dgp5w3WK0FC5xeemgyjVG39 n94Q93RH1+zjvZgr3k5Nqpw/PgEsdZnPhFz6+Lz5ZZTpKv1bZ+Jwu9wZQxgRhuteFCJG pMRvRvJv5287V9p2vgUAimzKU2jOouLXKCYwVKsmJdsAc/wVKaHQ6YBBzItkTSCqwgwD IGGqKCZtaLaUmrplXnV3mQ6FrgWo07vmfkVDdSs9W0KlYCCBGCGPtFWNXXJzeNtRu0lz cMaJk5zjL8l2FANh3kPsitKvG3M4tfCRheKRXbIomCU67xl4JqCZ4b5lt25HTQ2QM9RD btqA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c15-20020a170902d48f00b0016bf0171143si271127plg.246.2022.08.18.15.23.15; Thu, 18 Aug 2022 15:23:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245732AbiHRWL7 (ORCPT + 99 others); Thu, 18 Aug 2022 18:11:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54908 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234827AbiHRWL5 (ORCPT ); Thu, 18 Aug 2022 18:11:57 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:12e:520::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E302D2B15; Thu, 18 Aug 2022 15:11:57 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1oOnjk-0003hc-Tn; Fri, 19 Aug 2022 00:11:37 +0200 Date: Fri, 19 Aug 2022 00:11:36 +0200 From: Florian Westphal To: Wolfram Sang Cc: linux-kernel@vger.kernel.org, Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Julian Anastasov , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, lvs-devel@vger.kernel.org Subject: Re: [PATCH] netfilter: move from strlcpy with unused retval to strscpy Message-ID: <20220818221136.GD32331@breakpoint.cc> References: <20220818210224.8563-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220818210224.8563-1-wsa+renesas@sang-engineering.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Wolfram Sang wrote: > Follow the advice of the below link and prefer 'strscpy' in this > subsystem. Conversion is 1:1 because the return value is not used. > Generated by a coccinelle script. No objections, I can take this via nf-next tree.