Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp1027147rwb; Thu, 18 Aug 2022 17:21:41 -0700 (PDT) X-Google-Smtp-Source: AA6agR4R/zghGhXo8RyVzuZw9enXncBjV32Xb0b1+tgYjpbW6EgPvFbYxpmMaLcUiDxV62UWCA2H X-Received: by 2002:aa7:c7da:0:b0:440:d482:36b5 with SMTP id o26-20020aa7c7da000000b00440d48236b5mr4038460eds.21.1660868501484; Thu, 18 Aug 2022 17:21:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660868501; cv=none; d=google.com; s=arc-20160816; b=BMviowAV3t5BMl+RFOZOWF3KdXFOHC0g0XIyMSt6tvfWOcq0fX0SiqiDx5v40lr1ve c0cgrNUz9rkNr6mVpq4WbfxbkLW3EkvFsKgfhXsJit40in/fXZJ8yTUvTMMlBlim8eaz ldVzFzIXkPs4jc+q07UWScgAwZh6XoizRIsfTxk1hjJxjRX6ZlsLVxUsOW/nQAznJWam ksBim0ESAiTcHjHasickiVNZ5sjPM+ldvD43VTKTztn4+lwC5pU9biJWbV3YVqjzV2TF yY37bmnqQnWV/jXTLVs2SVxM3CvYaNLbAp4tGeiYGW8FBy9o3rXJiQ5y6HfnZsU8zlpF UEbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=oaC18ebf8HrnX38abtQXUfLjaqpAibW92E0Qqkdt/rc=; b=pCVBps71LYmyltVkNQl/QMTEgdr1tnqcXINCYafUBy4vkjKNtwYyGBl/7vdBkrmYKf K7qJ9tH4kLPm/DyXdcIxt22nH+2UAKtikI/SZi4nKAX/qtyz05G8vd+bm6LoGhPz45BY 9+kFjCKDRPqwNadYQKRREJFwmMrVHibIfn3Tl1CDVHttwQ9eL4vGPN2LqGq7/fzTP2Js pBBWDL5wVJpAB5Tv59a7Map4V7xMJGfvP4j4AIZx989IYxtI17sk2GoTNMqyvijclK75 yXACCQ8fYms1RUC9Aq9EXVW0NyqEt+H6Vf0RYmbrzlK1Gz5BNjiPmk+ofPIlxaSe5xRY uw8A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=T+KC6Nt1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l20-20020a170906795400b00733016bd060si2167361ejo.139.2022.08.18.17.21.15; Thu, 18 Aug 2022 17:21:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=T+KC6Nt1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242400AbiHRXwM (ORCPT + 99 others); Thu, 18 Aug 2022 19:52:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346079AbiHRXwD (ORCPT ); Thu, 18 Aug 2022 19:52:03 -0400 Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 29418DEA48 for ; Thu, 18 Aug 2022 16:51:59 -0700 (PDT) Received: by mail-pj1-x102a.google.com with SMTP id s36-20020a17090a69a700b001faad0a7a34so6080541pjj.4 for ; Thu, 18 Aug 2022 16:51:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=oaC18ebf8HrnX38abtQXUfLjaqpAibW92E0Qqkdt/rc=; b=T+KC6Nt1AiimE8ajVV6KYoQlIjigEeIHZOXa96RmlUjkUaKHBFLPChl56oXynEXv06 m6LiSq7U+1u3ZSYIhZe58zoOesMMElcJ9Je7BgFd4b6vuLSUZftlmdztHdhDkUvFt2Wa F6TnsVHJlZbWjZ2nQBBXjqEpMGLfWJUA6Tlx/sJKolGWyPrMx+6X/lKBYW2pSsy/c5fn DPnak6w/X9MluZeAV8+stZfVacubj1+36xrJmO0c38xyGrWM+zDLC4VNfnHwEhPKUJtE xs/VyPE2SMKQxexOpnTP5g9KPEbp347Ffg5ahkkGN0XiNSMBSKq56N1kNKwXfddWYrIV HOTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=oaC18ebf8HrnX38abtQXUfLjaqpAibW92E0Qqkdt/rc=; b=ihenj6z+VBq5q8dP+KLN/ydbXGXxo7rfDT7FtwdDQVcUeNOOncbYvazyOgPve8r8KR MgiBUO+EWBIOScJ2KN0BI5otAO17nRy4F0LX2et14MBne96oO7w6NQ5wsucGuNP2vTCj Fgys7AW6sAzcKn1gGdMT2d5VnUO9qEsraT9nGBJDDJrjTaFXrWfgAReDlmELD9zxQsEQ TFURpY5QP8K1zbzTK6xE+ExPzNcWhPcC0KkEOc0HKjFaYSbxtEc8tKmxFvpBKiyhtyho Q9FleKobVV8fefIEoUMce4WN3GR3S1AcQVfFyBYFUIpcouOmUHJkmGUiMT111gRT5P/T 5dDw== X-Gm-Message-State: ACgBeo3K1fKYAIVz7f+dva3Fw3AB9mhmyoBiWtTZJaC1defKeqnUAQvK Gxri4xc6SV0ssZiQViEIAUGEaA== X-Received: by 2002:a17:902:8d8a:b0:16f:21fb:b97a with SMTP id v10-20020a1709028d8a00b0016f21fbb97amr4712515plo.160.1660866718568; Thu, 18 Aug 2022 16:51:58 -0700 (PDT) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id f68-20020a625147000000b0052a297324cbsm2181877pfb.41.2022.08.18.16.51.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Aug 2022 16:51:58 -0700 (PDT) Date: Thu, 18 Aug 2022 23:51:54 +0000 From: Sean Christopherson To: Li kunyu Cc: pbonzini@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/5] kvm/kvm_main: The npages variable does not need to be initialized and assigned, it is used after assignment Message-ID: References: <20220812101523.8066-1-kunyu@nfschina.com> <20220812103009.8362-1-kunyu@nfschina.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220812103009.8362-1-kunyu@nfschina.com> X-Spam-Status: No, score=-14.4 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH,FSL_HELO_FAKE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Please use "KVM: " for the shortlog scope, and write an actual shortlog. E.g. KVM: Drop unnecessary initialization of "npages" in hva_to_pfn_slow() On Fri, Aug 12, 2022, Li kunyu wrote: > The npages variable does not need to be initialized and assigned, it is > first assigned before it is used. > > Signed-off-by: Li kunyu > --- With a proper shortlog, Reviewed-by: Sean Christopherson