Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp1113427rwb; Thu, 18 Aug 2022 19:40:06 -0700 (PDT) X-Google-Smtp-Source: AA6agR4EhO5ehfL1jQMBcChWm0bfSJ6yRdTdawA7yaBs0vh7AilFrbNtfY/SzT8RCkLjpnHfZ1zZ X-Received: by 2002:a17:907:6e9f:b0:730:e923:a378 with SMTP id sh31-20020a1709076e9f00b00730e923a378mr3451151ejc.71.1660876806042; Thu, 18 Aug 2022 19:40:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660876806; cv=none; d=google.com; s=arc-20160816; b=HHrlRwcxBTwC1NRB4IpQnfoTB0kwTWVDTTGC7IVlIhF032UBzUZF4rAl1ImXecVnkv GdMOn3zDeDGFxgmOXJeiWRdmikKYcl9WtjZP+SndDr5nYM9AP+nvRlospginY38pbsfZ ewjMfV0EbpAns7tYr55RmIKLwJBN4y1Jo+C5n0fdaWGiY6HpQ4tTVzZ22UHEDRBrB6qZ h68qJVSKDcKzGtYAd5LZOx5fcg2oR/avsOuVzb0bmLbx2As40pRPCnAd0fLmBeZMIz4x oL6SnAnZjwoWRsb9S2QOcv3ri89GhrAvvJ9aXEl/2epSCXzDitHe5eqiNbM4neW962uE 0gDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=XjpgMNnmDq2/MSBZfMNVxTC/VbXPi9TeVCkKsr+LkB4=; b=mdoRGmOEmh6VAXNEy4a5OG5OM8zsFCt++Y71ir2wPYF3r2h3qcPovdEFa++hOrqCkc o3nhuEHjkmyLXVTP02pCtxreMi8Ag5okcRNiltEdYbJ+GjsFbUyiqE+0Em4BFQCh0Fh1 uEA3Z9ST9AMdvewCkDiawoL3jDzb260LG7bYxsF3hq+jHfMfvm3+P0KDdPVeOYfOVO/P EGXs8kZZBf9ZhbyzNezepOlWSiVXZ+XTqZ6zoWt+xxOvh0nXvWkjmekzgLZOmiXfcvjn zRXVRQ+WypCJaWRhChP2tyMWR6g6W4M0bI+fstaRInBwp+YqG3kGgGmCJkhr7A2gHFSI wldQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@thepaulodoom.com header.s=mail header.b=gAVgxHvY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=thepaulodoom.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x2-20020a1709064a8200b007317ee0ae03si2160710eju.818.2022.08.18.19.39.39; Thu, 18 Aug 2022 19:40:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@thepaulodoom.com header.s=mail header.b=gAVgxHvY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=thepaulodoom.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245051AbiHSBwG (ORCPT + 99 others); Thu, 18 Aug 2022 21:52:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238360AbiHSBwE (ORCPT ); Thu, 18 Aug 2022 21:52:04 -0400 Received: from mail.thepaulodoom.com (www.thepaulodoom.com [45.77.108.202]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6841DD7D19 for ; Thu, 18 Aug 2022 18:52:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thepaulodoom.com; s=mail; t=1660873920; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XjpgMNnmDq2/MSBZfMNVxTC/VbXPi9TeVCkKsr+LkB4=; b=gAVgxHvY4HCYUqqRG6DeA01/WNcQW9A+7olP7jPyDAK0MMU1+PHwrEE5+I/DZZx7dW7StY y8faSL7QokA68IUXpfr+VQZ+5FXJYDDIjZRPGKY0u64FiVreT9h1wKWcNUPY+UishoDBZD zniU1sbEOeF/8obSxt5S7T7Tg++rq9o1h0NHXqmV7PW2rG5p6265x8vynL/QLiVFrrywEY K1pWHlsuQSfjTk1GzIZ70VwpRnB3dD1xcNrYt/RsN7MpFKYpIfDHHqzuJmoJDVtz/rWb4J Do3UnYW9+SwUpVdi2Q/vCHNOze9dE5PTW00xwse+RlT20kcS2JWxUph/0ZbCZapWrdc4j4 CgaGU4h3O0l3uTCJqnnXMOHEPfRSECMXJVmegEcBL7RARAQkdST2zK0ioeBWCw+vQYvX0r h3C9qEXQO2HPjzHAur2YEsLJpV3XYVp0w18u2rdUE6Ay9f3ZBeGZRyEOXyozy8bqT4cN5i wphpi5740iv7uzQq5RWaHqOBTrhA7k6C0vY45VtGOoj4YlDxHIA86xqZksULZByAgO5Aw2 r3h0gpNKhHSvlpZJpxrmbj8LdgdmiEzBjBQ7+vAYBRYsR+goNf8Dag8vRG7rq5TQEdw77V FEy7Kn5DaQFoLpCs6BJZVuGOIpz5ttpFjY9/ApoZAkGzZdElcMzi4= Received: from gus-fring.localdomain (c-98-240-189-147.hsd1.mn.comcast.net [98.240.189.147]) by vultr.guest (OpenSMTPD) with ESMTPSA id 3c7cd58b (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 19 Aug 2022 01:52:00 +0000 (UTC) Date: Thu, 18 Aug 2022 20:52:37 -0500 From: Paul Lemmermann To: Greg KH Cc: arnd@arndb.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers: char: mem: changed 'unsigned' to 'unsigned int' Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 18, 2022 at 04:52:11PM +0200, Greg KH wrote: > On Tue, Aug 16, 2022 at 08:35:31PM -0500, Paul Lemmermann wrote: > > found with checkpatch.pl > > That is a very sparse changelog text. > > Why make this change? Please be descriptive. > I wanted to make this change to be more fitting with the kernel coding guidelines, and to reduce a WARNING made with checkpatch preferring the use of 'unsigned int' over 'unsigned'. With NOMMU_MAP_COPY defined in 'include/linux/fs.h' as an unsigned integer, I felt like the change was fitting. I was quickly reminded that the changelog was not properly done, and I now understand that, and will learn from my mistake in the future. As I am a new kernel contributor, and looking to hone my skills, what are my next steps? Should I: o Drop the patch and resubmit it, o Simply drop the patch, o Could I change it somehow?, o Or something else? Thank you very much for your time and effort, - Paul P.S. Resending this as reply all, as I quickly relized I forgot to do after I send the email to Greg.