Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <362b55e8-6f98-6723-6751-92dbe16ea924@kernel.org>
Date:   Fri, 19 Aug 2022 07:20:39 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.1.0
Subject: Re: [PATCH 12/13] serial: document start_rx member at struct uart_ops
Content-Language: en-US
To:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        Linux Doc Mailing List <linux-doc@vger.kernel.org>,
        corbet@lwn.net
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org
References: <cover.1660829433.git.mchehab@kernel.org>
 <5d07ae2eec8fbad87e623160f9926b178bef2744.1660829433.git.mchehab@kernel.org>
From:   Jiri Slaby <jirislaby@kernel.org>
In-Reply-To: <5d07ae2eec8fbad87e623160f9926b178bef2744.1660829433.git.mchehab@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 18. 08. 22, 15:38, Mauro Carvalho Chehab wrote:
> Fix this doc build warning:
> 	./include/linux/serial_core.h:397: warning: Function parameter or member 'start_rx' not described in 'uart_ops'

Reviewed-by: Jiri Slaby <jirislaby@kernel.org>


> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
> ---
> 
> See [PATCH 00/13] at: https://lore.kernel.org/all/cover.1660829433.git.mchehab@kernel.org/
> 
>   include/linux/serial_core.h | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/include/linux/serial_core.h b/include/linux/serial_core.h
> index aef3145f2032..6e4f4765d209 100644
> --- a/include/linux/serial_core.h
> +++ b/include/linux/serial_core.h
> @@ -141,6 +141,14 @@ struct gpio_desc;
>    *	Locking: none.
>    *	Interrupts: caller dependent.
>    *
> + * @start_rx: ``void ()(struct uart_port *port)``
> + *
> + *	Start receiving characters.
> + *
> + *	Locking: @port->lock taken.
> + *	Interrupts: locally disabled.
> + *	This call must not sleep
> + *
>    * @stop_rx: ``void ()(struct uart_port *port)``
>    *
>    *	Stop receiving characters; the @port is in the process of being closed.

thanks,
-- 
js
suse labs