Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f75cb32b7c262fe852c53544034f5b6047d29b65.camel@gmx.de>
Subject: Re: [PATCH v5 3/5] vduse: Support using userspace pages as bounce
 buffer
From:   Mike Galbraith <efault@gmx.de>
To:     Xie Yongji <xieyongji@bytedance.com>, jasowang@redhat.com,
        mst@redhat.com, xiaodong.liu@intel.com, maxime.coquelin@redhat.com,
        stefanha@redhat.com
Cc:     songmuchun@bytedance.com,
        virtualization@lists.linux-foundation.org,
        linux-kernel@vger.kernel.org
Date:   Fri, 19 Aug 2022 08:01:42 +0200
In-Reply-To: <20220803045523.23851-4-xieyongji@bytedance.com>
References: <20220803045523.23851-1-xieyongji@bytedance.com>
         <20220803045523.23851-4-xieyongji@bytedance.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.4 
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Greetings,

On Wed, 2022-08-03 at 12:55 +0800, Xie Yongji wrote:
>
> diff --git a/drivers/vdpa/vdpa_user/iova_domain.h b/drivers/vdpa/vdpa_us=
er/iova_domain.h
> index 2722d9b8e21a..4e0e50e7ac15 100644
> --- a/drivers/vdpa/vdpa_user/iova_domain.h
> +++ b/drivers/vdpa/vdpa_user/iova_domain.h
> @@ -14,6 +14,7 @@
> =C2=A0#include <linux/iova.h>
> =C2=A0#include <linux/dma-mapping.h>
> =C2=A0#include <linux/vhost_iotlb.h>
> +#include <linux/rwlock.h>
                   ^^^^^^^^

Erm, that should be spinlock.h.

#ifndef __LINUX_RWLOCK_H
#define __LINUX_RWLOCK_H

#ifndef __LINUX_SPINLOCK_H
# error "please don't include this file directly"
#endif

This belated comment inspired by PREEMPT_RT build meeting the above :)

	-Mike