Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220803045523.23851-1-xieyongji@bytedance.com>
 <20220803045523.23851-4-xieyongji@bytedance.com> <f75cb32b7c262fe852c53544034f5b6047d29b65.camel@gmx.de>
In-Reply-To: <f75cb32b7c262fe852c53544034f5b6047d29b65.camel@gmx.de>
From:   Yongji Xie <xieyongji@bytedance.com>
Date:   Fri, 19 Aug 2022 14:14:54 +0800
Message-ID: <CACycT3tXWYwE4x-_N-pezV5SVXcZeT0OPsbDkyyreK_ayOYzXw@mail.gmail.com>
Subject: Re: [PATCH v5 3/5] vduse: Support using userspace pages as bounce buffer
To:     Mike Galbraith <efault@gmx.de>
Cc:     Jason Wang <jasowang@redhat.com>,
        "Michael S. Tsirkin" <mst@redhat.com>,
        Liu Xiaodong <xiaodong.liu@intel.com>,
        Maxime Coquelin <maxime.coquelin@redhat.com>,
        Stefan Hajnoczi <stefanha@redhat.com>,
        songmuchun@bytedance.com,
        virtualization <virtualization@lists.linux-foundation.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Mike,

On Fri, Aug 19, 2022 at 2:01 PM Mike Galbraith <efault@gmx.de> wrote:
>
> Greetings,
>
> On Wed, 2022-08-03 at 12:55 +0800, Xie Yongji wrote:
> >
> > diff --git a/drivers/vdpa/vdpa_user/iova_domain.h b/drivers/vdpa/vdpa_user/iova_domain.h
> > index 2722d9b8e21a..4e0e50e7ac15 100644
> > --- a/drivers/vdpa/vdpa_user/iova_domain.h
> > +++ b/drivers/vdpa/vdpa_user/iova_domain.h
> > @@ -14,6 +14,7 @@
> >  #include <linux/iova.h>
> >  #include <linux/dma-mapping.h>
> >  #include <linux/vhost_iotlb.h>
> > +#include <linux/rwlock.h>
>                    ^^^^^^^^
>
> Erm, that should be spinlock.h.
>
> #ifndef __LINUX_RWLOCK_H
> #define __LINUX_RWLOCK_H
>
> #ifndef __LINUX_SPINLOCK_H
> # error "please don't include this file directly"
> #endif
>
> This belated comment inspired by PREEMPT_RT build meeting the above :)
>

Thank you for pointing it out! I think Sebastian had sent a patch [1] to fix it.

[1] https://www.spinics.net/lists/linux-virtualization/msg58136.html

Thanks,
Yongji