Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp1270872rwb; Fri, 19 Aug 2022 00:04:16 -0700 (PDT) X-Google-Smtp-Source: AA6agR7Avf/2+5CKV6X65jw8xh68gpjSoG8KGHS5DlrTAlqDdeDbj2L1zRT4MEE3uzwOfI8rzzYg X-Received: by 2002:a05:6402:4442:b0:43b:c866:21be with SMTP id o2-20020a056402444200b0043bc86621bemr5105310edb.28.1660892656096; Fri, 19 Aug 2022 00:04:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660892656; cv=none; d=google.com; s=arc-20160816; b=WeBvcS2pAe96KUciEW22yE+VL7yScx5ShheBG1kZl4FrXFSLGSEXaKWpk+U0aB1sja Kbqx21blAY0TR1PBleD/zAd+0dHDro90AfQEomb0LZ0He3t9CzAsGTF8ZrrPTrzpH36H ZQQwiOcXIiPnbaT6D91HeYKaxdPTEVLytaJAluA985vVmfwRzSBgxEHotItlrs6MgFSH U4jkdRrA1HHw9jfeS0V9rOd+XZIxq9u7vOs/AAKUq/mptkDNasoAfkkX8sifP1whveGc pV7B+LWAgatFgEKs7RG6z3kWCOZZIF2fCWGn2qvJGVWYTcRp4yo0tQj3BF0NbxVIVRxR kTIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=8vYByKzZPT65D4c6NN42ymtF0M1A7aOslKlFQN9sqL0=; b=Jt23Lk3y3lfz9Jbq+IhEXmackECEfb+PD2ZiueBkhn63pNWuXyZavx9j8ZReXrefFR Zpm0Hnh2nizuvRADZeZjaBQZVvjIfXSWE5FLoREBF6G0FfaTOiGTfJ2m74mzosSHZo+2 m8viZy6ROsTLWpLPp/AyTYEtjKupwQaREN04pSzMeolS+71uS/IxbW9XgS+OHBlF6337 Vw0xW/fzAeeJrmFfNKXZBSIBhsxTVCDoML+Y+qFXg61JMDFQHUu4w/jqDho6QPl5E7gz u2DZmdTn0ZT/E12a1FlkNZ5tbaZ68Dba8V7ouofoyWO2Q4liv5VB5l0XC2mxSYqwfQY5 qxkQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ypzKVpaO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dt19-20020a170907729300b0072b3b4f016bsi2696746ejc.628.2022.08.19.00.03.49; Fri, 19 Aug 2022 00:04:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ypzKVpaO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346953AbiHSHCY (ORCPT + 99 others); Fri, 19 Aug 2022 03:02:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346852AbiHSHCV (ORCPT ); Fri, 19 Aug 2022 03:02:21 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B8FBDE0FCF for ; Fri, 19 Aug 2022 00:02:19 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 50DFBB824EF for ; Fri, 19 Aug 2022 07:02:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 72A18C433C1; Fri, 19 Aug 2022 07:02:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660892537; bh=VQhHb37Uf+6d/27TYo+El26p2h/LmtFBpZJFG3bvxVI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ypzKVpaOX1/e+zkQqC7Doil8wBOCq0J05zzLkBEeMUA2y+gPdD97vdlLRnREaCFPT QJHOk28Vs5yfcXMJ9KtKz7tH4W1DYRz6gh7gJIymEJBuSmc+8o7vI0VdRhJwcLg4Mh avJhZh/qIwi3ne/fcxOlVGsQuiQ0APHh9KAJpuXA= Date: Fri, 19 Aug 2022 09:02:14 +0200 From: Greg KH To: Aaron Lu Cc: security@kernel.org, lkml , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Andrew Morton , Michal Hocko , Logan Gunthorpe Subject: Re: [PATCH 1/1] x86/mm: Use proper mask when setting PUD mapping Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 19, 2022 at 10:30:01AM +0800, Aaron Lu wrote: > commit c164fbb40c43f("x86/mm: thread pgprot_t through > init_memory_mapping()") mistakenly used __pgprot() which doesn't > respect __default_kernel_pte_mask when setting PUD mapping, fix it > by using __pgprot_mask(). > > Fixes: c164fbb40c43f("x86/mm: thread pgprot_t through init_memory_mapping()") Nit, you need a space before the '(' character or the linux-next scripts will complain :( Also, you cc:ed security@k.o and lkml. As this is public, no need to copy security@k.o at all. thanks, greg k-h