Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Received-SPF: Pass (protection.outlook.com: domain of in.bosch.com designates
 139.15.153.200 as permitted sender) receiver=protection.outlook.com;
 client-ip=139.15.153.200; helo=eop.bosch-org.com; pr=C
From:   <Gireesh.Hiremath@in.bosch.com>
To:     <krzysztof.kozlowski+dt@linaro.org>
CC:     <m.felsch@pengutronix.de>, <linux-omap@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-input@vger.kernel.org>, <bcousson@baylibre.com>,
        <tony@atomide.com>, <robh+dt@kernel.org>,
        <dmitry.torokhov@gmail.com>, <mkorpershoek@baylibre.com>,
        <davidgow@google.com>, <swboyd@chromium.org>,
        <fengping.yu@mediatek.com>, <y.oudjana@protonmail.com>,
        <rdunlap@infradead.org>, <colin.king@intel.com>,
        <Gireesh.Hiremath@in.bosch.com>, <sjoerd.simons@collabora.co.uk>,
        <VinayKumar.Shettar@in.bosch.com>,
        <Govindaraji.Sivanantham@in.bosch.com>,
        <anaclaudia.dias@de.bosch.com>
Subject: Re: [v2,2/4] Input: mt-matrix-keypad: Add Bosch mt matrix keypad driver
Date:   Fri, 19 Aug 2022 06:56:33 +0000
Message-ID: <20220819065633.9510-1-Gireesh.Hiremath@in.bosch.com>
In-Reply-To: <20220506072737.1590-2-Gireesh.Hiremath@in.bosch.com>
References: <20220506072737.1590-2-Gireesh.Hiremath@in.bosch.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Aug 2022 06:56:54.9423
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 0fcf8426-92ed-4e26-baa1-08da81b00097
X-MS-Exchange-CrossTenant-Id: 0ae51e19-07c8-4e4b-bb6d-648ee58410f4
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=0ae51e19-07c8-4e4b-bb6d-648ee58410f4;Ip=[139.15.153.200];Helo=[eop.bosch-org.com]
X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT007.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR10MB3463
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Gireesh Hiremath <Gireesh.Hiremath@in.bosch.com>

Hi Krzysztof,

>>> You wrote pretty long message explaining how the device works, but I
>>> still do not see the answer to questions - why it cannot be part of
>>> matrix keypad?
>> 
>> Following are the difference between matrix keypad and Bosch keypad
>> make us to add another keypad driver.
>> 
>> matrix keypad:
>> 	- By hardware schematic, a column GPIO line will intersect only
>> 	  with row GPIO lines, not with the other column GPIO lines
>> 	- so, row and column GPIO property are fixed, because of this
>> 	- key scanning work based on interrupt mode
>> 	- and key press is determined based on setting column as output,
>> 	  row GPIO as input and set interrupt to monitor the changes in state,
>> 	  serve the key pressed in ISR
>> 
>> Bosch keypad:
>>     - By hardware schematic column GPIO line can intersect with row GPIO line
>> 	  as well as other column GPIO lines
>> 	- so, all GPIO act as row as well as column, because of this
>> 	- key scanning based on polling mode
>> 	- a key pressed is determined by setting one of GPIO line as output and
>> 	  other as input and poll for change in the state of input GPIO lines.
>> 	  Setting one of a GPIO line as output and remaining GPIO lines as input is on
>> 	  round robin bases.
>
>Which is still not the answer "why it cannot be part of matrix keypad?".
>To me looks similar enough, although maybe not exactly superset of the
>other.

I have merged the Bosch keypad in to the matrix keypad
and sending version v3 patches to support that.

v3-0001-driver-input-matric-keypad-switch-to-gpiod.patch
v3-0002-driver-input-matric-keypad-add-reduced-matrix-sup.patch
v3-0003-dt-bindings-input-gpio-matrix-keypad-add-reduced-.patch 

>
>>>
>>> "It looks like this driver has smaller number of features than
>>> matrix-keypad, so it should be integrated into the matrix-keypad.
>>> matrix-keypad features are superset to this one."
>>>
>>> "But anyway this should be just merged into matrix-keypad. It's a
>>> simpler set of that binding."
>> 
>> This keypad driver specific to Bosch measuring tool or similar devices.
>> Please let me know to send latest patch which resolves build warning
>> and gpiod API support.
>
>That's a poor reason not to merge into existing driver... I am sorry,
>but our entire Linux kernel concept is to integrate, not duplicate. If
>each of vendors wanted their own feature, we would have unmanageable
>monstrosity with millions of drivers doing almost the same...
>
>
>Best regards,
>Krzysztof
>

Best regards,
Gireesh Hiremath