Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 19 Aug 2022 14:24:03 +0800
From:   Oliver Sang <oliver.sang@intel.com>
To:     John Garry <john.garry@huawei.com>
CC:     Damien Le Moal <damien.lemoal@opensource.wdc.com>,
        Christoph Hellwig <hch@lst.de>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Linux Memory Management List <linux-mm@kvack.org>,
        <linux-ide@vger.kernel.org>, <lkp@lists.01.org>, <lkp@intel.com>,
        <ying.huang@intel.com>, <feng.tang@intel.com>,
        <zhengjun.xing@linux.intel.com>, <fengwei.yin@intel.com>
Subject: Re: [ata] 0568e61225: stress-ng.copy-file.ops_per_sec -15.0%
 regression
Message-ID: <Yv8sg3J8PLD56osY@xsang-OptiPlex-9020>
References: <2e9cf5a6-c043-5ccf-e363-097c6c941891@huawei.com>
 <f1c3d717-339d-ba2b-9775-fc0e00f57ae3@huawei.com>
 <Yvs/w93KUkgD9f7/@xsang-OptiPlex-9020>
 <aabf7ed8-8d4d-dc68-1b8b-c91653701def@huawei.com>
 <43eaa104-5b09-072c-56aa-6289569b0015@opensource.wdc.com>
 <28d6e48b-f52f-9467-8260-262504a1a1ff@huawei.com>
 <YvzyZJUblfqN6Xj3@xsang-OptiPlex-9020>
 <743867a6-b266-58e4-a8a6-542757916f0a@huawei.com>
 <Yv2euLFLjl8bEaeI@xsang-OptiPlex-9020>
 <d1b1d434-059d-4d76-5fc6-092ab9ba6e16@huawei.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <d1b1d434-059d-4d76-5fc6-092ab9ba6e16@huawei.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?0/FcUlYpGDMPVSmuwSGwQc6QVZUweWBjJhVm45H6qVqB6p07jItBio9ZTsTy?=
 =?us-ascii?Q?x0z/uVkGa2xGTwGh1yxL/msiSOCy5cs8kBUjeOcsqqlmH2VPRx2A4PY0ylHk?=
 =?us-ascii?Q?cnO9zxjOZR3DZbixj7MHzLUk/E2qEh1ee+WCBU3kS1W4wlKGNBoAn6gZQrAn?=
 =?us-ascii?Q?TOxtPZS2uz/hPoZ8H6DQ+jPjutHTzS04or4POGWvK/LEHW69pb1yDtz4h+gK?=
 =?us-ascii?Q?n6yvHA6vZIX7Y7JUQjNL8VpWwxz86MZYnWU98Uiv3aDnLMaIFGU54iXRtO1z?=
 =?us-ascii?Q?pIOhokF3bxlCijJ0R+X6ZOze+ItB7p6zpjjWLFUhcNdU3w2w2HNKQhhuj5WX?=
 =?us-ascii?Q?fxCTyWGaQbUtGnhZvNFNk7337xbFvTFIX236U/FzWHKTboDkqXJ+H/d/F2Wl?=
 =?us-ascii?Q?P6rUma7AuVWhl+/5ksMv0BDkLt6tRhmj+b55JmSGf1UjHD/0Z4Q6Cn/mkWI7?=
 =?us-ascii?Q?0iWmn9+Vs4Vn4R/yImtz/U6R0Xsz5dDPquLJoZoBtunaHMvFSVdLrhJ0Wgwo?=
 =?us-ascii?Q?nwG3B2EqDUIi/Kc3z0dUwOlLuO1JNwB4thxzzNTD1kJJtFD0eQkhzvJDkhVh?=
 =?us-ascii?Q?c7IxFK8CTHzGwiF27w8jHk7ynLukIA3OQocFxoGklZdUGPFQMn9bt0OOBAXT?=
 =?us-ascii?Q?5yQzclPdYXv4KUcHxxJVeuZk6U3jJZjCflr2qZB7TSfv0fmNDsChv4Gn05fZ?=
 =?us-ascii?Q?7Afr+ajDh8yFEdokxZCMDkqJyZvFpps3FszUFKrVqEOXHsnWLK+efvZTI7jl?=
 =?us-ascii?Q?UvM3NyBGl7rimXlMGLCsiF3WH4gED+NCmzgO5rVjLj7ZuHmswc7Ph8byEU7K?=
 =?us-ascii?Q?f2CshcgQtpUvH35DLY0yO1HfMk1n+lHWhjg8f3ONEICYwLpfXj0quP1ZIoCs?=
 =?us-ascii?Q?tXOS4rhO6Y4IKng1qOZ4ffwo0rZMoTTxmiFpYXVy5hqBZxszyb5lirzbuOWg?=
 =?us-ascii?Q?d0TfrEZgCBUVmdBiVhFI8CYYYZ5O2vGA/rHHW/dRg3EGjcEv1x7z18/zT0l6?=
 =?us-ascii?Q?P43/Thnh1scSRkMgwSfcyD5wUdUHLPS6jF4GlPn+aTSihaLXmuOIgbgUOYHE?=
 =?us-ascii?Q?/cnUNXrg5AwmR+rM+38Fg97jy/oRxx8zoK/5xfCLSqyAaOu5OW8UqWvsDzUA?=
 =?us-ascii?Q?MPwXdlZOVm2AspJsdTCwyTTKpjuSvTOI9io4TFNyxS2zZaPw1Obo1PClPLgT?=
 =?us-ascii?Q?81VXI+/5sMuyBA9TkDeJSONmifS2Zgibt/hBxgpKhnMeed5VZvrXI12+Kr/e?=
 =?us-ascii?Q?byg8sa7ZnPlWIiFdnbBNb1YccpelWrGPoutgMhwVwanefrCFSO3aaEkL+zT1?=
 =?us-ascii?Q?xjbqkjHJWDFRtlPvcOBnHynVETBE0Qv+34PVCGT6xPYmcE3ABa/d99gLuMLj?=
 =?us-ascii?Q?SH58UJJFpcScZQsUkgpH4ttM5FZmf5W3x0NxiT1cAYiscaeHhGo4G5o8nkz7?=
 =?us-ascii?Q?TRO6NnFdmvJbLVAPpM0/ADhJ7vWmAszrOtJRHKW4iLyDm7g0PoUFicamniFU?=
 =?us-ascii?Q?2iVGXDmZP+XCKlo7d/teYYyHH6ARMCpbMC+ivWWY6g2fbD/LTwHJt+dhkFmh?=
 =?us-ascii?Q?H27g/8CR3NbaHCagi3k9qrHlUQVL1DllElUNTHhFdRCaiPDC/qnljupP8DaC?=
 =?us-ascii?Q?hA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d83fe48e-bb02-4e08-b961-08da81ab6f81
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6297.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Aug 2022 06:24:13.8071
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: n+RvRyR92OD1QnD03dFmu9MCqq1pQ9EkCxGGc5AsMPO3AkvaI3u0aSjv1ktuf2sZPoXWpzkf0Y5IZXeu6W+e4w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5115
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Aug 18, 2022 at 10:28:30AM +0100, John Garry wrote:
> On 18/08/2022 03:06, Oliver Sang wrote:
> 
> Hi Oliver,
> 
> > > > did I do the right thing?
> > > Sorry but I was not really interested in 4cbfca5f77 and I see where that
> > > build error is coming, but don't be concerned with it. However, for
> > > avoidance of doubt, if you have results for vanilla v6.0-rc1 then that would
> > > be appreciated.
> > for v6.0-rc1, it's still 512/512
> > 
> > > I will also send a separate patch for testing if you don't mind.
> > sure! we are very glad that we could help.
> 
> As you probably saw, I sent "[RFT PATCH] ata: libata: Set __ATA_BASE_SHT
> max_sectors" for testing on top of v6.0-rc1, and I hope that then we can get
> same performance as v5.19

yeah, our test confirmed your expectation:

stress-ng.copy-file.ops_per_sec
v5.19                 - 26.85
v6.0-rc1              - 23.03
v6.0-rc1 + your patch - 26.94

> 
> Thanks,
> John